fonic / ipfilter Goto Github PK

Hi, I'm getting the following errors, on macOS:

./ipfilter.sh: line 33: declare: -A: invalid option
declare: usage: declare [-afFirtx] [-p] [name[=value] ...]
(..)/ipfilter/ipfilter.conf: line 20: level1: unbound variable

I cannot think of any reason why the --force flag would not be desired when using the gzip option. Since the file is being re-created each time, it just makes sense that the compressed file would also be re-created.

Without the --force flag, the script will not run without user input (it will ask permission each time.)

I can do a pull request if you like. I've made the change locally.

Same result as rcollie.

Versions

• ipfilter.sh commit 497237d
• FreeNAS 11.2-STABLE (based on FreeBSD)
• Bash 4.4.19(0)-release

Output

--== IP Filter Updater & Generator ==--

Creating temporary folder...
mktemp: illegal option -- -
usage: mktemp [-d] [-q] [-t prefix] [-u] template ...
mktemp [-d] [-q] [-u] -t prefix
An error occured, aborting.

Originally posted by @SethWilliamson in #1 (comment)

I would like to request an option to automatically GZip the output of the script.

i have w10 1809 and use the portablegit to compile the list
The download is successful but there is a problem to get the final file

MINGW64 /
$ ./ipfilter.sh

--==[ IP Filter Updater & Generator ]==--

Creating temporary folder...
Downloading I-BlockList blocklists...
Downloading I-BlockList blocklist 'level2'...
Downloading I-BlockList blocklist 'level3'...
Downloading I-BlockList blocklist 'level1'...
Decompressing I-BlockList blocklists...
Decompressing I-BlockList blocklist 'level2'...
Decompressing I-BlockList blocklist 'level3'...
Decompressing I-BlockList blocklist 'level1'...
Merging I-BlockList blocklists...
Merging I-BlockList and GeoLite2 blocklists...
Installing final IP filter file...
cp: cannot create regular file '//ipfilter.p2p': File exists
An error occured, aborting.
Removing temporary folder...

I go to C:\Users\XXXX\AppData\Local\Temp\ and I see a folder Ipfilter.Randomstuff created, with all the lists appearing from iblocklist, then a file ipfilter.p2p appears, 17MB, then the whole folder is deleted when the error appears on the console.

In the conf file, i selected the DST path like this

# Path final output file shall be installed to (folder + file name)
# (NOTE: ${SCRIPT_DIR}: path to location of ipfilter script, ${SCRIPT_NAME}: filename of ipfilter script without extension)
# Format:  String
# Example: INSTALL_DST="/tmp/blocklist.p2p"
# Default: INSTALL_DST="${SCRIPT_DIR}/${SCRIPT_NAME}.p2p"
INSTALL_DST="D:\XXXXX\PortableGit\ipfilteriblocklist.p2p"

it fails also with the conf file being 100% original.