folz / bento Goto Github PK

Hi! I'm already using Bento to parse torrent files, and I would like to know if you'd accept a PR that implements magnet link generation from a torrent file.

Happy holidays :)

When Bento.encode/1 encounters a Tuple, an error will be reported.

iex(1)> Bento.encode {:does, :not, :work}     
** (Protocol.UndefinedError) protocol Bento.Encoder not implemented for {:does, :not, :work} of type Tuple
    (bento 1.0.0-dev) lib/bento/encoder.ex:35: Bento.Encoder.impl_for!/1
    (bento 1.0.0-dev) lib/bento/encoder.ex:56: Bento.Encoder.encode/1
    (bento 1.0.0-dev) lib/bento.ex:36: Bento.encode!/2
    (bento 1.0.0-dev) lib/bento.ex:22: Bento.encode/2
    iex:1: (file)

This is due to :erlang.binary_to_existing_atom not being able to turn "name.utf-8" into an atom (the period is what causes it to trip up).

Stacktrace

** (exit) an exception was raised:
** (ArgumentError) errors were found at the given arguments:

• 1st argument: invalid UTF8 encoding

  :erlang.binary_to_existing_atom("name.utf-8", :utf8)
  (bento 0.9.2) lib/bento/metainfo.ex:48: anonymous fn/1 in Bento.Metainfo.transform/1
  (elixir 1.12.0) lib/enum.ex:1553: Enum."-map/2-lists^map/1-0-"/2
  (elixir 1.12.0) lib/enum.ex:1553: Enum."-map/2-lists^map/1-0-"/2
  (bento 0.9.2) lib/bento/metainfo.ex:30: Bento.Metainfo.info/1
  (bento 0.9.2) lib/bento/metainfo.ex:41: Bento.Metainfo.info!/1
  (bento 0.9.2) lib/bento.ex:92: Bento.torrent!/1
  

"name.utf-8" appears to be from clients such as Vuze/Azeurus for handling old torrents that did not write the name/path's in utf-8 (see here).

I am not sure how to "properly" handle this, but for now I will just have it filter out any keys with .utf-8 in the data metainfo before parsing. Id be happy to merge those changes in, or any different change you would suggest.

Thanks for the useful library!

This reconstruction is based on three considerations:

• The development of Poison does not seem to be very active.
• After this reconstruction is implemented, our code will not rely on any external code at all.
• #15 (comment)