Git Product home page Git Product logo

laravel-hypernova's Issues

example?

Can you make an example. The Hypernova-ruby uses this in there templating engine.

<%=
  render_react_component(
    'MyComponent.js',
    :name => 'Person',
    :color => 'Blue',
    :shape => 'Triangle'
  )
%>

Can we write something like this to render a component which is wrapped with hypernova-react?

{{
  render_react_component( 'MyComponent.js', [
    'name' => 'Person', 'props' => 'value' 
  ])
}}

hypernova-php ^2.0

Looks like this package does not work with hypernova-php v2.0. Are you changing the default behavior of that package?

Middleware never executed (Bug)

Hi,

There is bug in the middleware when choosing to modify the response or not:
https://github.com/Folkloreatelier/laravel-hypernova/blob/master/src/Folklore/Hypernova/Hypernova.php#L124

This line:

$response->headers->has('Content-Type') === 'text/html'

Should be (or the like):

strpos($response->headers->get('Content-Type'), 'text/html') !== false

Also, as a side note, I believe deciding whether or not to modify the response should be handled in the middleware itself:

// Move conditions in Middleware
        if ($response instanceof BaseResponse &&
            !$response->isRedirection() &&
            (
                !$response->headers->has('Content-Type') ||
                strpos($response->headers->get('Content-Type'), 'text/html') !== false
            )
        ) {
...

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.