folded-php / session Goto Github PK

Description

This package uses an old version of folded/exception.

Proposal

Upgrade to folded/exception:0.4.*

Worarkound solutions

Notes

Description

When checking if a key exists, we should throw a SessionKeyNotFoundException instead of an OutOfRangeException.

Expected behavior

The package throw a SessionKeyNotFoundException if a accessing a non existing key.

Actual behavior

The package throw an OutOfRangeException when accessing a non existing session key.

Alternatives solutions

None.

Notes

Description

Static analysis helps catching bugs earlier.

Proposal

• Using phpstan/phpstan and run the command after the test command: pest --coverage && phpstan analyse src
• Use the level 8 for a maximum of consistency
• Use a phpstan.neon configuration file

Worarkound solutions

None.

Notes

None.

Description

When flashing a data, it is never removed when getting this data.

Reproduce the issue

1. In a web page, flash a session
2. In another web page, get the session
3. The flashed session never gets removed, and the data is always gettable

Expected behavior

The flashed data is correctly removed.

Actual behavior

The flashed data is never removed.

Notes

This happens because the flashed keys, that are tracked to be then flushed, are lost because we store them in a static property. As calling a web page completely refresh the web context, meaning the hole app is ran again, the static property gets emptied, and the code that is supposed to remove the flash key is never ran.

Description

When the code loads functions, it should detect the existance of the function under the namespace instead of just the name of the function

Expected behavior

The call of function_exists() use the full qualified namespace.

namespace Folded;

if (!function_exists("Folded\theFunction")) {
  // load the function now
}

Actual behavior

Functions declared twice enters in collision.

Alternatives solutions

None.

Description

There is no templates for bugs and enhancements, which can reduce the chances someone will want to describe his issue or can make difficult to format and clarify an issue without proper templates.

Expected behavior

Enhancements issue template

For an enhancements, the following sections (using level 2 title, ##) should be shown:

• Description
• Proposal
• Workaround solutions
• Notes

The text hints, using italic, should be shown below each of these titles (without the double quotes):

• Description: "Give some context and motivation for the proposed solution."
• Proposal: "The detail proposition. Can include code."
• Worarkound solutions: "Mention every existing workaround you know that will solve the issue apart from the proposed solution."
• Notes: "Add everything that relates the proposal, like future induced issues, related issues, ..."

Bug issue template

For a bug, the following sections (using level 2 title, ##) should be shown:

• Description
• Steps to reproduce the issue
• Expected behavior
• Workaround solutions
• Notes

The text hints, using italic, should be show below each of these titles (without the double quotes):

• Description: "Any information that can give more understanding about how you came to this issue."
• Steps to reproduce the issue: "Detail precisely how we can reproduce the issue from a blank new project (if possible)."
• Expected behavior: "Describe what the output or the behavior should be instead of the issue you have."
• Workaround solutions: "Mention every existing workaround you know that will solve the issue."
• Notes: "Add everything that relates the proposal, like related issues, ..."

Alternatives solutions

To write by hand the issue layout.

Description

The Session class is not meant to be extended. Mark it as final.

Proposal

The Session class is marked as final.

Worarkound solutions

None.

Notes

None.