fogfish / gurl Goto Github PK

Existing matcher is only designed to support Object as the root level entity.

ƒ.Match(`[ ... ]`)
ƒ.Match(`"..."`)
ƒ.Match(100)

would fail

As a developer
I want to log HTTP requests
So that it is possible to debug or trace communication with remote entity

The debug level is required to

• debug output entire HTTP request / response, including content
• notice output entire HTTP request / response, with content snippet
• info output request URL and status code

gurl.HTTP(
  ø.POST("/auth/token"),
  ø.ContentForm(),
  ø.Send("grant_type=authorization_code&code="+code),
  ƒ.Code(200),
  ...

fails with error

json: cannot unmarshal string into Go value of type map[string]string

ø.Send supports only structured input

...
ƒ.Bytes(&x),
ƒ.Value(&x).String("xxx"),
...

String fails to compare byte with string. It requires

...
ƒ.Bytes(&x),
ƒ.Value(&x).Bytes([]byte{"xxx"}),
...

The following code snippet fails with null pointer

type A struct {
   V string `json:"a"`
}

type B struct {
  A *A `json:"b"`
}

val := B{} 

http.Join(
   ø.GET("http://example/%s", &val.A.V),
...

Here is classical cases: pointer of pointer. The construct &val.A.V always points to last value but intermediate A is not initialised yet.

args needs to be escaped.

func GET(uri string, args ...interface{}) gurl.Arrow {
	return URL("GET", fmt.Sprintf(uri, args...))
}

Is the data pointer a right format to define state

[m_state ||
   Token <- access_token(),
   User <- user(Token),
   Org <- org(Token, User)
].

See
https://blog.golang.org/context
https://blog.golang.org/pipelines

ø.GET.URL("%s/%s/%d/levels/%f", ø.Authority(host), valString, valInt, valFloat)

It fails with

invalid URL escape "%!f"

Existing implementation has dependency to IO Stack. The Context pattern is a right abstraction of this type.
Make it as a context simplifies API.

Usage of ø.GET.URL becomes difficult to understand when ! symbol is used. It is not obvious when api makes escaping when not. The ø.GET.URL should support following use-case:

1. Host is know and well defined to the template
2. Host is not know and it is derived from config
3. Host is not known and it is derived during I/O
4. Path segments are defined either from const or dynamically.