Comments (6)
davidtheclark
commented on September 23, 2024
@GrosSacASac Happy to add whatever makes the library more accurate!
Can you please provide some more details? Why <details> — that doesn't seem tabbable normally? <summary> does, though, at least in Chrome. Let's make sure it's the same cross-browser.
How you tried the hidden attribute, and it's not treated correctly? I just tried it in a demo and didn't notice any problem: the hidden element was skipped as expected.
from tabbable.
GrosSacASac
commented on September 23, 2024
Yes <summary> does.
test summary
Full paragraph below summary
<details>
<summary>test summary</summary>
<p>Full paragraph below summary</p>
</details>
Yes I tried it works, my bad.
from tabbable.
GrosSacASac
commented on September 23, 2024
<audio controls> and <video>
from tabbable.
davidtheclark
commented on September 23, 2024
Sure, @GrosSacASac: open to a PR adding any fancy new elements that are tabbable!
from tabbable.
GrosSacASac
commented on September 23, 2024
PR sent !
from tabbable.
davidtheclark
commented on September 23, 2024
For anybody who comes along this issue and wants to help: the PR #21 was closed but not completed. PRs still welcome if anybody would like to add elements.
from tabbable.
Related Issues (20)
- element.matches not working in ie 11. HOT 5
- Scroll containers HOT 3
- isTabbableRadio doesn't properly escape query selectors HOT 4
- Use @testing-library/dom and Jest for tests HOT 3
- Add code coverage badge to the README HOT 5
- Restore actual browser testing with Cypress HOT 8
- support inert attribute HOT 13
- Exclude form elements in `:disabled` fieldset HOT 2
- Optimizing displayCheck: 'full' HOT 9
- Bug: isDisabledFromFieldset doesn't check the top-most disabled <fieldset> HOT 3
- Safari: Object passed in getCheckedRadio is not iterable, causing a for loop error HOT 2
- v5.3.0 breaks literally all of our usage of `tabbable` 😅 when called on a node not attached to the document HOT 40
- [MAJOR] isHidden should exclude detached nodes by default
- Firefox throws an error when checking disabled on non button element HOT 4
- IE support broken in v5.3.2+ HOT 1
- tabbable breaks when processing an element with a "scope" attribute HOT 6
- jest error Your focus-trap must have at least one container with at least one tabbable node in it at all times HOT 2
- Can't make it work testing with tabbable mocked HOT 7
- jsdom issue: 'slot):not([inert]' is not a valid selector HOT 7
- Remove nwsapi v2.2.2 override once bug is fixed
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from tabbable.