Comments (7)
@thumbsupep [email protected]
should fix the problem for now!
from tabbable.
Can confirm. I have it in a Nuxt3 project, where we use focus-trap, which uses tabbable
from tabbable.
looks like it relates to dperini/nwsapi#83
from tabbable.
@thumbsupep Thanks for bringing this to my attention. I replied on that issue. I'll see if I can add an override to tabbable's package.json to pin nswapi to v2.2.2 for now until they fix the issue.
from tabbable.
@all-contributors add @thumbsupep for test
from tabbable.
I've put up a pull request to add @thumbsupep! 🎉
from tabbable.
@thumbsupep @sbeugen There is a proposal over on dperini/nwsapi#83 to modify the Regex that seemed to be the original problem here.
But today, while trying to verify the proposed Regex changes there, I followed these steps again and could not reproduce the original issue:
$ git clone tabbable
$ rm package-lock.json
# edit package.json to __remove__ the nwsapi override
$ npm install
# this results in nwsapi v2.2.5
$ npm test
Originally, npm test
would fail with the error raised in this issue. But no more. All tests pass. They also all pass with the proposed Regex changes.
Could one of you please try your original steps but with the latest version of tabbable (and its dependencies) -- making sure to remove the override from package.json before npm install
... -- and LMK if it's still an issue for you?
from tabbable.
Related Issues (20)
- element.matches not working in ie 11. HOT 5
- Scroll containers HOT 3
- isTabbableRadio doesn't properly escape query selectors HOT 4
- Use @testing-library/dom and Jest for tests HOT 3
- Add code coverage badge to the README HOT 5
- Restore actual browser testing with Cypress HOT 8
- support inert attribute HOT 13
- Exclude form elements in `:disabled` fieldset HOT 2
- Optimizing displayCheck: 'full' HOT 9
- Bug: isDisabledFromFieldset doesn't check the top-most disabled <fieldset> HOT 3
- Safari: Object passed in getCheckedRadio is not iterable, causing a for loop error HOT 2
- v5.3.0 breaks literally all of our usage of `tabbable` 😅 when called on a node not attached to the document HOT 40
- [MAJOR] isHidden should exclude detached nodes by default
- Firefox throws an error when checking disabled on non button element HOT 4
- IE support broken in v5.3.2+ HOT 1
- tabbable breaks when processing an element with a "scope" attribute HOT 6
- jest error Your focus-trap must have at least one container with at least one tabbable node in it at all times HOT 2
- Can't make it work testing with tabbable mocked HOT 7
- Remove nwsapi v2.2.2 override once bug is fixed
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from tabbable.