PeanutButter.DuckTyping: Parameter count error when trying to invoke overloaded method about peanutbutter HOT 7 CLOSED

Looks like it's might be due to the shimsham class using a dictionary to store the method infos. If the key is just the method name, I'm suspecting it might be dropping any overloads, leaving room for just one.

from peanutbutter.

fascinating! I wasn't aware anyone else was actually using this!

any ideas for a fix? PRs are appreciated (:

from peanutbutter.

I'd probably start by modifying the lookup to use a key of tuple: (string: Type[]) so that the correct overload can be selected (or to be an IDictionary<string, MethodInfo> and select the correct one lazily - this might be slower if it's hot code, but probably provides the most flexibility

you're certainly using this beyond the original scope, but that's pretty cool (:

from peanutbutter.

I must admit that I rarely use this for method ducking - but I use this a lot for property ducking, especially off to dictionaries and NameValueCollections, so I'm quite pleased that someone else is (a) finding it useful and (b) pushing boundaries

from peanutbutter.

@aracicot-fusebill please check out package 3.0.10 - I've implemented overloads and also improved the fuzzy ducker for the case where the interface method and the ducked type have the same parameters, just in different orders, based on type - this won't re-order according to name, ie if we have:

// concrete type
public class Worker
{
  public void DoWork(string str, int a)
  {
  }
}

// ducked interface
public interface IMyWorker
{
  void DoWork(int a, string foo)
  {
  }
}

then we can do worker.FuzzyDuckAs<IMyWorker>() and expect DoWork to work appropriately, but if we have

public class Stringy
{
  public void DoWork(string first, string second)
  {
  }
}

// ducked interface
public interface IMyStringy
{
  void DoWork(string second, string first);
}

then we can DuckAs<IMyWorker>() but the order of parameters will not be switched in the call

from peanutbutter.

@aracicot-fusebill have you had a chance to check out the latest package & see if it does what you're expecting?

from peanutbutter.

@aracicot-fusebill closing as I believe I've sorted this out; please re-open if need be.

from peanutbutter.