Git Product home page Git Product logo

Comments (6)

AndrewKeepCoding avatar AndrewKeepCoding commented on August 21, 2024 1

I opened a PR. Please take a look. It's a bit different from what you suggested but I think we can avoid change in current use cases.

from peanutbutter.

AndrewKeepCoding avatar AndrewKeepCoding commented on August 21, 2024 1

@fluffynuts The old library works now. Thanks for the quick support!

from peanutbutter.

fluffynuts avatar fluffynuts commented on August 21, 2024

Typically, PB.INI trims your INI file; but I don't see a problem with adding an extra newline - is that all that's required?

from peanutbutter.

AndrewKeepCoding avatar AndrewKeepCoding commented on August 21, 2024

Yes. I did a manual test and this old library didn't load the INI file until I added a new line to the INI file trimmed by PB.INI. Can I make PB.INI not to trim the line at the bottom?

from peanutbutter.

fluffynuts avatar fluffynuts commented on August 21, 2024

not currently - you're welcome to open a PR - I don't think this would negatively affect any other use-case, and the PR should be fairly simple:

2 modifications (for the 2 Persist methods that actually do work - one goes to a file, the other pushes lines to a stream) and 2 tests that prove that they happen. There may be other tests which are broken by the change, but they shouldn't be hard to fix - trim the result of the "Act" block and they should all pass again. Alternatively, I can look at this tomorrow, perhaps.

from peanutbutter.

fluffynuts avatar fluffynuts commented on August 21, 2024

@AndrewKeepCoding 3.0.6 contains the changes from your PR. Thanks for contributing!

from peanutbutter.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.