Git Product home page Git Product logo

flowplayer-background's Introduction

flowplayer-background

Flowplayer background video plugin

flowplayer-background's People

Contributors

nnarhinen avatar phloxic avatar

Stargazers

 avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

flowplayer-background's Issues

Silence player on ready (once core localStorage issue is fixed)

  1. api.volume() and api.mute() have no effect on boot - flowplayer/flowplayer#1265
  2. api.volume() and api.mute() one progress come too late (short pang if sound starts right away)

The correct place is on ready. Can't be imlemented though because of flowplayer/flowplayer#1264.

Note re 2: api.volume() and api.volume one progress with engine plugins (hlsjs, dashjs) come too early (video tag not available) and have no effect. To be investigated.

Plugin not IE8 compatible

IE8 errors out when rgba CSS rule is dynamically added as style attribute.

Try parsing background.mask config (default: rgba(255, 255, 255, 0.7)):

  • if rgba, split into rgb background-color and opacity filter directives
  • otherwise fail over to 'transparent'

Make loop configurable

Some cases background video plugin is perfect to add "animation" in to website. If animation is complex then it is easier to add as a video, but bg video plugin does not allow setting 'loop' as false.

By default loop should be true.

"Stop animation when it finish."

Why set min-height ?

Hi,
I noticed that background video plugin is setting min-height for the parent element, why?

      // Make sure container element grows to at least video size
      var container = root.parentNode;
      function setMinHeight() {
        common.css(container, 'min-height', common.height(root) + 'px');
      }
      setMinHeight();
      bean.on(window, 'resize', setMinHeight);
    });

I noticed this because that breaks things on my setup. I also noticed that nothing gets broken if I remove 'min-height' from the element.

I'm using Bootstrap responsive embed in my setup and that is taking care of the video size.

I'm also using Reveal.js which applies 'zoom' or 'transform: scale()' for the "root" element on my setup and it seems that setting that 'min-height' when scale() is applied breaks things.

On Chrome zoom: 1.36641 gives min-height of 669.994px which is ok, but Firefox and IE are using scale and scale(1.36641) gives min-height of 915.5; which is not ok. Note that scale and zoom are identical, but height calculation gives 245,4px difference.

I cannot provide jsfiddle, but I attach screenshots from the case. There is background image behind the background video which is showing up on Firefox.
screen shot 2017-01-03 at 10 22 39
screen shot 2017-01-03 at 10 23 02

My opinion is that background video plugin should not take care of the container size, instead its function is to take care that controls are not showing up, its playing video automatically and handling mute (+ overlay). Developer should take care of the container size and whether video should keep aspect ratio or be stretched. But this is only my opinion :)

I'll fix for now my setup using min-widht: auto!important; to override that inline style.

Use splash image

If splash image is configured for the player, background video plugin should use that image as still image for devices which cannot autoplay videos.

Configuring it in this way is not good when you need to make it dynamic (change per video):

#background.is-loading {
  background-color: #9cf;
  background-image: url(//cdn.flowplayer.org/202777/210503-snap.jpg);
}

Also using already existing way makes documentation more simple.

Pubilsh on npm

npm install flowplayer-background

Registry returned 404 for GET on https://registry.npmjs.org/flowplayer-background

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.