floriscreyf / mp3-decoder Goto Github PK

problem - cannot get length of buffer
you are using std::ifstream, why not use std::vector or std::string?

Also, such a mix is a sign of error-prone code style.
you may easily forget delete[] operator.

Do it modern way!
here is replacement version, 4 lines of code, each does bunch of things
Logic is extremely clear:
1. open file
2. create buffer
3. read file to buffer
4 return it

std::string get_file(const std::string& fileName) {
std::ifstream dataFile(dir, std::ios::in | std::ios::binary | std::ios::ate);
std::string dataBuffer(dataFile.tellg(),0);
dataFile.seekg(0, std::ios::beg).read(&dataBuffer[0], dataBuffer.size());
return std::move( dataBuffer );
}

Hi, I commented out stream() definition and use in main.cpp but that was not enough to make it compile.

Severity	Code	Description	Project	File	Line	Suppression State
Error	LNK2005	"struct <unnamed-type-band_index_table> band_index_table" (?band_index_table@@3U<unnamed-type-band_index_table>@@A) already defined in main.obj	mp3-decoder	Z:\mp3-decoder-master\mp3.obj	1	
Error	LNK2005	"struct <unnamed-type-band_width_table> band_width_table" (?band_width_table@@3U<unnamed-type-band_width_table>@@A) already defined in main.obj	mp3-decoder	Z:\mp3-decoder-master\mp3.obj	1	
Error	LNK2005	"struct <unnamed-type-quad_table_1> quad_table_1" (?quad_table_1@@3U<unnamed-type-quad_table_1>@@A) already defined in main.obj	mp3-decoder	Z:\mp3-decoder-master\mp3.obj	1	
Error	LNK1169	one or more multiply defined symbols found	mp3-decoder	Z:\mp3-decoder-master\Debug\mp3-decoder.exe	1	

I'm not experienced enough to be able to solve this. I'm guessing all these are related:

• https://docs.microsoft.com/en-us/cpp/error-messages/tool-errors/linker-tools-error-lnk2005?f1url=https%3A%2F%2Fmsdn.microsoft.com%2Fquery%2Fdev15.query%3FappId%3DDev15IDEF1%26l%3DEN-US%26k%3Dk(LNK2005)%26rd%3Dtrue
• https://stackoverflow.com/questions/1433204/how-do-i-use-extern-to-share-variables-between-source-files
• https://stackoverflow.com/questions/2125209/linker-errors-even-though-i-prevent-them-with-ifndef

PS: also id3.cpp was causing failure in line 111 while (!std::regex_match((string){(char)buffer[i]}, re) && i < size) {, which I turned into

	string istep;
	istep = (char)buffer[0];

	while (!std::regex_match(istep, re) && i < size) {
		istep = (char)buffer[i];

The offending line is

set_side_info(&buffer[4]);

which fails to consider the case in which the CRC bit is 0, which would make the index 6 instead of 4.