flintlib / antic Goto Github PK

Antic has been merged into FLINT -- use https://github.com/flintlib/flint/ instead

License: GNU Lesser General Public License v2.1

C 88.66% MATLAB 5.20% Makefile 2.73% Shell 0.33% CMake 1.23% Python 1.84%

antic's Introduction

ANTIC -- Algebraic Number Theory In C
======================================

Antic is an algebraic number theory library.

The only dependency at present is flint2 (see http://flintlib.org).

To install Antic, clone the repository into a directory on your filesystem,
e.g. /home/username/antic and follows the instruction in the INSTALL file.

William Hart -- 12 May 2013.

antic's People

Contributors

Stargazers

Watchers

Forkers

fredrik-johansson fieker thofma videlec pp1992m rostislav saraedum flatsurf albinahlback tunnel-cash jgmbenoit ishandutta2007 barracuda156 fingolfin

antic's Issues

Out-of-tree builds

Is it possible to build antic out-of-tree? (i.e., the equivalent of mkdir build, cd build, ../antic/configure, make)

It seems that ./configure wants to run in the source tree. I could create a PR that autoconfiscates antic if that's helpful.

Missing test programs

Some functions are untested, e.g.:

nf_elem_is_gen
nf_elem_get_coeff_fmpz

nf_elem_reduce sometimes canonicalises and sometimes doesn't

nf_elem_reduce canonicalises its input when the field is quadratic or higher, but doesn't canonicalise when the field is linear.

This should probably be made consistent. Otherwise, users that want to perform reduction + canonicalisation will either have to perform the canonicalisation twice or make a case distinction depending on whether the field is linear.

The current behavior is not documented, in any case.

__ANTIC_RELEASE

Is there something like __FLINT_RELEASE that can be used to determine the version of ANTIC?

Library Not installing

I have just done

./configure --disable-static
make

I get lots of errors. Errors look like this :

undefined reference to `_imp_nf*'

PS: I am on Msys2 MinGWx64 on windows10

t-init-clear segfault with flint 2.9.0

Since I updated flint to 2.9.0 in Debian, antic broke (see the red Regression links):

make: Entering directory '/tmp/autopkgtest-lxc.ahzsw60a/downtmp/autopkgtest_tmp/tests/nf'
cc -I/usr/include/antic    t-init_clear.c  -lantic -lflint -lgmp -o t-init_clear
+-+-+-+ t-init_clear +-+-+-+
init/clear....Segmentation fault

is it a known issue?

Is there a released tarball?

I would like to package ANTIC for conda-forge. Are there any releases (planned) so that packagers could use an official tarball to build from?

License File

The license file that was just added says LGPL2.1 but most files say GPL2+ in their headers. Would you mind adding something to the readme that clarifies the license situation? Is it LGPL2.1-or-later?

Question

Can the NUCOMP algorithm here use forms with a negative discriminant, as in "Solving the
Pell Equation" the NUCOMP given there is for positive discriminate only.

Thank you!

Antic says I don't have fmpz_gcd3

Clearly I have fmpz_gcd3.

And by the way, wouldn't it be better to print HAVE_FMPZ_GCD3 into some file instead of the current method of setting it to a C-flag?

Build broken

Since the recent changes in #18 and #19 I cannot build antic anymore:

.../antic/nf.h:30:25: fatal error: flint/flint.h: No such file or directory

@wbhart I would like to update the antic version of Nemo but this is blocking it.

please document fmpz[3] for qnf_elem

To store a quadratic element only two integers are needed for the numerator. But this is declared as

typedef struct /* element of a quadratic number field */
{
   fmpz num[3];
   fmpz_t den;
} qnf_elem_struct;
typedef qnf_elem_struct qnf_elem_t[1];

It would better be documented what does the third term in the numerator is used for (and if we are free to use it as a temporary variable).

Implement test for `nf_elem_scalar_[div/mul]_XXX`

~~Can be causing #74. Hard to know without any tests for the function.~~

Edit: It would still be nice to know that these work as intended.

flint2 isn't the only dependency

README says The only dependency at present is flint2 which is wrong. gmp and mpfr are also dependencies.

Versioning of macOS library

In the conda-forge distribution, we are seeing errors for programs that were built against antic 0.2.4 when installing 0.2.5.

cling::DynamicLibraryManager::loadLibrary() [/Users/runner/miniforge3/conda-bld/flatsurf_1659591997916/[…]/lib/libexactreal.6.dylib, 9):
Library not loaded: @rpath/libantic-0.2.4.dylib

I don't really understand how library naming works on macOS but could it be that this library should be called libantic.0.dylib instead of libantic-0.2.4.dylib?

The relevant part of the configure script is here:

ANTIC_LIBNAME="libantic.dylib"
ANTIC_LIB="libantic-$ANTIC_MAJOR.$ANTIC_MINOR.$ANTIC_PATCH.dylib"
EXTRA_SHARED_FLAGS="-install_name $PREFIX/lib/$ANTIC_LIB -compatibility_version $ANTIC_MAJOR.$ANTIC_MINOR -current_version $ANTIC_MAJOR.$ANTIC_MINOR.$ANTIC_PATCH";;

According to Apple Docs, we should probably change this. It says:

Listing 3 Generating version 1.0 of the Ratings dynamic library
[Ratings/1.0]% make dylib `clang -dynamiclib -std=gnu99 Ratings.c -current_version 1.0 -compatibility_version 1.0 -fvisibility=hidden -o libRatings.A.dylib`
This list indicates where the major version, minor version, and compatibility version are specified:
The major version number is specified in the library’s filename as “A” in -o libRatings.A.dylib.
The minor version number is specified in -current_version 1.0.
The compatibility version number is specified in -compatibility_version 1.0.

Please add license

I would like to create the FreeBSD package, and it isn't clear what the license is.

The test for `mod_fmpz` fails

Output:

mod_fmpz....FAIL: Reducing without denominator
f = 1/3*x^3+1/3*x-1/3
a = 0
b = 0
c = 0
n = 39613779025677300323867164673

Fails both on FLINT branches trunk and flint-2.8, with Antic being current state of trunk.

Compatibility with flint 2.6

In 2d6a93c antic was adapted to API changes in flint 2.7. In e-antic we would like to support both flint 2.6 and 2.7 to make upgrading easier.

I could add a few #ifdefs to make antic work with flint 2.6 and 2.7. Should I go ahead and create a Pull Request?

Test failure in mul_gen

fredrik@agm:~/src/antic$ export ANTIC_TEST_MULTIPLIER=10
fredrik@agm:~/src/antic$ make check MOD=nf_elem
make[1]: Entering directory '/home/fredrik/src/antic'
make[1]: Nothing to be done for 'shared'.
make[1]: Leaving directory '/home/fredrik/src/antic'
make[1]: Entering directory '/home/fredrik/src/antic/nf_elem'
get_fmpz_mod_poly....PASS
init/clear....PASS
set_si_ui...PASS
mul....PASS
set_coeff_num_fmpz....PASS
div....PASS
mul_gen....FAIL:
K = Number field with defining polynomial -1/166153499473114484112975882535010304*x-1/23736214210444926301853697505001472
a = -7
b = 47270499
p1 = 110297831/6148914691236517205
p2 = -330893493
../Makefile.subdirs:84: recipe for target '../build/nf_elem/test/t-mul_gen_RUN' failed

Remark: the default ANTIC_TEST_MULTIPLIER=1 is really too low. Some of the tests only run 10 or 100 iterations. I would bump it at least to 10. Maybe manually add more test iterations specifically for low-degree number fields.

Build failure with flint-3.0.1

/wrkdirs/usr/ports/math/antic/work/antic-0.2.5/qfb/exponent_element.c:137:4: error: use of undeclared identifier 'n_primes_t'
   n_primes_t iter;
   ^
/wrkdirs/usr/ports/math/antic/work/antic-0.2.5/qfb/exponent_element.c:142:4: warning: implicit declaration of function 'n_primes_init' is invalid in C99 [-Wimplicit-function-declaration]
   n_primes_init(iter);
   ^
/wrkdirs/usr/ports/math/antic/work/antic-0.2.5/qfb/exponent_element.c:142:18: error: use of undeclared identifier 'iter'; did you mean 'iters'?
   n_primes_init(iter);
                 ^~~~
                 iters
/wrkdirs/usr/ports/math/antic/work/antic-0.2.5/qfb/exponent_element.c:131:16: note: 'iters' declared here
   slong i, j, iters = 1024, restart_inc;
               ^
/wrkdirs/usr/ports/math/antic/work/antic-0.2.5/qfb/exponent_element.c:144:11: warning: implicit declaration of function 'n_sqrt' is invalid in C99 [-Wimplicit-function-declaration]
   sqrt = n_sqrt(B1);
          ^

Version: 0.2.5
FreeBSD 13.2

get_fmpz_mod_poly.c:32:31: error: too few arguments to function call, expected 2, have 1

Log: http://beefy10.nyi.freebsd.org/data/114i386-default/559040/logs/antic-0.2.23.log

get_fmpz_mod_poly.c:32:31: error: too few arguments to function call, expected 2, have 1
        fmpz_mod_poly_zero(pol);
        ~~~~~~~~~~~~~~~~~~    ^
/usr/local/include/flint/fmpz_mod_poly.h:268:1: note: 'fmpz_mod_poly_zero' declared here
FMPZ_MOD_POLY_INLINE 
^
/usr/local/include/flint/fmpz_mod_poly.h:19:30: note: expanded from macro 'FMPZ_MOD_POLY_INLINE'
#define FMPZ_MOD_POLY_INLINE static __inline__
                             ^
get_fmpz_mod_poly.c:38:44: error: too few arguments to function call, expected 3, have 2
            fmpz_mod_poly_fit_length(pol, 1);
            ~~~~~~~~~~~~~~~~~~~~~~~~       ^
/usr/local/include/flint/fmpz_mod_poly.h:124:11: note: 'fmpz_mod_poly_fit_length' declared here
FLINT_DLL void fmpz_mod_poly_fit_length(fmpz_mod_poly_t poly, slong len,
          ^
get_fmpz_mod_poly.c:39:66: error: no member named 'p' in 'fmpz_mod_poly_struct'
            fmpz_mod(pol->coeffs + 0, LNF_ELEM_NUMREF(a), &(pol->p));
                                                            ~~~  ^
get_fmpz_mod_poly.c:46:40: error: too few arguments to function call, expected 3, have 2
        fmpz_mod_poly_fit_length(pol, 3);
        ~~~~~~~~~~~~~~~~~~~~~~~~       ^
/usr/local/include/flint/fmpz_mod_poly.h:124:11: note: 'fmpz_mod_poly_fit_length' declared here
FLINT_DLL void fmpz_mod_poly_fit_length(fmpz_mod_poly_t poly, slong len,
          ^
get_fmpz_mod_poly.c:47:62: error: no member named 'p' in 'fmpz_mod_poly_struct'
        fmpz_mod(pol->coeffs + 0, QNF_ELEM_NUMREF(a), &(pol->p));
                                                        ~~~  ^
get_fmpz_mod_poly.c:48:66: error: no member named 'p' in 'fmpz_mod_poly_struct'
        fmpz_mod(pol->coeffs + 1, QNF_ELEM_NUMREF(a) + 1, &(pol->p));
                                                            ~~~  ^
get_fmpz_mod_poly.c:49:66: error: no member named 'p' in 'fmpz_mod_poly_struct'
        fmpz_mod(pol->coeffs + 2, QNF_ELEM_NUMREF(a) + 2, &(pol->p));
                                                            ~~~  ^
get_fmpz_mod_poly.c:56:42: error: too few arguments to function call, expected 3, have 2
        fmpz_mod_poly_fit_length(pol, len);
        ~~~~~~~~~~~~~~~~~~~~~~~~         ^
/usr/local/include/flint/fmpz_mod_poly.h:124:11: note: 'fmpz_mod_poly_fit_length' declared here
FLINT_DLL void fmpz_mod_poly_fit_length(fmpz_mod_poly_t poly, slong len,
          ^
get_fmpz_mod_poly.c:58:69: error: no member named 'p' in 'fmpz_mod_poly_struct'
            fmpz_mod(pol->coeffs + i, NF_ELEM_NUMREF(a) + i, &(pol->p));
                                                               ~~~  ^
get_fmpz_mod_poly.c:70:71: error: too few arguments to function call, expected 4, have 3
            fmpz_mod_poly_scalar_div_fmpz(pol, pol, LNF_ELEM_DENREF(a));
            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~                             ^
/usr/local/include/flint/fmpz_mod_poly.h:441:11: note: 'fmpz_mod_poly_scalar_div_fmpz' declared here
FLINT_DLL void fmpz_mod_poly_scalar_div_fmpz(fmpz_mod_poly_t res, 
          ^
get_fmpz_mod_poly.c:72:71: error: too few arguments to function call, expected 4, have 3
            fmpz_mod_poly_scalar_div_fmpz(pol, pol, QNF_ELEM_DENREF(a));
            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~                             ^
/usr/local/include/flint/fmpz_mod_poly.h:441:11: note: 'fmpz_mod_poly_scalar_div_fmpz' declared here
FLINT_DLL void fmpz_mod_poly_scalar_div_fmpz(fmpz_mod_poly_t res, 
          ^
get_fmpz_mod_poly.c:74:70: error: too few arguments to function call, expected 4, have 3
            fmpz_mod_poly_scalar_div_fmpz(pol, pol, NF_ELEM_DENREF(a));
            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~                            ^
/usr/local/include/flint/fmpz_mod_poly.h:441:11: note: 'fmpz_mod_poly_scalar_div_fmpz' declared here
FLINT_DLL void fmpz_mod_poly_scalar_div_fmpz(fmpz_mod_poly_t res, 
          ^

At one point perhaps distributions (Debian, Gentoo, Arch, Sage, etc) will want to package ANTIC, and having it in a self-contained way with just a dep on FLINT will be important.

Thanks,

Snark on #debian-science