[FNA] [EASY] Using Statement Cleanup about fna-mghistory HOT 14 CLOSED

I'll start us off. I'll take the three SDL2/* folders.

from fna-mghistory.

Hey Flibiti!:

While we're talking about code analysis, I've noticed something on the topic of 'using' statements. Now, we probably don't want to do what I'm about to point out (I say based on the fact that I see almost no other projects doing it at this point), but I thought I'd bring it up:

Some tools, like StyleCop, recommend putting the using statements inside of the namespace: http://www.stylecop.com/docs/SA1200.html

There seems to be /some/ /minor/ benefit to it. Then again.... StyleCop also suggest doing some things I think are bat-shit crazy, so I'm not necessarily suggesting we do this. Anyway, I just thought I would at least do due diligence and broach the topic so that you could consider it before we touch this section of all the files.

from fna-mghistory.

I do need to take a look at StyleCop... while I dunno if we'll use all the
rules, we can probably get something out of it. I'll assess this at some
point.

from fna-mghistory.

Oh, we definitely don't want to use all of StyleCop's rules. I think by default it has crap like NO TABS, no space after casts, and other things that aren't compatible with the styling we just did. But, we may still want to use a few of the rules that have more solid reasoning.

from fna-mghistory.

I'll take on Media and Storage also.

from fna-mghistory.

I've actually got this all autogenerating now. So don't worry about it @3vi1.

from fna-mghistory.

Coolio. Be care of the conditional includes.

from fna-mghistory.

Will do! Not looking forward to that though. I've checked 3 folders and so far so good, but they've been 'easy' ones.

from fna-mghistory.

Only three files had conditionals thankfully. I just added them to the skiplist on the autogen and did them manually.

All done though!

from fna-mghistory.

This is the script that was used to generate that under Python3.
https://gist.github.com/rlabrecque/10949932

The other half of this issue needs to be resolved with something like Resharper. One hotkey to remove all of the unused using statements. Please no one spend your time checking each statement manually, there are other FNA issues that need doing!

from fna-mghistory.

I've go the other half. I didn't see any Linux tools for mono to remove the unused using directives, so I stomped on a copy of the git by running it through the VS productivity power tools in a VM, which has a project option to organize and remove using directives. Unfortunately, it's not the kind of organizing we'd like.

Anyway: the git diff's not horribly long, and I should be able to spot the ones that are clean removes easily, so I'll manually read through it and submit a pull for any items we can remove.

from fna-mghistory.

#199 should take care of it.

from fna-mghistory.

So we ended up tearing through this task with two sets of automated tools. Neat.

If someone wants to do a second pass by hand, they can, but taking a quick look at the source it all seems to be neatly packed and organized now.

from fna-mghistory.

This may need another pass at some point before FNA 1.0. Some recent work like the IGLDevice shook up a number of files, so unused statements have been slowly crawling back...

ca5eca6

... but it's not a big deal just yet. Maybe once we're in the final stretch we can do this one more time.

from fna-mghistory.