[Song] Replace SDL2_mixer with Vorbisfile#/DynamicSoundEffectInstance about fna-mghistory HOT 10 CLOSED

I just finished the first draft of this task:

https://github.com/flibitijibibo/MonoGame/tree/vorbisfile-cs
af3a640

Vorbisfile# now works on 32/64-bit and Song playback now seems to work pretty well. My only problem is one that actually persists with the audio engine itself; since all work is on the main thread, if your game hangs during, say, loading (Capsized is my example), the music will stop, whereas SDL2_mixer (and Windows Media Player, for that matter) could keep going on its own thread as usual.

I would greatly appreciate any testing. Note that Vorbisfile-CS is Yet Another Project File you'll need to include in your game's sln until I make the changes needed to statically link everything together.

from fna-mghistory.

For now I've crumbled and moved the OpenALDevice update to a thread:

dd2015a

This fixes Song and CPU perf still seems okay, but y'all know how I am about threads.

from fna-mghistory.

Looks awesome, will be testing this soon!

from fna-mghistory.

The vorbisfile-cs branch has been updated for the new FNA changes.

from fna-mghistory.

Going to be merging this next week, so last call for testing. Things to test:

• Calls to SoundEffect.Play() and DynamicSoundEffectInstance.Play() (new OpenALDevice thread locks instance lists, may affect performance)
• Song-to-Song transitions (check for inaccurate overlap, gaps in playback, etc.)
• Song volumes (check to see if setting the volume frequently presents new problems)

EDIT: Don't bother testing Position; never implemented it and it didn't work with SDL2_mixer anyway, sooo... maybe when I get a port that uses it.

from fna-mghistory.

The merge for this is getting delayed, so you've got a bit more time to test this. The MojoShader# issue became a bit more urgent, so I may not be able to look at this until that's settled.

from fna-mghistory.

I'm not sure if this is helpful at this point in time now but I remember this project having a issue with interoping with Vorbisfile. I found something better, https://nvorbis.codeplex.com/ . NVorbis is a fully C# written Ogg Vorbis decode that works on mono too, all it needs it one managed .dll (doesn't reference anything else). Works quite well for me for playing Ogg Vorbis though XAudio2.

from fna-mghistory.

The interop has been fixed in the latest version of Vorbisfile#. At this point the only thing keeping me from merging it is the new thread, but I may try working around that soon.

from fna-mghistory.

I just pushed what's basically a rewrite of the thread used to update the Song stream. Instead of the OpenALDevice owning the thread, now it's just the Song that uses a thread to update. We do this by making an "unmanaged" version of DynamicSoundEffectInstance used by Song, which is updated in the SongThread. This not only removes the thread if you don't use Song (which is as it is now), but it basically mimics what we're doing with SDL2_mixer anyway, as far as thread count is concerned.

This works for my games, so all I need is one other dev to verify this and I'll merge it into mainline. It can be as soon as today, up to you all!

from fna-mghistory.

While I've not verified this with other developers, I've merged this in since it works for all of my titles and I'm eager to cut the dependency list down now that the site's up and people are starting to look at this a bit more.

If this doesn't work for your title, file an issue ASAP.

from fna-mghistory.