[FNA] [MEDIUM] Remove unused defs about fna-mghistory HOT 16 CLOSED

Taking Content/*.

from fna-mghistory.

Taking Storage.

from fna-mghistory.

One bit of clarification, please...

MonoGame-SDL2 only ever has these defs: SDL2, OPENGL, and DEBUG... Basically, you're going to dive into every file and rip out any code that does NOT fit in one of the above defs.

In FNA can we assume that SDL2 would always be defined, and just remove the #if SDL2 conditions entirely? I ask, because I see some #else's hanging on #if SDL2 defs, and it would seem the proper thing to do for this task is drop the else, and remove the conditionals entirely if the not-def SDL2 code path is dead.

from fna-mghistory.

Ah, yeah: the SDL2 paths will be the only paths, so you can remove those conditionals. By FNA 1.0 both SDL2 and OPENGL should not be needed.

from fna-mghistory.

Coolio. Thanks for answering that so fast!

from fna-mghistory.

Taking Input and Input/Touch

from fna-mghistory.

Taking Graphics/Vertices/

from fna-mghistory.

Taking Media

from fna-mghistory.

Just updated the task list with all the related commits, great work on all of this so far!

from fna-mghistory.

Is Graphics/PackedVector done already or are there no defs to remove? I did a visual inspection and some grepping, but couldn't find anything to remove.

from fna-mghistory.

Looks like there are no defs! Will remove that now... I sorta just copypasted the same TODO list to all the folders, so some might not actually need work.

from fna-mghistory.

Ok. I'll take Graphics/. I see some in there.

from fna-mghistory.

@flibitijibibo: How should I handle Graphics/OpenGLDevice.cs's DISABLE_FAUXBACKBUFFER? I know you were in that file a lot recently. If we're removing all defs, then should the !DISABLE_FAUXBACKBUFFER case be the ones to keep?

EDIT: Taking a look at the def more makes me think that's one to keep since it is specific to this file. I have the rest of the folder done. I'll commit and pull request when I hear back on this.

from fna-mghistory.

Most of those defs should have a #region describing them at the top of the file. Those configurable defs should be left in. If there's a def not listed but looks like it should be configurable, let me know.

from fna-mghistory.

taking ./

from fna-mghistory.

We've removed all the defs where it matters! Thanks to everyone that looked at this.

from fna-mghistory.