flavioarfaria / catalog Goto Github PK

When adding KtDoc contents to an string's content, for example:

...
    <!--
    Welcomes the user to the app
    @author Arnau Mora
    @since 20221206
    -->
    <string name="welcome">Welcome, user!</string>
...

Since the content is indented, this is the comment that gets generated:

/**
 * Welcomes the user to the app
 *     @author Arnau Mora
 *     @since 20221206
 */
context(Context)
@Composable
@ReadOnlyComposable
public inline fun Strings.welcome(): CharSequence = stringResource(R.string.welcome)

Maybe trimming all the lines that start with spaces and @ could be a fix. Or simply trimming each line would fix it.

Catalog's Gradle plugin currently includes dependencies on both the Android and Kotlin Gradle plugins which forces an additional set of these rather large and unnecessary transitive dependencies being included in the dependency graphs of end users. Since Catalog generates Kotlin code for use in Android apps, it is very safe to assume that both these dependencies will already exist on the plugin classpath of users.

Lowering these from implementation to compileOnly will be a sufficient resolution for this.

Prior art

• slackhq/keeper-gradle-plugin
• slackhq/slack-gradle-plugin

This happens after I add a dependency on this project.

For reference my Gradle Plugin Version is 7.3.1

Hi, I've been trying to set up the plugin to be used with Jetpack Compose, and I have the following string:

<string name="welcome">Welcome back!</string>

The issue is that it gets generated twice, one for Context context, and the other for the Fragment context:

context(Context)
@Composable
@ReadOnlyComposable
public inline fun Strings.welcome(): CharSequence = stringResource(R.string.welcome)

context(Fragment)
@Composable
@ReadOnlyComposable
public inline fun Strings.welcome(): CharSequence = stringResource(R.string.welcome)

Then, when I try to call

com.flaviofaria.catalog.runtime.compose.Strings.welcome()

This is thrown:

None of the following functions can be called with the arguments supplied.
Strings.welcome() defined in com....
Strings.welcome() defined in com....

GenerateResourceExtensionsTask makes a call to Task.project here which is incompatible with configuration caching.