Hi,
I'm testing the plugin on a flarum board and I'm getting this inconsistency when using an adsense responsive html block inside "Ad position in the left column under tags on frontpage":

It's appearing partially under the discussions list.

Currently, ad slots between posts are calculated by considering only the currently rendered posts (PostStream children):

https://github.com/FriendsOfFlarum/ads/blob/44f401a207ef2ca39684367a4339a7b6ea7b9bb2/js/src/forum/addAdBetweenPosts.js#L13-L26

This has the side effect that when new posts are loaded "above", ad slots are recalculated and might be positioned differently, since the code assumes that the first post of the discussion is the first vnode in the stream.

One solution to this would be to use the actual post number (post.attrs['data-number']) instead of the index of the vnode (i), and the total posts count (this.count()) instead of the total number of loaded comments (commentPosts.length). The main difference would be that all kinds of posts would be taken into account for the "between" count, instead of only the comment posts. I'm not even sure if this is better or worse in terms of where you would expect ads to be placed... But it is a solution.

It would be great if we could turn ads on/off by user group. So we could have a group of paid members that wouldn't see ads and public members that would see ads.

Or even better, be able to enable/disable each ad position by group for more control.

While switching on topics or pages, adsense ads under navigational headers are not being reloaded. This means, one ad is staying for the whole visit of a user, till he reloads the page, which is not effective.

My suggestion is to reload the ad after switching pages, each time or x times.

An enhancement would be to show ads only to guests.
It would be also interesting to set specific ad areas to a specific group/s only.

For example: Guest -> All ad areas, Donators -> only sidebar, Members -> only in between posts

Using the dark theme in Flarum within post ads creates an issue with the dividers for the ad. The bottom divider line is correctly dark but the divider line above the add is white:

Currently when you paste your ad code into:

"Ad position in the left column under tags on frontpage"

This ad in mobile mode becomes a top ad. I would love to be able to specify different code to use for the top spot in mobile mode.

Thanks, keep up the great work!

When using Flagrow Ads with AdSense banners, it seems there are problems when viewing the forum with Mozilla Firefox (tested with v63).

Particularly, this error is shown in the console every time an AdSense banner is attempted to be rendered:

TagError: adsbygoogle.push() error: No slot size for availableWidth=0

My configuration is the following. In Admin => Appearance => Custom header I put the AdSense script include:

I know it's not the best idea, but the easiest.

In Admin => Ads, I have the AdSense code for the banners:

The issue can be seen live on this forum: https://forum.fibra.click/

Or, as reported here, also on https://www.seekadventure.net/

If testing with Firefox in incognito mode, be sure to disable "Content/tracking blocking", because it blocks ads as well.

After a quick search, it appears that the issue is related to the fact that the (adsbygoogle = window.adsbygoogle || []).push({}); line is called when the rest of the code has still to be rendered on screen.

(Note: for anyone wondering, what that line is doing is creating a local variabile called adsbygoogle and assigning it the value of the global window.adsbygoogle, or an empty array if it doesn't exist. Then an empty object is pushed on that array. This works because if the AdSense script is already loaded, the push function is actually some custom code that loads the next ad slot. If AdSense is still not loaded, the adsbygoogle array will be used to know how many slots to load, as soon as AdSense is ready)

Thank you.