The pksm-core from flagbrew

pksm-core's People

Contributors

Stargazers

Watchers

pksm-core's Issues

Backwards transfer: Language and Character Impossibilities

On backwards transfers, it currently looks like names composed of characters that are impossible to represent in that generation will be completely blank. This should be verified, and if it is the case, should be changed. Low priority, as it shouldn't break anything

PK6->PK7 Marking value not adjusted

In the formats for generations 3-6, markings are stored as single-bitflags as a u8.
In generation 7 and above, markings are stored as bit-pairs as a u16, with 0/1/2 being valid values (off, blue, pink).

When converting from PK6->PK7, the marking value must be adjusted instead of copied. By copying the bits directly, you can end up with invalid marking values (such as 3), which can cause misbehavior in future games.

Logic in question -- scroll to bottom line:

PKSM-Core/source/pkx/PK6.cpp

Lines 906 to 923 in 44c2127

 std::unique_ptr<PK7> PK6::convertToG7(Sav& save) const 

 { 

 auto pk7 = PKX::getPKM<Generation::SEVEN>(const_cast<u8*>(data)); 

 // markvalue field moved, clear old gen 6 data 

 pk7->rawData()[0x2A] = 0; 

 // Bank Data clearing 

 for (int i = 0x94; i < 0x9E; i++) 

 pk7->rawData()[i] = 0; // Geolocations 

 for (int i = 0xAA; i < 0xB0; i++) 

 pk7->rawData()[i] = 0; // Amie fullness/enjoyment 

 for (int i = 0xE4; i < 0xE8; i++) 

 pk7->rawData()[i] = 0; // unused 

 pk7->rawData()[0x72] &= 0xFC; // low 2 bits of super training 

 pk7->rawData()[0xDE] = 0; // gen 4 encounter type 

 pk7->markValue(markValue());

Potential fix would be exposing a bit field in the PKM structs, with gen3-6 being u8 MarkN:1 * 6, and gen7+ being u16 MarkN:2 * 6. Then you can just property copy as 1->1.

Recommend Projects

flagbrew / pksm-core Goto Github PK

pksm-core's People

Contributors

Stargazers

Watchers

Forkers

pksm-core's Issues

Backwards transfer: Language and Character Impossibilities

PK6->PK7 Marking value not adjusted

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	std::unique_ptr<PK7> PK6::convertToG7(Sav& save) const
	{
	auto pk7 = PKX::getPKM<Generation::SEVEN>(const_cast<u8*>(data));

	// markvalue field moved, clear old gen 6 data
	pk7->rawData()[0x2A] = 0;

	// Bank Data clearing
	for (int i = 0x94; i < 0x9E; i++)
	pk7->rawData()[i] = 0; // Geolocations
	for (int i = 0xAA; i < 0xB0; i++)
	pk7->rawData()[i] = 0; // Amie fullness/enjoyment
	for (int i = 0xE4; i < 0xE8; i++)
	pk7->rawData()[i] = 0; // unused
	pk7->rawData()[0x72] &= 0xFC; // low 2 bits of super training
	pk7->rawData()[0xDE] = 0; // gen 4 encounter type

	pk7->markValue(markValue());