flack / universalfeedcreator Goto Github PK

Hi,
I am forwarding this issue from a DokuWiki user who noticed this warning:

PHP Warning: htmlspecialchars() expects parameter 1 to be string, array given in .../vendor/openpsa/universalfeedcreator/lib/Creator/AtomCreator10.php on line 113

I don't have any further information yet.

Greetings,
Lars

In the latest release, a new file showed up:

.github/workflows/php.yml

Is it meant to be there?

Today I upgraded from 1.8.3.1 -> 1.8.4

I wonder what I've done wrong in my install.

2021/01/24 21:50:01 [error] 47739#102365: *4712 FastCGI sent in stderr: "PHP message: PHP Warning: Use of undefined constant FEEDCREATOR_VERSION - assumed 'FEEDCREATOR_VERSION' (this will throw an Error in a future version of PHP) in /usr/local/share/UniversalFeedCreator/lib/Creator/FeedCreator.php on line 130PHP message: PHP Warning: Use of undefined constant FEEDCREATOR_VERSION - assumed 'FEEDCREATOR_VERSION' (this will throw an Error in a future version of PHP) in /usr/local/share/UniversalFeedCreator/lib/Creator/RSSCreator091.php on line 67" while reading response header from upstream, client: 137.74.173.20, server: www.freshports.org, request: "GET /backend/watch-list.php?id=[redacted]&format=rss0.91 HTTP/2.0", upstream: "fastcgi://unix:/var/run/php-fpm.sock:", host: "www.example.org"

Composer.json says the library is available under GNU LGPL 2.1 or later, however the licence text is not included in the repository.

FYI, there are issues with PHP 8.3 - I'll post some of the errors here and I'll have a patch later.

<b>Deprecated</b>:  Creation of dynamic property RSSCreator091::$_timeout is deprecated in <b>/usr/local/share/UniversalFeedCreator/lib/Creator/FeedCreator.php</b> on line <b>238</b><br />

<b>Deprecated</b>:  Creation of dynamic property PIECreator01::$truncSize is deprecated in <b>/usr/local/share/UniversalFeedCreator/lib/Creator/PIECreator01.php</b> on line <b>29</b><br />

I have not tracked down the issue yet, but lastBuildDate forrss0.91 & rss2.0 at https://www.freshports.org/backend/ is off by one hour.

e.g. Mon, 31 Jul 2017 02:33:29 +0000 when the time on the system is Mon Jul 31 01:33:29 UTC 2017

When I choose HTML as feed output, I get this deprecation error in php7.4:

'join(): Passing glue string after array is deprecated. Swap the parameters'

in: /var/www/html/vendor/openpsa/universalfeedcreator/lib/Creator/HTMLCreator.php
line 143:
$feed = "".join($feedArray, "\r\n");

(or another file for js type)

Unfortunately class FeedDate and thus RSS Feed pubDate fail at date strings with time zones.

For example,

var_dump(new FeedDate('1970-01-01 00:00:00+0200'));

... outputs a unixtime of 0, whereas -7200 would be correct.

A workaround of course is to pass unixtime integers instead of date strings.

Could we have a tag for the current state of master? I think 1.8.3 would be okay?