Git Product home page Git Product logo

Comments (4)

fjosw avatar fjosw commented on July 28, 2024

I agree with you, I am also in favor of changing this behavior. I would even say that it can be a bit dangerous to automatically call the gamma_method within say a fit routine as this will use the standard arguments for the gamma_method and overwrite any custom values for S or so which the user might have set before running the fit. This behavior could be confusing.

from pyerrors.

JanNeuendorf avatar JanNeuendorf commented on July 28, 2024

I agree as well. I only did it this way to avoid having to test for this in every single function.
If the performance cost is noticeable, it has to change.
One has to be a little careful here. Functions might rely on accurate dvalues and might not raise an error if it is zero.

from pyerrors.

fjosw avatar fjosw commented on July 28, 2024

Good point, hopefully our tests will catch these cases. I can take care of that today.

from pyerrors.

s-kuberski avatar s-kuberski commented on July 28, 2024

Very good, thanks! (And I fully agree with your concerns regarding silent calls of the gamma method)

from pyerrors.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.