Comments (4)
Hi,
I had looked at this in the past. Basically, in my opinion, it is a bug in the way the slicing is defined for the correlator and it could be corrected such that you would really get a list of observables instead of these weird arrays. Actually, it would make ones life a lot easier in some cases. However, I was hesitant to propose to change this because it could be a breaking change for analyses if someone was using [o[0] for o in corr[10:30]]
to circumvent the current issue. The workaround that would not be affected is [o for o in corr][10:30]
. Both are a bit ugly compared to the simple corr[10:30]
that one would like to work.
I don't know what you opinion on this would be.
from pyerrors.
I also remember discussing this with @s-kuberski some time ago. So far we have been very strict about not introducing breaking changes in minor releases. Should we consider making an exception here or, do we want to stick to our policy?
from pyerrors.
I am not sure. It is the question if you consider this fixing a bug or introducing a breaking change, but I think the semantic versioning would tell you not to break the behavior anyways, right? I am fine with not fixing this for now, although any workaround that would break when this is fixed might be introduced in more and more workflows the longer we keep it in here. I personally would also be able to adapt my codes to work with the new behavior.
from pyerrors.
Hi,
sorry to come back to you just now, I had some trouble with my github :)
Personally, I would also be able to adapt my analyses to this change, however, I understand that this would break other analyses. I think we could wait for a potential new mayor release to fix this, where we could also fix other breaking stuff, if we find more. Could that be a solution?
from pyerrors.
Related Issues (20)
- numerical differentiation in derived_obs not working HOT 5
- Automatic windowing method fails for gapped and irregular chains HOT 4
- Issues with _filter_zeroes and Corr HOT 4
- Exception when applying .symmetric() to Corr containing None HOT 1
- Gamma_method() is broken for Obs that are NaN
- Multi-dimensional fits
- Bug coming from difference in search methods in sfcf inputs HOT 2
- `Corr.show()` draws prange in same color as error bars. HOT 1
- No dobs-related functions from the input submodule can be used HOT 1
- GEVP eigenvectors with errors HOT 7
- Warning in pandas tests
- Numpy 1.25 breaks a few linalg functions HOT 3
- Failing python 3.12 pytest workflow
- Duplicate data cause `gamma_method()` to fail with an unhelpful message HOT 3
- plot_history unexpected behaviour for gapped idl HOT 2
- read_hd5 in pyerrors 2.9.0 not fully backwards compatible to <=2.8.2 HOT 1
- Read specific interval with read_ms5_xsf() HOT 2
- Files keyword for multiple reps in read_sfcf HOT 2
- pyerrors does not work with the upcoming numpy 2 release HOT 7
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pyerrors.