Git Product home page Git Product logo

Comments (4)

s-kuberski avatar s-kuberski commented on July 28, 2024

Hi,
I had looked at this in the past. Basically, in my opinion, it is a bug in the way the slicing is defined for the correlator and it could be corrected such that you would really get a list of observables instead of these weird arrays. Actually, it would make ones life a lot easier in some cases. However, I was hesitant to propose to change this because it could be a breaking change for analyses if someone was using [o[0] for o in corr[10:30]] to circumvent the current issue. The workaround that would not be affected is [o for o in corr][10:30]. Both are a bit ugly compared to the simple corr[10:30] that one would like to work.

I don't know what you opinion on this would be.

from pyerrors.

fjosw avatar fjosw commented on July 28, 2024

I also remember discussing this with @s-kuberski some time ago. So far we have been very strict about not introducing breaking changes in minor releases. Should we consider making an exception here or, do we want to stick to our policy?

from pyerrors.

s-kuberski avatar s-kuberski commented on July 28, 2024

I am not sure. It is the question if you consider this fixing a bug or introducing a breaking change, but I think the semantic versioning would tell you not to break the behavior anyways, right? I am fine with not fixing this for now, although any workaround that would break when this is fixed might be introduced in more and more workflows the longer we keep it in here. I personally would also be able to adapt my codes to work with the new behavior.

from pyerrors.

jkuhl-uni avatar jkuhl-uni commented on July 28, 2024

Hi,
sorry to come back to you just now, I had some trouble with my github :)
Personally, I would also be able to adapt my analyses to this change, however, I understand that this would break other analyses. I think we could wait for a potential new mayor release to fix this, where we could also fix other breaking stuff, if we find more. Could that be a solution?

from pyerrors.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.