fiznool / backbone.basicauth Goto Github PK

Thank you for this little extension. Just what I needed. I wonder though, is it possible to get this registered with Bower?

Currently only backbone 1.0.0 is supported in bower.json which makes it difficult for any project to upgrade to backbone 1.1 since bower would complain about dependency mismatch.

If Backbone.sync is overridden by the calling app, when Backbone.BasicAuth.clear() is called, the overridden sync is not restored - instead, the version that ships with Backbone is restored.

Reproduction:

Backbone.BasicAuth.set('user', 'pass');

var originalSync = Backbone.sync;
Backbone.sync = function(method, model, options) {
  // Some extra stuff
  return originalSync.call(model, method, model, options);
}

// Next line sets Backbone.sync back to the version in backbone.js,
// not the one set above
Backbone.BasicAuth.clear();

Realy needs a CommonJS Support...

Please add a license so that others may legally use this code.

https://choosealicense.com/

(For reference, 13 of the 15 libraries we use are under MIT license)

One of the contracts of Backbone is that methods that call sync internally return the value of sync, because it is supposed to return a promise. I've noticed that on line 35 you just call the sync function, instead of returning it, and the result is that code that relies on a promise being returned does not get it.

Suggested alteration:

35: return originalSync.call(model, method, model, options);

Useful code though.