Git Product home page Git Product logo

sport-activities-features's People

Contributors

alenrajsp avatar allcontributors[bot] avatar carlosal1015 avatar dependabot[bot] avatar firefly-cpp avatar garyjellyarms avatar hlistilen avatar kukovecrok avatar lahovniktadej avatar luckylukac avatar lukapecnik avatar rhododendrom avatar spelapecnik avatar zala-lahovnik avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar

sport-activities-features's Issues

Hill visualization creates overlapping hills

It would appear detected hills can overlap. After creation of visuals of hill climbs using the algorithm, I've noticed weird behavior when processing the data further - my bug seems to appear from hills being allowed to overlap, which I don't know if is the desired behavior. Here is the issue visualized in google earth -
image
There are actually 4 dots in the picture
image
Here are the two hills on top of each other
image
This is an outtake of my exported and processed XML file
image
The problem isn't export related as I can see the values in my debugger. I'm attaching the problematic file bellow

02_25_2019_10_51_26_trackMap.zip

issue with parsing test data

an issue while trying to perform the Hills.identify_hills(), pictures of the stack call back and some of the test files that caused the issue
errors
wrong_files

Failed to validate build-system in pyproject.toml: Unknown properties: exclude

Hi, when I tried to compile from source 0.3.15 I got the following message

==> Retrieving sources...
  -> Downloading sport-activities-features-0.3.15.tar.gz...
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100 4468k    0 4468k    0     0  5834k      0 --:--:-- --:--:-- --:--:--  9.9M
==> Validating source files with sha512sums...
    sport-activities-features-0.3.15.tar.gz ... Passed
==> Extracting sources...
  -> Extracting sport-activities-features-0.3.15.tar.gz with bsdtar
==> Starting build()...
ERROR Failed to validate `build-system` in pyproject.toml: Unknown properties: exclude
==> ERROR: A failure occurred in build().
    Aborting...

Similar issue https://github.com/orgs/python-poetry/discussions/8111

Add tests

Add tests for GPXFile, InterruptionProcessor, OverpyNodesReader, WeatherIdentification.

Segments

Description: Implement "segments" functionality - similar to what we can see in Strava.

Input: segment which is represented as a path (collection of GPS points); a collection of sports activities

Output: Table of results

Add 0.3.13 to pypi

Please upload the newer version (0.3.13) to pypi, so that it can be used in sport-activities-features-gui (pyproject toml has 0.3.13 specified).

image

Tests

@alenrajsp, your tests are failing. Please check it out!

FAILED sport_activities_features/tests/test_overpy_node_manipulation.py::TestWeather::test_generated_object_altitudes - json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0)

FAILED sport_activities_features/tests/test_overpy_node_manipulation.py::TestWeather::test_generated_object_properties - json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0)

Tcxreader issue

activity = tcx_file.read_one_file('dead_end.tcx')
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

File "/usr/lib/python3.11/site-packages/sport_activities_features/tcx_manipulation.py", line 57, in read_one_file
tcx = TCXReader().read(filename)
^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3.11/site-packages/tcxreader/tcxreader.py", line 48, in read
self.trackpoint_parser(tcx_point, trackpoint)
File "/usr/lib/python3.11/site-packages/tcxreader/tcxreader.py", line 116, in trackpoint_parser
tcx_point.time = datetime.datetime.strptime(
^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib64/python3.11/_strptime.py", line 568, in _strptime_datetime
tt, fraction, gmtoff_fraction = _strptime(data_string, format)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib64/python3.11/_strptime.py", line 349, in _strptime
raise ValueError("time data %r does not match format %r" %
ValueError: time data '2021-09-29T15:17:30Z' does not match format '%Y-%m-%dT%H:%M:%S.%fZ'

One test is failing

Hi @luckyLukac,

ERROR collecting sport_activities_features/tests/test_area_identification.py _
ImportError while importing test module '/builddir/build/BUILD/sport-activities-features-0.2.6/sport_activities_features/tests/test_area_identification.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
/usr/lib64/python3.10/importlib/init.py:126: in import_module
return _bootstrap._gcd_import(name[level:], package, level)
sport_activities_features/tests/test_area_identification.py:4: in
from sport_activities_features.area_identification import AreaIdentification
sport_activities_features/area_identification.py:1: in
import geotiler
E ModuleNotFoundError: No module named 'geotiler'

seaborn-* styles are deprecated

The seaborn-whitegrid style used in this package was renamed and deprecated in Matplotlib 3.6 The upcoming Matplotlib 3.8 release has removed the deprecated names and will cause this package to fail to import, e.g.,

______________ ERROR collecting tests/test_area_identification.py ______________
/usr/lib64/python3.12/site-packages/matplotlib/style/core.py:137: in use
    style = _rc_params_in_file(style)
/usr/lib64/python3.12/site-packages/matplotlib/__init__.py:869: in _rc_params_in_file
    with _open_file_or_url(fname) as fd:
/usr/lib64/python3.12/contextlib.py:137: in __enter__
    return next(self.gen)
/usr/lib64/python3.12/site-packages/matplotlib/__init__.py:846: in _open_file_or_url
    with open(fname, encoding='utf-8') as f:
E   FileNotFoundError: [Errno 2] No such file or directory: 'seaborn-whitegrid'

The above exception was the direct cause of the following exception:
tests/test_area_identification.py:6: in <module>
    from sport_activities_features.area_identification import AreaIdentification
sport_activities_features/__init__.py:18: in <module>
    from sport_activities_features.plot_data import PlotData
sport_activities_features/plot_data.py:3: in <module>
    plt.style.use('seaborn-whitegrid')
/usr/lib64/python3.12/site-packages/matplotlib/style/core.py:139: in use
    raise OSError(
E   OSError: 'seaborn-whitegrid' is not a valid package style, path of style file, URL of style file, or library style name (library styles are listed in `style.available`)

Invalid configuration

COMMAND: poetry build

RuntimeError

The Poetry configuration is invalid:
- Additional properties are not allowed ('group' was unexpected)

at /usr/lib/python3.11/site-packages/poetry/core/factory.py:43 in create_poetry
39│ message = ""
40│ for error in check_result["errors"]:
41│ message += " - {}\n".format(error)
42│
→ 43│ raise RuntimeError("The Poetry configuration is invalid:\n" + message)
44│
45│ # Load package
46│ name = local_config["name"]
47│ version = local_config["version"]

Read one GPX file produces division by zero

When I mass imported a mass collection, exported from strava, a large ammount of them failed. It would appear, when parsing the file a point is somehow read twice but differently - picture provided bellow.

image

image

These different points are actually one the the XML

image

Poetry Issue

There is an issue with poetry.lock and/or pyproject.toml (the file cannot be read nor updated). A more detailed description can be found in the attached screenshot.

Screenshot 2021-11-18 174445

Support FIT files

GPX and TCX file extensions are now supported by this software. However, support for FIT files is still missing. It is heavily used by Garmin as well as Zwift.

More info

Any volunteers for working on this task? @alenrajsp or @luckyLukac?

Fix building docs when using LaTeX

Latexmk: Run number 1 of rule 'pdflatex'
This is pdfTeX, Version 3.141592653-2.6-1.40.25 (TeX Live 2023) (preloaded format=pdflatex)
restricted \write18 enabled.
entering extended mode
Latexmk: ====Undefined refs and citations with line #s in .tex file:
! LaTeX Error: Unicode character 🚀 (U+1F680)
! LaTeX Error: Unicode character 💪 (U+1F4AA)
! LaTeX Error: Unicode character 🔍 (U+1F50D)
! LaTeX Error: Unicode character ⏱ (U+23F1)
! LaTeX Error: Unicode character (U+FE0F)
! LaTeX Error: Unicode character 🚴 (U+1F6B4)
! LaTeX Error: Unicode character ‍ (U+200D)
And 89 more --- see log file 'sport-activities-features.log'

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.