firebolt-db / firebolt-node-sdk Goto Github PK

In hydrateRow() you are using for (... in ...) to iterate an array (meta). But that does not iterate the array indices, and instead iterates the object keys of the whole prototype chain (and causes an exception in case there is something there).

Could you please change that to an for (... of ...) with meta.entries() instead?

Example updated function (not tested):

export const hydrateRow = (
  row: Row,
  meta: Meta[],
  executeQueryOptions: ExecuteQueryOptions
) => {
  const isArray = Array.isArray(row);
  const hydratedRow = isArray ? [] : {};

  for (const [index, column] of meta.entries()) {
    if (isArray) {
      (hydratedRow as unknown[])[index] = getHydratedValue(
        row[index],
        column.type,
        executeQueryOptions
      );
    } else {
      const key = column.name;
      (hydratedRow as Record<string, unknown>)[key] = getHydratedValue(
        row[key],
        column.type,
        executeQueryOptions
      );
    }
  }
  return hydratedRow;
};

Noticed that escapes are not handled properly when comments are being removed.

For example running

select 'my string\' here'

gives you my string' here as expected.

But running this query breaks:

select 'my string\' -- here'

Result:

Reason: Invalid input error: SQL query not valid.
SQL query:
==========
select 'my string\' 
                   ^=== ERROR HERE!
==========
Error line: 0
Error column: 19
Error message: syntax error, unexpected UNTERMINATED_STRING, expecting end of file

Response status: 500

Also that how strings are parsed by the server can be controlled by a setting standard_conforming_strings doesn't make this easier. But at least the default setting (that allows escapes like in the example above) should work.

Referring to the line here, which converts array parameters to "[" instead of "(" as required for queries which include "in" clause.

I can supply example queries if required, but I believe this is pretty straightforward.

Thanks.