In Japan, there are many Yahoo! JAPAN users.
So I request to add Yahoo! JAPAN Login.
I would greatly appreicate if you can give my proposal a good review.

please share a code for this. thanks

Looks like in app.js line 142, we are passing the argument firebaseToken to the createFirebaseAccount function. This variable hasn't been created.

createFirebaseAccount(results.user.id, results.user.full_name,
        results.user.profile_picture, firebaseToken).then(firebaseToken => {
      // Send the custom token, access token and profile data as a JSON object.
      res.send(firebaseToken);

Think this should be a variable containing the access_token returned from the token endpoint for instagram.

Likely missing a

const accessToken = results.access_token;

createFirebaseAccount(results.user.id, results.user.full_name,
        results.user.profile_picture, accessToken).then(firebaseToken => {
      // Send the custom token, access token and profile data as a JSON object.
      res.send(firebaseToken);

Are there any standard implementations for revoking the Firebase token if the user no longer has access in the 3rd party authentication provider which was used to create the custom token?

We use an internal OAuth provider for authentication and would like to use Firebase along with it. However, I can't find any documentation on standard practice for revoking the Firebase token if the OAuth provider revokes access to the user. It looks like the client can indefinitely keep refreshing the Firebase token once they authenticate with the 3rd party provider just once.

please share a code for this. thanks

This doesn't seem correct. The condition !userId won't be satisfied no matter what body.id is.

For officially supported OAuth providers such as Google, Facebook, Twitter, and Github, it is possible to link them to an existing Firebase user using FirebaseUser.linkWithCredential() method. However, it does not seem easy for custom OAuth providers to be linked with existing Firebase user since only signInWithCustomToken() method is supported for custom OAuth providers, not linkWithCredential(). Under this circumstance, I have two questions.

1. Is there a way for unofficial providers to link accounts by creating credentials using OAuthProvider.getCredential() method? Currently when I try to create an AuthCredential object, I get this exception in Android.

com.google.firebase.FirebaseException: An internal error has occurred. [ INVALID_PROVIDER_ID:Provider Id is not supported. ]

2. If 1) is not possible, what would be the suggested way of linking custom OAuth provider with the given Firebase user, say a user with facebook and google already linked?

For example, I would want a user to link all google, facebook, and instagram accounts since the service I am working on wants to post a given picture to all platforms. If this is not possible, developers would be reluctant to solely depend on Firebase authentication platform for managing users. I would appreciate any help or guide :)

It would be great if we can have a example build for an Android app so that the best practices are followed in implementing other OAuth providers.
Thanks.

rt

Hey, this is wonderful stuff and really helpful! But it's using a deprecated API, which makes it less helpful. 😢

Any chance this can be updated to LINE OAuth v2?

Thanks a lot!!!!!

We should switch the server side samples to use the new firebase-admin module and do the account creation and profile update on the server side.

Hello,
while i was reading this article "Authenticate your Firebase users with LINE Login"
There is additionalClaims in server.js, but i didn't see where we put this code?
Thanks