fir3element / 3777 Goto Github PK

Pretty rare, but can happen, especially if someone decide to attack you with 'check status DDoS'.
status->getStatusString is executed in 'network thread':
https://github.com/Fir3element/3777/blob/main/src/status.cpp#L65
but it reads Player::autoList which can be modified in 'dispatcher thread':
https://github.com/Fir3element/3777/blob/main/src/status.cpp#L147

In TFS 1.x function that reads players list:
https://github.com/otland/forgottenserver/blob/master/src/protocolstatus.cpp#L193
is executed in 'dispatcher thread':
https://github.com/otland/forgottenserver/blob/master/src/protocolstatus.cpp#L65-L68

There is some issue with createitem.lua that made my server crash and shutdown. I'm not really sure what's the matter, but by disabling each parts of the script I came to a conclusion that it is one of those:
doCreateItemEx(id, amount)
doPlayerAddItemEx(cid, item, true)

This made the server crash if you typed /i itemName two times.
I was doing it with my custom item, but same happened with other items. I guess those functions are bugged, because doPlayerAddItem(cid, id, amount, false) is working.

This github is pretty dead, but hopefully someone still reads that. At the moment, this issue is not bothering me, since as I said, there is a way around, but I guess I will be looking into that in the future and potentially come back here with the solution.

I have Windows 10, visual studio 2022 (professional), with C++ installed and along with it IntelliCode, but when I launch
theforgottenserver.vcxproj I have an error:

Is there any solution? I was googling it, but nothing worked.