fingerpich / jalali-moment Goto Github PK

Please develop jWeek parameter in startOf() and endOf()
Thanks

loadPersian is a static method which makes all new moment instances to format as a Persian date time but we may need use it just for an instance.
of course bellow code is also available for our purpose

moment.loadPersian();
moment().format('jYYYY');
moment.unloadPersian();

When its possible to use persian digits in formatted output, we should make it available to parse persian digits and make instance of moment from it.

Describe the bug
After bundling my package into dist file. when I used npm link to test package I got an error: TypeError: Cannot read property 'calSystem' of undefined. this decelered in jalali-moment module.

Detailed description

I faced this error when i use .fromNow() method;
start date: "2018-10-25T13:20:00+00:00"
should return: 1 ساعت پیش (for my test time)
result: در 621 سال
it seems the library calculated subtract of 2018 and 1397!

Steps to reproduce

let fromNow = moment("2018-10-25T13:20:00+00:00").locale('fa').fromNow()
// or without locale()
console.log(fromNow)

Please put new release of library in release section. I tested release v2.0.1 but it doesn't work. finally I copy your library from https://unpkg.com/[email protected]/dist/jalali-moment.browser.js and okay it.

const m = moment('1367/11/4', 'jYYYY/jM/jD')
m.jMonth(); ==> 10

I am using jalali-angular-datepicker in reactive, When i parse todays date in (YYYY-MM-DD) format, the date shown is like this (0775-09-21). I think it parses the date twice, how to avoid it.

locales are there to use for another languages but it is not useful for this library

The following code shows the problem

const m = jmoment('hello', 'jMM/jDD/jYYYY', 'fa');
const isMom = jmoment.isMoment(m); // true
const cloned = m.clone().locale('fa');
const v1 = m.isValid(); // false​ it s ok​
const v2 = cloned.isValid(); // true?? why is that​

Hi Mojtaba, Thank you for the service.
Is there any validation option for jalali dates in this lib? As you know, in momentjs a isValid function doing the similar work. So, can you point out how we can validate jalali dates using jalali-moment ?
According to your knowledge, What do you do if you want check and validate month, day and year in jalali calendar?

First of all thanks for you nice work.
When I use in my node project which already dependent to [email protected] I've got this message:
//*** code
const shamsi =jmoment('2014/01/24').locale('fa').format('YYYY/MM/DD');

//*** what it shows in console:
Deprecation warning: value provided is not in a recognized RFC2822 or ISO format. moment construction falls back to js Date(), which is not reliable across all browsers and versions. Non RFC2822/ISO date formats are discouraged and will be removed in an upcoming major release. Please refer to http://momentjs.com/guides/#/warnings/js-date/ for more info.
Arguments:
[0] _isAMomentObject: true, _isUTC: false, _useUTC: false, _l: undefined, _i: 1989/01/24, _f: undefined, _strict: undefined, _locale: [object Object]
Error ...........

Thanks again.
Mohammad

Hello, I need to load the Moment interface to my .ts file.
I can see that the moment() output's interface is moment.Moment, but I cannot import Moment interface to my code.

For example, express provides its interfaces as parameters throw the express value like below:

var res:express.Response ;

And I didn't find such a solution on yours.

Hi there
Tanks for amazing library
Is there any way to check date is valid or not?

I want to convert birthday input to unix timestamp. The problem is that it converts to invalid Unix timestamp when I enter birthYear for example '1331'.

Here's my code:

const birthDateInput =`${birthObj.birthYear}/${birthObj.birthMonth}/${birthObj.birthDay}`;
const birthdate = Moment(birthDateInput, 'jYYYY/jM/jD').format('X');

The result for '1331/2/13' is:
-557465400

Hi,
On this method:

    fromIso8601(iso8601String: string): jmoment.Moment | null {
        const d = jmoment(iso8601String, jmoment.ISO_8601).locale('fa');
        return this.isValid(d) ? d : null;
    }

I get config._f.match is not a function !!!
And these are the tests:

    it('should create dates from valid ISO strings', () => {
        expect(adapter.fromIso8601('1985-04-12T23:20:50.52Z')).not.toBeNull();
        expect(adapter.fromIso8601('1996-12-19T16:39:57-08:00')).not.toBeNull();
        expect(adapter.fromIso8601('1937-01-01T12:00:27.87+00:20')).not.toBeNull();
        expect(adapter.fromIso8601('1990-13-31T23:59:00Z')).toBeNull();
        expect(adapter.fromIso8601('1/1/2017')).toBeNull();
      });

Thanks a lot.

I use jalali-moment-browse.js with bootstrap-material-calendar. It works fine, except shortday names rensers as an I. May you please help me?

Hi mate,
My angular projects works fine locally either by ng serve or ng build --prod.
But on stackblitz it says ERROR TypeError: jmoment is not a function.
Would you please look at that?

Thanks in advance as always.

examples shows this library abilities and help users to start it faster.

Does this method works correctly on version 2.1.2?
m.add(1, "jDay");
or
m.add(1 "jD");
inside unitOfTime type base:
jDay and jD
are defined, but they do not work for me.

when i use code completion to import jalali moment it imports it in a wrong way.

it should import as it mentioned in README like bellow.
import * as moment from 'jalali-moment';

travis has problem on uglify plugin

Thank you for your wonderful effort.
Jalali functions such as m.jYear() can not be recognized in vscode, "jalali-moment": "^2.0.4", "@angular / cli": "^1.3.0", "typescript": "~2.3.3".
However your plunkr at https://embed.plnkr.co/Gggh1u/ works fine, even after updating jalali-moment to 2.0.4, and also it does not need moment itself, but I had to npm install "moment" in my angular/cli project.

But in the component after,
import * as pmoment from 'jalali-moment'; and
this.jalaliYear = ( < any > pmoment( ) ).jYear( );
it works as expected.

hello
import * as moment_ from 'jalali-moment';
in create library raised error :
src/app/components/persian-date-time/persian-date-time.component.ts(67,15): error TS2503: Cannot find namespace 'moment'.

Hi,
This is not an issue.
I have a question:
What is the use cases of

extend(getPrototypeOf(moment.localeData()),
    { _jMonths: [ "Farvardin"
        , "Ordibehesht"
        , "Khordaad"
        , "Tir"

Because of an issue in angular material 2 datepicker, if your library could set months name in the above code just to Persian names as moment's locale data, it may help on mentioned issue.
Thanks again.

I use this module to localizing mat-datepicker and in some cases it call functions without argument ( e.g. year() return Gregorian year ).

I want to know why year, month and ... functions return Gregorian instead of jalali when they call without argument.

Thank you for your effort

demo page to show this library abilities

hi there

first off thank you for creating this kind of amazing pkg and sharing it with us

i used to use this pkg for along time ago and by then there was no problems with moment stuff in it
but recently i just facing with this error in my terminal yelling mew about deprecation warnings like below( pm2 log in my terminal ):

0|myTmpProject  | 2019-01-08 10:21: Deprecation warning: use moment.updateLocale(localeName, config) to change an existing locale. moment.defineLocale(localeName, config) should only be used for creating a new locale See http://momentjs.com/guides/#/warnings/define-locale/ for more info.

here is the code that is use in my react project:

let _date = dateCreated.split('T')[0]
_date = moment(_date, 'YYYY-MM-DD').locale('fa').format('YYYY/MM/DD')

basically I'm just getting a time stamp from mongo which looks like this:2019-01-05T14:14:10.305Z

i also tried this out:

    __date = _date.split('-')
    _date = moment.updateLocale( 'fa', {
      longDateFormat: {
        L:'YYYY/MM/DD'
      },
      relativeTime: {
        d: __date[2],
        m: __date[1],
        y: __date[0]
      }
    })

but no result i got yet...

it works but i'm worries about future as it warns me about deprecation stuff that goes on in moment js team.

any kinda response would be appreciated.

thanks alot

Hi.
I add to my project jalali-moment and add reference of this file into .ts file such as
reference path="../scripts/typings/jquery/jquery.d.ts"
reference path="../scripts/typings/jqueryui/jqueryui.d.ts"
reference path="../scripts/typings/jalali-moment/jalali-moment.ts"
but get error for me that Cannot find name 'moment'.
my tsconfig.json file :
{
"compileOnSave": true,
"compilerOptions": {
"noImplicitAny": false,
"noEmitOnError": true,
"removeComments": false,
"sourceMap": true,
"target": "es5",
"outDir": "../appScriptsJS",
"charset": "utf8"
},
"exclude": [
"node_modules",
"wwwroot"
]
}
typescript :
moment(dateMiladi).locale('fa').format('YYYY/MM/DD');
What is problem?

Once i use this package in an angular project and run build command it show error as follow:

BUILD ERROR
Cannot call a namespace ('moment')
Error: Cannot call a namespace ('moment')
at error (D:\angular-pro\libraries\node_modules\rollup\dist\rollup.js:199:15)
at Module.error (D:\angular-pro\libraries\node_modules\rollup\dist\rollup.js:17170:9)
at CallExpression.bind (D:\angular-pro\libraries\node_modules\rollup\dist\rollup.js:14725:30)
at MemberExpression$$1.NodeBase.bind (D:\angular-pro\libraries\node_modules\rollup\dist\rollup.js:13499:23)
at MemberExpression$$1.bind (D:\angular-pro\libraries\node_modules\rollup\dist\rollup.js:15672:35)
at CallExpression.NodeBase.bind (D:\angular-pro\libraries\node_modules\rollup\dist\rollup.js:13499:23)
at CallExpression.bind (D:\angular-pro\libraries\node_modules\rollup\dist\rollup.js:14721:31)
at AssignmentExpression.NodeBase.bind (D:\angular-pro\libraries\node_modules\rollup\dist\rollup.js:13499:23)
at AssignmentExpression.bind (D:\angular-pro\libraries\node_modules\rollup\dist\rollup.js:14605:31)
at ExpressionStatement$$1.NodeBase.bind (D:\angular-pro\libraries\node_modules\rollup\dist\rollup.js:13499:23)

Cannot call a namespace ('moment')
Error: Cannot call a namespace ('moment')
at error (D:\angular-pro\libraries\node_modules\rollup\dist\rollup.js:199:15)
at Module.error (D:\angular-pro\libraries\node_modules\rollup\dist\rollup.js:17170:9)
at CallExpression.bind (D:\angular-pro\libraries\node_modules\rollup\dist\rollup.js:14725:30)
at MemberExpression$$1.NodeBase.bind (D:\angular-pro\libraries\node_modules\rollup\dist\rollup.js:13499:23)
at MemberExpression$$1.bind (D:\angular-pro\libraries\node_modules\rollup\dist\rollup.js:15672:35)
at CallExpression.NodeBase.bind (D:\angular-pro\libraries\node_modules\rollup\dist\rollup.js:13499:23)
at CallExpression.bind (D:\angular-pro\libraries\node_modules\rollup\dist\rollup.js:14721:31)
at AssignmentExpression.NodeBase.bind (D:\angular-pro\libraries\node_modules\rollup\dist\rollup.js:13499:23)
at AssignmentExpression.bind (D:\angular-pro\libraries\node_modules\rollup\dist\rollup.js:14605:31)
at ExpressionStatement$$1.NodeBase.bind (D:\angular-pro\libraries\node_modules\rollup\dist\rollup.js:13499:23)

Date adapter want to use jalali moment in angular material date picker.
1.I run an angular project with : ng new my-app
2.Then import jalali moment package
3.Create an adapter for date.

Guide for using this adapter can found in : jalali-date-picker

Where is the problem?

when we want to use some other library that is used moment.js we have to change all function name and formats to jYear or 'jYYYY-jMM-jDD'
but i think we could have a flag to indicate it should treated as a jalali date or gregorian date.

we have something bad here ,
Friday has been translated to " آدینه " and it is not normal , please set an ability to change this words ( like a translate sheet )

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

• OS: [e.g. iOS]
• Browser [e.g. chrome, safari]
• Version [e.g. 22]

Smartphone (please complete the following information):

• Device: [e.g. iPhone6]
• OS: [e.g. iOS8.1]
• Browser [e.g. stock browser, safari]
• Version [e.g. 22]

Additional context
Add any other context about the problem here.

i recommend webpack and gulp to do it.

Describe the bug
Hi,
khaste nabashi :)
I faced an issue when I run my tests. the error is: TypeError: jalali_moment_1.default is not a function.
this error solved when I use jalali-moment in typescript usage as you said in docs. but in this situation, I got another error in rollup that said can't call moment namespace :( in simple usage I haven't any error and issue except this error in the test env.
you can see my project here.

Desktop (please complete the following information):

• OS: macos 10.14.2
• Browser chrome

moment().lang() is deprecated. Instead, use moment().localeData() to get the language configuration. Use moment().locale()
This is the warning that i get in console.

  at F.lang
  at F.push../node_modules/jalali-moment/jalali-moment.js.jMoment.fn.jMonth 
  at F.push../node_modules/jalali-moment/jalali-moment.js.jMoment.fn.add 

Add a CLI tool to easily use these capabilities. Most useful for me personally are the two commands GregorianToJalali and JalaliToGregorian.