Git Product home page Git Product logo

Comments (6)

apaleslimghost avatar apaleslimghost commented on August 31, 2024

Looks like the package was registered in Bower as dom-delegate. I've no idea how bower install ftdomdelegate was finding it. I've registered ftdomdelegate, and I'll update the name in bower.json.

from ftdomdelegate.

apaleslimghost avatar apaleslimghost commented on August 31, 2024

Findings:

  1. Older versions of Bower (circa 1.3) put bower install ftdomdelegate in bower_components/ftdomdelegate. Recent versions put it in bower_components/dom-delegate (the name from bower.json.
  2. I have no idea how Bower's resolving ftdomdelegate; it's not registered in that name.
  3. Packages shouldn't be doing bower install --save ftdomdelegate, because the package shouldn't exist under that name.

2 seems like a Bower issue. 3 is something we should fix in o-share etc.

from ftdomdelegate.

wheresrhys avatar wheresrhys commented on August 31, 2024

2 - ftdomdelegate is in the origami regsitry
3 - we decided that within ft ftdomdelegate should be the canonical name
(see the issue linked to above). Unfortunately we need to support
dom-delegate too as that's the name it was publicly published as first

On 5 January 2016 at 12:04, Matt Brennan [email protected] wrote:

Findings:

  1. Older versions of Bower (circa 1.3) put bower install ftdomdelegate
    in bower_components/ftdomdelegate. Recent versions put it in
    bower_components/dom-delegate (the name from bower.json.
  2. I have no idea how Bower's resolving ftdomdelegate; it's not
    registered in that name.
  3. Packages shouldn't be doing bower install --save ftdomdelegate,
    because the package shouldn't exist under that name.

2 seems like a Bower issue. 3 is something we should fix in o-share etc.


Reply to this email directly or view it on GitHub
#77 (comment)
.


This email was sent by a company owned by Financial Times Group Limited
("FT Group http://aboutus.ft.com/corporate-information/#axzz3rajCSIAt"),
registered office at Number One Southwark Bridge, London SE1 9HL.
Registered in England and Wales with company number 879531. This e-mail may
contain confidential information. If you are not the intended recipient,
please notify the sender immediately, delete all copies and do not
distribute it further. It could also contain personal views which are not
necessarily those of the FT Group. We may monitor outgoing or
incoming emails as permitted by law.

from ftdomdelegate.

apaleslimghost avatar apaleslimghost commented on August 31, 2024

Aha, gotcha. So at a guess it's not the repo name but the fact that the name in o-share's dependencies is different to the name in bower.json. I'm putting together a test case to verify.

from ftdomdelegate.

apaleslimghost avatar apaleslimghost commented on August 31, 2024

Test case: https://github.com/quarterto/quartertobowertest-dep. It's definitely the difference between the dependencies key and the bower.json name. It's worth noting that bower install --save ftdomdelegate would add it to dependencies as an alias to dom-delegate:

"dependencies": {
  "dom-delegate": "ftdomdelegate#^2.0.0"
}

I'll report to Bower.

from ftdomdelegate.

notlee avatar notlee commented on August 31, 2024

v3 renames to ftdomdelegate

from ftdomdelegate.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.