Behavior is non-standard when handler returns false about ftdomdelegate HOT 4 OPEN

Just because two popular ajax libraries do something doesn't make it a standard…

I honestly don't remember why we do both stopPropagation & stopImmediatePropagation but I do know that this would be a breaking API change and we'd need to do a major version bump & massive retesting of our websites. Is there any other reason than to match older libraries that this should be changed?

from ftdomdelegate.

@matthew-andrews, the behavior is both unexpected and undocumented, hence the issue report. My suggestion is to match the behavior users familiar with other libraries will expect, but it's fine if the library behaves differently -- at least document it.

It should be noted that stopImmediatePropagation() itself is never actually called; it's breaking out of both the listener loop and the propagation loop by returning that achieves this effect by not calling the rest of the listeners as well as preventing simulated propagation. The comment above it says Stop propagation to subsequent callbacks, which, to me sounds like a mix up the notion of DOM propagation with preventing other listeners from being called, so I wondered if the original behavior may have been coded in error.

from ftdomdelegate.

I wondered if the original behavior may have been coded in error.

Quite possibly. I'm not against this change as long as it actually fixes something but I've never come across a problem related to this – I just disagreed with the idea that we were non-standard.

from ftdomdelegate.

Alright I think you're right. We ought to fix this… Thanks for taking the time to report the bug so thoroughly. It'll need to be a major version bump though as there's a danger it'll create bugs.

Pinging @wheresrhys @georgecrawford @rowanbeentje

from ftdomdelegate.