Git Product home page Git Product logo

cura-arcwelderplugin's People

Contributors

5axes avatar fieldofview avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar

cura-arcwelderplugin's Issues

Plugin not available on Cura 4.8, because utf8 problem comes up

Hallo together,

if you install the plugin and after restart of cura 4.8, following problem in the cura log appears and the plugin not available on the experimental options.

2021-02-06 10:59:14,677 - ERROR - [MainThread] UM.Logger.logException [106]: Exception: Error loading plugin ArcWelderPlugin:
2021-02-06 10:59:14,689 - ERROR - [MainThread] UM.Logger.logException [110]: Traceback (most recent call last):
2021-02-06 10:59:14,694 - ERROR - [MainThread] UM.Logger.logException [110]: File "X:\4.8-exe\build\inst\lib\python3.5\site-packages\UM\PluginRegistry.py", line 480, in loadPlugin
2021-02-06 10:59:14,698 - ERROR - [MainThread] UM.Logger.logException [110]: File "C:\Users\Unlimitopen\AppData\Roaming\cura\4.8\plugins\ArcWelderPlugin\ArcWelderPlugin\__init__.py", line 11, in register
2021-02-06 10:59:14,702 - ERROR - [MainThread] UM.Logger.logException [110]: return {"extension": ArcWelderPlugin.ArcWelderPlugin()}
2021-02-06 10:59:14,705 - ERROR - [MainThread] UM.Logger.logException [110]: File "C:\Users\Unlimitopen\AppData\Roaming\cura\4.8\plugins\ArcWelderPlugin\ArcWelderPlugin\ArcWelderPlugin.py", line 51, in __init__
2021-02-06 10:59:14,708 - ERROR - [MainThread] UM.Logger.logException [110]: version_output = subprocess.check_output([self._arcwelder_path, "--version"]).decode()
2021-02-06 10:59:14,712 - ERROR - [MainThread] UM.Logger.logException [110]: UnicodeDecodeError: 'utf-8' codec can't decode byte 0xf6 in position 22: invalid start byte

I have in the original log the username of the file path a "german umlaut", is that the problem, why the plugin not appears in the "experimental" options in cura?

Thanks a lot for reading and correct the problem.

Failed save to disk/removable drive on Linux (Mint 19)

When testing the recent new submission on Linux Mint 19, on saving a sliced gcode file that had arc welding enabled, it shows an error message, and also has an error in the logs. Here's my full log: cura.log

The relevant bit is this:

2021-07-14 08:34:20,556 - DEBUG - [MainThread] RemovableDriveOutputDevice.RemovableDriveOutputDevice.requestWrite [85]: Writing to /media/remco/VERBATIM/UMS3_Door_Stop_2.ufp
2021-07-14 08:34:20,568 - DEBUG - [MainThread] ArcWelderPlugin.ArcWelderPlugin._filterGcode [241]: Using temporary file /tmp/tmpu_ro_mc4
2021-07-14 08:34:20,571 - DEBUG - [MainThread] ArcWelderPlugin.ArcWelderPlugin._filterGcode [266]: Running ArcWelder with the following options: ['/home/remco/.local/share/cura/4.10/plugins/ArcWelderPlugin/ArcWelderPlugin/bin/linux/ArcWelder', '-m=1000000.000000', '-t=0.050000', '-r=0.050000', '-s=1.000000', '-a=12', '-g', '/tmp/tmpu_ro_mc4']
2021-07-14 08:34:20,575 - ERROR - [MainThread] UM.Logger.logException [112]: Exception: Unable to write to file UMS3_Door_Stop_2: module 'subprocess' has no attribute 'STARTUPINFO'
2021-07-14 08:34:20,577 - ERROR - [MainThread] UM.Logger.logException [116]: Traceback (most recent call last):
2021-07-14 08:34:20,579 - ERROR - [MainThread] UM.Logger.logException [116]:   File "/home/ultimaker/src/output/build/inst/lib/python3.8/site-packages/UM/Qt/Bindings/OutputDeviceManagerProxy.py", line 150, in _writeToDevice
2021-07-14 08:34:20,582 - ERROR - [MainThread] UM.Logger.logException [116]:   File "/tmp/.mount_UltimaKlG5xS/usr/bin/plugins/plugins/RemovableDriveOutputDevice/RemovableDriveOutputDevice.py", line 99, in requestWrite
2021-07-14 08:34:20,584 - ERROR - [MainThread] UM.Logger.logException [116]:     self.writeStarted.emit(self)
2021-07-14 08:34:20,586 - ERROR - [MainThread] UM.Logger.logException [116]:   File "/home/ultimaker/src/output/build/inst/lib/python3.8/site-packages/UM/Signal.py", line 219, in emit
2021-07-14 08:34:20,588 - ERROR - [MainThread] UM.Logger.logException [116]:   File "/home/ultimaker/src/output/build/inst/lib/python3.8/site-packages/UM/Signal.py", line 336, in __performEmit
2021-07-14 08:34:20,590 - ERROR - [MainThread] UM.Logger.logException [116]:   File "/home/ultimaker/src/output/build/inst/lib/python3.8/site-packages/UM/Signal.py", line 219, in emit
2021-07-14 08:34:20,592 - ERROR - [MainThread] UM.Logger.logException [116]:   File "/home/ultimaker/src/output/build/inst/lib/python3.8/site-packages/UM/Signal.py", line 332, in __performEmit
2021-07-14 08:34:20,594 - ERROR - [MainThread] UM.Logger.logException [116]:   File "/home/remco/.local/share/cura/4.10/plugins/ArcWelderPlugin/ArcWelderPlugin/ArcWelderPlugin.py", line 272, in _filterGcode
2021-07-14 08:34:20,596 - ERROR - [MainThread] UM.Logger.logException [116]:     startupinfo = subprocess.STARTUPINFO()
2021-07-14 08:34:20,598 - ERROR - [MainThread] UM.Logger.logException [116]: AttributeError: module 'subprocess' has no attribute 'STARTUPINFO'

Installed on version 5.1 of Cura on MacOS 12.5.1 but nothing happens to gcode

I'm not clear on the necessary steps to invoke ArcWelder during a slice operation. I installed the ArcWelder plugin from Cura. ArcWelder's options appear in the preferences. It is not clear from your documentation whether you need to install the ArcWelder library in addition to the plugin. Any also it is not clear how to get ArcWelder to run on gcode from within Cura.

Thank you for your work and help.

2022-09-04 17:48:36,601 - DEBUG - [MainThread] ArcWelderPlugin.ArcWelderPlugin.__init__ [77]: Using ArcWelder 1.2.0
2022-09-04 17:48:36,601 - INFO - [MainThread] UM.PluginRegistry.loadPlugin [493]: Loaded plugin ArcWelderPlugin 3.6.0

"Out of Order" for Arcs, multiple artifacts and unnecissary moves

Cura 5.2.1
ArcWelder 3.6
Ender 3 v1 8bit

First tests with ArcWelder and noticed that it creates a rather disordered printing pattern on circles. In short on a flat round sufrace printed with concentric top and bottom pattern the arc seem placed at random. Ideal situation would be consecutive arcs working inward or outward, in this case it appears to randomly place the arcs resulting in the printer jumping from an arc near the middle, to an arc near the edge, to the very center, then back to the middle, then outside, then center, etc.

Image of the cura playback approximately half way through the first layer.

image
Full first layer
image

This obviously results in a very ugly layer (2nd or 3rd layer partially complete in this picture)
image

Arc Test.zip

Question: What's Needed for the Next SDK Major Version?

Question

What's Needed to Bump the SDK to the Next Major Version?

Why

My limited check shows it may just need a string added to the sdk array in plugin.json. This is to support the AW plugin working in Cura 5.0(b1) which I've been doing some limited but successful testing with so far.

What's Going On

I ask as my testing of Cura 5.0b1 shows that the plugin doesn't show in the marketplace or load on launch. Evidently Cura 5.0 will require a major version change of the SDK, so armed with that knowledge I found the cura application dir, then the ArcWelder plugin dir, and added "8.0.0" to the array of supported_sdk_versions in the plugin.json like a ham fisted barbarian. This enabled the plugin in Cura 5.0b1 for me, as I already had the plugin locally installed before going up to 5.0b1 (3.5.2 plugin version) and I did the following for comparison:

  • sliced CHEP cube without AW enabled in cura w/ my usual profile, it generated a 458Kb file
  • sliced the same CHEP cube STL with AW enabled in cura with no other profile changes, which generated a 426Kb file
  • processed a copy of the first non-enabled gcode through the CLI tool (v1.2.0) and got a 424Kb file

Loading a preview of the generated gcode with AW both via plugin and CLI seem consistent with each other. Separately there may be an issue with cura displaying my AW processed gcode (the skirt looks funky, but seems arc path related); but they were consistent with each other.

I'm going to run a print of my plugin generated gcode after the manual local change to see how it turns out, although with my experience of Cura 5.0b1 so far I'd be surprised if it wasn't fine.

How To Run in Cura 4.9.0 ?

I used Cura 4.9.0 on Mac
I have added this plugin through the marketplace website. It said "Added to Cura"
But in Cura, I don't see this plugin appears in the Extension menu.
Screen Shot 2021-04-26 at 07 45 02

Request for version 1.1.1 in Cura Marketplace

There's a bugfix version of the ArcWelder plugin (v1.1.1) available here .

My current version seems to still be using 1.1.0 (discovered using arcwelder.exe -h ).

Would you be willing to push a new version into the cura marketplace?

Please and thanks. :)

Extruder goes bezirk

Hi.

On the ender 3pro with touchscreen there is a different firmware then the stock marlin fw on the ender 3 models., this having said the following occurs.

When I install arc-welder and run it with the standard settings (so nothing is set to on) the extruder goes bezirk and when printing is pushes a big amount of filament through the nozzle up to the point the extruder is slipping and grinding dangerously. When you do not stop this it will distroy your filament and your extruder motor because of this.

what can be done to get a normal extrusion speed, as set in the slicer settings.

This happens at Cura 4.8.n, Cura 5.1.n and Cura 5.2.n and also in Octo4a so the problem clearly is in the slicer g-code generation after arc-welder is installed.

No I've reinstalled it and arcs are really bad looking and ugly printed, it seems something ore some settings are left behind after uninstall ?

hard parameter limits prevent from using sensible values

if the chosen values for the cura arcwelder plugin parameters exceed the minimum or maximum values, then the plugin refuses to process completely. This is no good behaviour. Especially because it prevents from using sensible values for parameters like

    "arcwelder_resolution":
    {
        "minimum_value": 0.025,
        "maximum_value": 0.075,

There are definitely usable values outside that range.

A better way would be make soft limits that give a warning but to not stop the processing.
Alternatively just drop the limits altogether and put the hints in the parameter description.

Gcode results mutilate file

So the resultant post-processed file appears to mutilate my models. What were supposed to be simple semi-circle arcs of 2mm thickness with filleted edges has these strange lines across the semi-circles' openings.

image

WheelHolders.zip

The slicer is Cura 4.8.0 for an Ultimaker 3E printer. Slicer is set up for Griffin gcode flavor. Arc Welder is enabled.
UM3E_WheelHolders_43g_arcs.zip

Plugin for Cura LulzBot Edition

The current release of Cura LulzBot Edition 3.6.23 (CuraLE) is based on an older version of Ultimaker Cura.

I believe the plugin structure is similar but there's (obviously) no Marketplace from which to install a plugin automagically.

Would it be possible to install this plugin into CuraLE manually and if so, could you provide instructions to do so?

The plugin launch the conversion also when we save the project

gcode_dict = getattr(scene, "gcode_dict", {}) if not gcode_dict: # this also checks for an empty dict Logger.log("w", "Scene has no gcode to process") return

It prevent to launch the conversion if no Gcode have been calculated . But not if we save the project . Any solution to avoid this case ?

ArcWelder default Maximum Arc Radius too large for 8-bit print controllers

This parameter is set to 1000000.0 by default and it sometimes causes a situation where the I or J coordinates of G2 or G3 commands can become very large. This seems to be a problem for at least Pusa I3 family of printers that use Arduino based Einsy Rambo print control boards.

As an example, here's a code line from Planeprint Notos model fuselage6 part after slicing with Cura 4.10.0 and ArcWelder with defaults:

G1 X118.19 Y110.173 E3981.46029
G3 X118.683 Y75.091 I664677.688 J9323.032 E3982.30632
G1 X118.141 Y67.282 E3982.49508

Note the I coordinate that is quite large. This produces a clearly visible print error.

I changed the Maximum Arc Radius to 10000.0 and this seems to have solved the issue. However, I do not know how large radii the Prusa I3 can handle but I'm trying to find out from their forum.

Here's the same code snippet after changing the setting:

G1 X118.19 Y110.173 E3981.46029
G3 X118.398 Y95.132 I7227.325 J92.424 E3981.82301
G1 X118.683 Y75.091 E3982.30632

G1 X118.141 Y67.282 E3982.49508

Note that after the change, the problematic line was split into two parts and the G3 part has much smaller radius.

This is not really a bug but a request for improvement that would help users with 8-bit printers. An image showing the print error is attached.

Print errors

Arc Welder Cura extension causing badly placed skirt and odd movements at higher layers

Hello,

I've been successfully using Arc Welder with Cura for quite a while now, but in the last few days, I've seen some real interesting behavior.

I was originally on Cura version 8.10.x, and noticed that the prints I sliced had the skirts placed off kilter to the actual object I was printing. I also noticed that at some of the higher layers, there were odd movements that did not make sense given the shape of the object.

I re-flashed the firmware on my machine (Ender 3 Pro) thinking that was the issue, to no avail. I played with various settings, checked belts, tightened things, etc... with the same result.

I then decided to update Cura to version 8.12.1, and wound up having the same problems, despite many settings changes in an effort to resolve the issue.

I uploaded the Gcode to an online Gcode viewer and confirmed that it was the Gcode and not my printer.

On a whim, I decided to disable Arc Welder, re-slice and re-upload to Gcode viewer. The new Gcode looks flawless.

I'm not sure what happened, but it appears Arc Welder is the culprit, as I'm now printing the most recent Gcode and it is laying down just fine.

I've attached the STL I was using, as well as the two Gcode files, clearly labeled as to what they are.
NOTE: it appears GitHub doesn't allow upload of .stl or .gcode extensions. I've zipped the three files together.

arcWelder issue.zip

Arc welder creating artifacts in Cura

I see the beauty of Arc welder but have had mixed results using it in cura. It mostly works great but has caused problems a few times.

Please see the attached images of 3 prints...the first two are sliced with different setting and using arc welder, the third has Arc welder turned off and the artifact is gone...ill attach the images as well as the G-code (github made me zip it). Is this an issue or do my settings need to change? I'm using settings very close to the defaults.

Thanks for your time and effort!

1 - 3DBenchy No AW
1 - 3DBenchy AW D
G-code.zip
1 - 3DBenchy AW B

Charmap codec can't encode character \ufeff

After slicing and trying to save the resulting .gcode file, I am hit by an error message:
"Charmap codec can't encode character '\ufeff' in position [440]: character maps to "
I am unable to save the files to either sd card or to disk.

Possibly clashing with other plugins?

Update
Uninstalled 3.5 and installed development snapshot.

Seems to have done the job.

I guess I can close the issue?

no arc movements in gcode

I downloaded this plugin from the ultimaker store, restarted the slicer, loaded the model and clicked generate code, after which I saved it, for verification I opened it with pad ++ notes, and used G2 &G3 pointers, and could not find these commands in the code. please explain why?

No skirt or walls with arcwelder enabled

I enabled arcwelder and sliced. I had 3 walls, 3 bottom layers and a skirt in my settings. The printer skips the skirt, prints the bottom 3 layers with no walls and then prints the infill still without any walls.

I disabled arcwelder and sliced again and it prints correctly.

Request: Better description as to where the option is turned on/off

Since this is by nature a post-processing script, I assumed it would be available in the post-processing script section of CURA.
I was sitting here thinking that it had failed to properly install.

The only way I found out that it was inside of 'Special Modes' was by coming here and seeing someone else's issue about it not showing up in their 'special modes' section (issue was already closed).

Please add a sentence or two to the main description on here and on the CURA Marketplace that tells users that it adds the toggle under the 'special modes' section in their settings menu. (If it already exists, then it wasn't apparent enough, because I missed it...)

Thanks for creating this wrapper. Worked well.

Klipper question - Firmware Compensation

The Firmware Compensation applies to Klipper but can be fixed with changing settings.
My problem: I don't find any information what would be the best setting for Klipper any what should be changed! :D

Printer profile settings not registering

I've created a complete custom printer profile for my use which defines a number of settings that I use globally - many of which are formulaic, which is why I don't just use the internal Cura print profile feature. Two of the options I set in this profile are "arcwelder_enable" (true) and "arcwelder_g90_influences_extruder" (also true). However, neither of these settings are "taking" when using the base printer profile, instead reverting to their default values (false for both). This is the same whether I reassign the "value" or "default_value", or both, in the printer profile.

All other options are functioning as I have specified.

The specific declarations I use are:

				"arcwelder_enable": { "value": true },
				"arcwelder_g90_influences_extruder": { "value": true }

No trailing comma as that is the final entry in the profile.

In case it is relevant, I am using SmartAvionics' master builds of Cura, last updated April 20th (just after the 4.9 release). Plugin is v3.5.1 from the Cura Marketplace.

Plugin installed but no evidence of change

Just installed this plugin hoping to do the conversion from the cura side instead of octoprint so i can still print directly from cura to octoprint. I installed the plugin but not seeing any evidence of it. Should there be a menu option in Extensions? Should it be automatically converting my file when i send it? When i look at the gcode, it doesn't seem to have any G2 or g3 commands added, so doesn't appear to have changed anything.

Maybe i'm missing instructions somewhere on how to have it work, so any help or tips would be fantastic, thanks!

Cura 5.5 engine plugins

Are there any plans to put the functionality of this plugin into a new engine plugin? Towards the bottom of this page it explains them.

This would at the very least allow a more accurate print time estimate, as currently the arc optimizations are applied on saving the file if I understand correctly. I know for round prints arcs can save a bunch of time but it's not obvious how much faster a print is with the current plugin's limitations. It hopefully would also allow the arc movements to show up in the preview as well.

caught a bug: incorrect processing of the trajectory, risk of breaking the printer

Hello, I found a bug when processing a 3d model with a plugin from under the cura 4.10

This is the second time I've encountered this bug. This time I decided to print a gear, but something went wrong.

image

image

image

One of the lines extends beyond the printable part. During printing, the printer rests on the limit switch, but still tries to continue moving, causing wild noise and vibrations.

Settings not always showing

Hi,

It seems that sometimes the subsettings for the plugin aren't shown, when arc welder is selected. I have the option enabled by default in my default profile. Running everything on the latest version. Also have the visibility setting set to "all".
image

In the preferences there's also no option to select any of the subsettings.
image

I can't find a pattern to reliably reproduce this. Usually restarting Cura solves it.
Also find attached the Cura logs.
cura.log

Let me know if you require any additional information. Will be happy to provide it!

arc welder generates g3 with I=-0.000

arc welder generated this line:

G3 X68.406 Y115.000 I-0.000 J2.203 E0.04874

running it through the print fails with:

G2/G3 requires IJ, IK or JK parameters

failed to run on my Klipper firmware / cancels print.

works when I change I-0.000 to I-0.001

Arc Conversion Performance

Cura 5.2.1
ArcWelder 3.6
Ender 3 v1

In using arcwelder and looking at total performance there appeared to be a significant amount of G0 moves that could have (should have) been converted to arcs. you can see this in a designed part that is almost exclusivly circles.
-Top and bottom patterns are "concentric" in this case and the vast majority of the part should be arcs.
-Resolution was increased from .05 to .5 and path tolerance from 5% to 10%. The number of arcs improved significantly but obviously not completely.
-Part constructed in Solidworks and exported in a very high resolution STL (15MB)

You can visualize this in ncviewer.com (blue appears to be arcs, orange appears to be g0 commands)
image

Arc Test 2.zip

Bug / Incompatability with 3.5.1 on Sidewinder X1

I've been using ArcWelder a lot and version 3.5.0 has worked great for me. Unfortunately 3.5.1 has all sorts of problems.

Best shown from an example:

This is Cura. The model is a single layer ring and it has a two loop skirt around it.
image

If I print using 3.5.0 then I get this:
image

If I switch over to 3.5.1 then I get this:
image
image

The first one and a third loops of the skirt print fine but the last two thirds of the skirt and part of the central ring get converted into an arc with great extrusion output.

Gcode created with 3.5.0, 3.5.1 and with ArcWelder switched off are here:
bug.zip

Slight variations in the model cause different effects. I produced this when I first hit the problem though I don't have the files for this one.
image

Printer in use is the Sidewinder X1 v4 with stock firmware. I'm guessing the issue is with the G2 / G3 firmware support within the Sidewinder but as 3.5.0 works so well, it would be great if this could be sorted within the plugin.

Big thanks to you and all those working on ArcWelder. It has significantly improved the quality of my prints and I have it permanently switched on.

Artifacts or settings issue?

Small screw and nut. One with Arc Welder Turned on and one with it off (I'm guessing you can figure out which is which).
Comparison

Here's the settings. They are what came pre-loaded.
AW Settings

Thank you

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.