When I open this page in chrome, it loads forever/freezes, but only when ModuleLinker is enabled.
Otherwise it works as expected.

Adapting the work from https://github.com/fiatjaf/gh-browser/blob/master/python.js to a PHP should not be hard for anyone familiar with PHP include and require workings.

See: https://github.com/pypa/setuptools_scm/blob/master/setup.py#L2

important note

in a docstring turns into

important note:ant●pan class="pl-s">important note:

(which is undesired)

Related issue: #38

e.g. https://raw.githubusercontent.com/fiatjaf/module-linker/backends/data/hackage-modules/Data.Align this should return semialign, but returns these

https://hackage.haskell.org/package/semialign-1.2/docs/Data-Align.html

Haxe seems to have an easy enough module and import system to be supported by Module Linker.

This looks like a great plugin! Can I get it for Opera somewhere?

Hello!

I have some troubles with this extension, when pressing Back and Forward browser buttons 😰

Steps to reproduce:

1. Load some file, application for example — there are highlights.
2. Click to some require (require_relative 'router', for example) — works good, now you in router file with highlights.
3. Press browser Back button — works good, now you in application file again with highlights.
4. Press browser Forward button — BAM, you in router file without highlights (and some dynamic GitHub loading seen).

Thanks.

Hello!

SASS has partials, which filenames start with _, but it's not written in @import: https://sass-lang.com/documentation/at-rules/import

So, we're having incorrect links (with 404).

Example: https://github.com/nana-4/materia-theme/blob/8988c72/src/chrome/chrome-scrollbar-dark/scrollbars.scss

Incorrect link to https://github.com/nana-4/materia-theme/blob/8988c72/src/_sass/colors.scss

Correct link is https://github.com/nana-4/materia-theme/blob/8988c72/src/_sass/_colors.scss

Can you add better support for PHP?

This should include better composer.json handling.

The current version only links normal dependencies. But it should also link extension dependencies (ext-*) to correct documentation page on PHP documentation website. Suggested dependencies in suggest section should also be linked correctly.

It should also link name field to package on Packagist (but don't then forget to fix #45), autoload and autoload-dev sections to correct directories and bin section to correct file.

Composer's composer.json file is similar to Node's package.json so you could take some code from there. You should also look to composer.json schema for reference.

There should also be parsing of PHP files.

First, it should link require, require_once, include and include_once to correct files. This is similar to Node, except that it can be used with or without brackets.

It should also link use statements. This is a bit different because it includes namespace instead of the file. But with autoloading, program then includes correct file. In this case, this extension should somehow "extract" correct file from namespace and link it.

• add_runtime_dependency
• add_development_dependency
• add_dependency

High level:

• Dependencies in a cycle

See: https://github.com/mhammond/pywin32/blob/d0dc7b56caf07cc3301d0bd9584a1797697ddd41/setup.py#L83-L84

When import lists several modules

import os●, string, sys
import types●, glob

only first one in line gets linked, while others are valid stdlib modules as well.

Link to file.

On the following page (https://github.com/alexcrichton/futures-rs/blob/80611a740db789c1aa62942d9b3d1ee3296bb333/src/future/empty.rs), Future link leads to https://github.com/scareangel/future-rs module (which doesn't seem to exist at all) but should link to https://github.com/alexcrichton/futures-rs/blob/80611a740db789c1aa62942d9b3d1ee3296bb333/src/future/mod.rs#L168.

Also, Poll and Async are not resolved at all.

I think the issue is that the module linker only supports linking modules and does not resolve types.

I think it would be more elegant to manipulate the element objects instead of rewriting innerHTML.

For example, this could be substituted with something like this:

var newElem = link.get(0);
var oldTextElem = Array.from(elem.querySelector(".pl-s").childNodes)
    .filter(function (node) { return node.nodeType === 3 })[0];
elem.querySelector(".pl-s").replaceChild(newElem, oldTextElem);

Error in event handler for runtime.onMessage: TypeError: Cannot read property '1' of null
    at main (chrome-extension://dglofghjinifeolcpjfjmfdnnbaanggn/dist/full.js:22:64)
    at chrome-extension://dglofghjinifeolcpjfjmfdnnbaanggn/dist/full.js:118:3

Error occurs at this page: https://github.com/getsentry/sentry/pull/7521/files

Sometimes Back and Forward in browser are broken (I don't know if it cause of this).

Is there any plan to do this?

Hi, could this please be extended to support github enterprise setups?

It looks like the 'don't run more than once' protection is broken because Github changed their markup?

This line injects an element to stop the content script from running multiple times but I think it doesn't work because the element it injects into does not exist (or maybe it doesn't always exist).

In this screenshot, notice that there are multiple dots next to the imports, and the <span id="module-linker-done"> doesn't exist in the page.

E.g.:
use database_url::extract_database_url;

import_plugins turns into import_plugins_plugins●ort_plugins.
It might be multiline-only bug, but I haven't checked.

Example: https://github.com/ansible/ansible/blob/b9b8081/test/runner/lib/cloud/__init__.py#L19

source:

from lib.util import (
    ApplicationError,
    display,
    is_shippable,
    import_plugins,
    load_plugins,
    ABC,
)

result:

from lib●.util import (
    ApplicationError,
    display,
    is_shippable,
    import_plugins_plugins●ort_plugins,
    load_plugins,
    ABC,
)

Consider this Cargo.toml file:
https://github.com/vanderlokken/rust-vst-gui/blob/master/Cargo.toml

Module-Linker only links the vst dependency in line 10.
But memoffset in line 13 is also a dependency, a conditional one ([target.'cfg(windows)'.dependencies]).

When local module is written like below, module linker links remote module having same namesake.

const hello = require('hello');  // it's a local module. not remote.

I suggest that module-linker should find the package.json first. So it can resolve whether the module is local or remote.

I do have one more remark, it's missing some import statements, for example, this one isn't getting marked up: https://github.com/chrisdone/graphmod/blob/master/src/Main.hs#L18

from https://www.reddit.com/r/haskell/comments/66cdyd/a_chrome_extension_that_adds_links_to_hackage/dgjyfcd/

Hey there, great extension!

I can't really say why but just wanted to point out that there might a memory leak. Been running my mac book for 5 days, 46 mins and the memory has reached 1.6 gb.
Cheers

Just the @import statements, to relative or absolute URLs. Should be very simple to do with some basic regex/string parsing and require('../helpers').createLink.

At https://github.com/blha303/DO-runin/blob/master/runin/runin.py#L9, importing a file in the same directory using the package name seems to break things.

import runin.DO as DOrunin.DOlass="pl-k">import runin.DO as DO

Try visiting https://github.com/modulesio/yarn-zeo/blob/e46a40529bf04a96c0ad0ea9c375ea9a9f0deffc/__tests__/fixtures/install/install-file-link-dependencies/package.json

This is what it looks like:

Here's what it should look like:

Why not?

When a rust module is defined in a file, e.g.

mod test {
    ....
}

a link is added for "test" which leads somewhere other than the definition, because the definition follows.

Example.

After the mod keyword I believe there are only four cases:

• A brace (and therefore definition) follows, so there should be no link.
• It links to a {modname}.rs file elsewhere in the repo (this is what it does now).
• It links to a {modname}/mod.rs elsewhere in the repo.
• The code is broken.

Btw I've head a great experience navigating Go repos with this; thank you for your work!

e.g. in this file https://github.com/aviabird/angularspree/blob/master/src/app/app.module.ts

If you click on

import { AppComponent } from './app.component';

You will land on app.component.html instead of app.component.ts

I don't know how this works, but I see a variety of different languages, so I guess you have some flexible solution. Would it be possible to add Scala support?

Actually, if there were some contribution docs, I could try to add it myself..

This plugin looks awesome but when I try to add it to chrome, I get the following error:

Package is invalid. Details: 'Could not load background script 'background.js'.'.

During the option to enter a GitHub API token, it links to the page to create a new API token, but does not explain what scopes it needs in order to work correctly. Which scopes are necessary?

Link of some modules anchors git URL not github repo.
For example, gulp's package.json
Hover mouse on deprecated, interpret, etc...

In https://github.com/sb89/crystal-swapi/blob/master/src/swapi.cr

links to https://crystal-lang.org/api/0.21.1/HTTP.html
instead of https://crystal-lang.org/api/0.21.1/HTTP/Client.html

Consider this code:

from ..models.alphaname import Alphaname
from ..forms.alphaname import AlphanameForm

from ..tasks import submitAlphanameInstantly

Module Linker creates references to:

• https://bitbucket.org/neithere/pymodels/
• https://pypi.python.org/pypi/forms
• https://github.com/stevepeak/tasks-cli

instead of referring upper-level packages/modules.

However it successfully recognises same-package imports, like:

from .models.campaign import Campaign
from .models.task import Task
from .models.alphaname import Alphaname
from .models.message import Message

I just came across a file that uses #!/usr/bin/env node instead of a .js extension. It threw me off for a second because GitHub still syntax highlighted it, but no Module Linker links showed up.

I noticed the switch statement to detect the language. If there's no match, could main() also see if the first line begins with #!, and if it does, check that for common program names?

What are your thoughts of this approach?

First off, thanks for this incredible tool 😄

I may have missed this, but it'd be nice to know what the different colors mean.

At first I thought green meant "resolved" and yellow meant "not enough info" or something. It was only after finding this that I could see a full list (and even then, you can only get an idea of what the color is since it's code).

A legend in the docs, README, or better yet, in options.html would be awesome.

When I'm on GitHub in a source file (history index n) and go back in chrome (n-1), sometimes only the URL bar changes to the previous (n-1) URL but the content stays the same (n), when this extension is installed.
Then I have to reload or go back (n-2) and forward (to n-1) to get to that page (n-1).
This shouldn't happen, please fix it :)

When the imp module is imported, expected behavior is to have import preserved, and the link applied to imp.

Instead, import is broken into imp (with a link) and ort, followed by a non-linked imp.

Example on GitHub

I know zero things about OCaml, but apparently it is possible to add support to it using http://opam.ocaml.org/ and the idea that files in a directory are automatically imported as modules: https://github.com/inhabitedtype/httpaf/blob/f0b964b93fb6ed25bc63e19a9f1fe10dc8885e48/lib/httpaf.ml

Is this correct?

The extension disappeared from Chrome and from its web store:
https://chrome.google.com/webstore/detail/dglofghjinifeolcpjfjmfdnnbaanggn

Any idea why? :)

EDIT: I see the following. Why does chrome say it violates the policy?

Extension incorrectly links authors as packages. This happens because both the package name and author name use name key. I tested this in Node.js project but it probably happens in every project which uses similar keys.

Example of this problem is in web3.js:

{
    "name": "web3", <---- Corrctly links to package
    ...
    "authors": [
        {
            "name": "Samuel Furter", <---- Incorrectly links to package
            "email": "[email protected]",
            "homepage": "https://github.com/nivida"
        },
        ...
    ],
    ...
}

In this example, "name": "web3" is correctly linked to correct package, but "name": "Samuel Furter" (and all other authors' names) is incorrectly linked to unexisting package with that name.

Hello!

I have a file in repository with require_relative, and it's not highlighted by extension.

Can you implement this?

Thanks.