Comments (8)
dericed
commented on September 22, 2024
hmmm for me
% make clean
RFC rendering has been tested with mmark version 2.2.8, xml2rfc 2.32.0, xmlstarlet 1.6.1, pdfcrop v1.38, and pdf2svg 0.2.3, please ensure these are installed and recent enough.
rm -f ffv1.pdf ffv1-v4.pdf ffv1.html ffv1-v4.html draft-ietf-cellar-ffv1-* merged_*
% make
RFC rendering has been tested with mmark version 2.2.8, xml2rfc 2.32.0, xmlstarlet 1.6.1, pdfcrop v1.38, and pdf2svg 0.2.3, please ensure these are installed and recent enough.
cat rfc_frontmatter.md "ffv1.md" rfc_backmatter.md | grep -v "^AART:" | grep -v "^SVGC" | grep -v "{V4}" | sed "s|^AART:||g;s|{V3}||g;s|SVGI:||g;s|@BUILD_DATE@|2020-09-30|" > draft-ietf-cellar-ffv1-17.md
bash makesvg
mmark "draft-ietf-cellar-ffv1-17.md" | sed 's|<date year="undated"></date>|<date>undated</date>|g' > "draft-ietf-cellar-ffv1-17.xml"
xmlstarlet edit --inplace --insert "/rfc" --type attr -name sortRefs -v "true" "draft-ietf-cellar-ffv1-17.xml"
bash svg2src "draft-ietf-cellar-ffv1-17.xml"
xml2rfc --html --v3 "draft-ietf-cellar-ffv1-17.xml" -o "draft-ietf-cellar-ffv1-17.html"
Created file draft-ietf-cellar-ffv1-17.html
xml2rfc --v3 "draft-ietf-cellar-ffv1-17.xml" -o "draft-ietf-cellar-ffv1-17.txt"
Created file draft-ietf-cellar-ffv1-17.txt
cat rfc_frontmatter.md "ffv1.md" rfc_backmatter.md | grep -v "^AART:" | grep -v "^SVGC" | grep -v "{V3}" | sed "s|^AART:||g;s|{V4}||g;s|SVGI:||g;s|@BUILD_DATE@|2020-09-30|" > draft-ietf-cellar-ffv1-v4-14.md
bash makesvg
mmark "draft-ietf-cellar-ffv1-v4-14.md" | sed 's|<date year="undated"></date>|<date>undated</date>|g' > "draft-ietf-cellar-ffv1-v4-14.xml"
xmlstarlet edit --inplace --insert "/rfc" --type attr -name sortRefs -v "true" "draft-ietf-cellar-ffv1-v4-14.xml"
bash svg2src "draft-ietf-cellar-ffv1-v4-14.xml"
xml2rfc --html --v3 "draft-ietf-cellar-ffv1-v4-14.xml" -o "draft-ietf-cellar-ffv1-v4-14.html"
Created file draft-ietf-cellar-ffv1-v4-14.html
xml2rfc --v3 "draft-ietf-cellar-ffv1-v4-14.xml" -o "draft-ietf-cellar-ffv1-v4-14.txt"
Created file draft-ietf-cellar-ffv1-v4-14.txt
% mmark --version
2.2.9
% xml2rfc --version
xml2rfc 2.47.0
% xmlstarlet --version
1.6.1
compiled against libxml2 2.9.4, linked with 20904
compiled against libxslt 1.1.29, linked with 10129
% pdfcrop --version
pdfcrop 2012/11/02 v1.38
OK my mmark is ahead of yours (2.2.8 -> 2.2.9) and xml2rfc is ahead (2.47.0 -> 2.41.0).
I see that your svg includes a g/@style attribute and the symbol element that causes most of the errors, but those are addressed in
Lines 13 to 15 in d188994
from ffv1.
michaelni
commented on September 22, 2024
Do you mind deleting the svg files and rerunning the make process.
are you asking me or "make clean" ? "make clean" says its creators forgot and its really sad it cannot.
from ffv1.
dericed
commented on September 22, 2024
I was asking you. If helpful, we could add the svg files to make clean.
from ffv1.
michaelni
commented on September 22, 2024
ok, fails worse :)
ill show the relevant one:
makesvg: line 9: pandoc: command not found
and before you say install pandoc, yes of course but that requirement is not documented it should be documented and ideally tested for
from ffv1.
michaelni
commented on September 22, 2024
and after installing pandoc it fails even more
make
RFC rendering has been tested with mmark version 2.2.8, xml2rfc 2.32.0, xmlstarlet 1.6.1, pdfcrop v1.38, and pdf2svg 0.2.3, please ensure these are installed and recent enough.
bash makesvg
mmark "draft-ietf-cellar-ffv1-17.md" | sed 's|<date year="undated"></date>|<date>undated</date>|g' > "draft-ietf-cellar-ffv1-17.xml"
xmlstarlet edit --inplace --insert "/rfc" --type attr -name sortRefs -v "true" "draft-ietf-cellar-ffv1-17.xml"
bash svg2src "draft-ietf-cellar-ffv1-17.xml"
xml2rfc --html --v3 "draft-ietf-cellar-ffv1-17.xml" -o "draft-ietf-cellar-ffv1-17.html"
Traceback (most recent call last):
File "/home/michael/.local/bin/xml2rfc", line 11, in <module>
sys.exit(main())
File "/home/michael/.local/lib/python2.7/site-packages/xml2rfc/run.py", line 649, in main
xmlrfc.tree = prep.prep()
File "/home/michael/.local/lib/python2.7/site-packages/xml2rfc/writers/preptool.py", line 355, in prep
func(e, e.getparent())
File "/home/michael/.local/lib/python2.7/site-packages/xml2rfc/writers/preptool.py", line 1826, in element_artwork
svg = etree.fromstring(data)
File "src/lxml/etree.pyx", line 3235, in lxml.etree.fromstring
File "src/lxml/parser.pxi", line 1876, in lxml.etree._parseMemoryDocument
File "src/lxml/parser.pxi", line 1764, in lxml.etree._parseDoc
File "src/lxml/parser.pxi", line 1127, in lxml.etree._BaseParser._parseDoc
File "src/lxml/parser.pxi", line 601, in lxml.etree._ParserContext._handleParseResultDoc
File "src/lxml/parser.pxi", line 711, in lxml.etree._handleParseResult
File "src/lxml/parser.pxi", line 640, in lxml.etree._raiseParseError
File "<string>", line 1
lxml.etree.XMLSyntaxError: Document is empty, line 1, column 1
Makefile:26: recipe for target 'draft-ietf-cellar-ffv1-17.html' failed
make: *** [draft-ietf-cellar-ffv1-17.html] Error 1
also if i manually delete *.svg again and run make clean and then make it seems working but i shouldnt have to do this
make clean
RFC rendering has been tested with mmark version 2.2.8, xml2rfc 2.32.0, xmlstarlet 1.6.1, pdfcrop v1.38, and pdf2svg 0.2.3, please ensure these are installed and recent enough.
rm -f ffv1.pdf ffv1-v4.pdf ffv1.html ffv1-v4.html draft-ietf-cellar-ffv1-* merged_*
rm *.svg
make
RFC rendering has been tested with mmark version 2.2.8, xml2rfc 2.32.0, xmlstarlet 1.6.1, pdfcrop v1.38, and pdf2svg 0.2.3, please ensure these are installed and recent enough.
cat rfc_frontmatter.md "ffv1.md" rfc_backmatter.md | grep -v "^AART:" | grep -v "^SVGC" | grep -v "{V4}" | sed "s|^AART:||g;s|{V3}||g;s|SVGI:||g;s|@BUILD_DATE@|2020-09-30|" > draft-ietf-cellar-ffv1-17.md
bash makesvg
PDFCROP 1.38, 2012/11/02 - Copyright (c) 2002-2012 by Heiko Oberdiek.
==> 1 page written on `quantizationtablesets.svg_cropped.pdf'.
PDFCROP 1.38, 2012/11/02 - Copyright (c) 2002-2012 by Heiko Oberdiek.
==> 1 page written on `context.svg_cropped.pdf'.
PDFCROP 1.38, 2012/11/02 - Copyright (c) 2002-2012 by Heiko Oberdiek.
==> 1 page written on `rgb1.svg_cropped.pdf'.
PDFCROP 1.38, 2012/11/02 - Copyright (c) 2002-2012 by Heiko Oberdiek.
==> 1 page written on `rgb2.svg_cropped.pdf'.
PDFCROP 1.38, 2012/11/02 - Copyright (c) 2002-2012 by Heiko Oberdiek.
==> 1 page written on `samplediff.svg_cropped.pdf'.
PDFCROP 1.38, 2012/11/02 - Copyright (c) 2002-2012 by Heiko Oberdiek.
==> 1 page written on `rangebinaryvalues1.svg_cropped.pdf'.
PDFCROP 1.38, 2012/11/02 - Copyright (c) 2002-2012 by Heiko Oberdiek.
==> 1 page written on `rangebinaryvalues2.svg_cropped.pdf'.
PDFCROP 1.38, 2012/11/02 - Copyright (c) 2002-2012 by Heiko Oberdiek.
==> 1 page written on `rangebinaryvalues3.svg_cropped.pdf'.
PDFCROP 1.38, 2012/11/02 - Copyright (c) 2002-2012 by Heiko Oberdiek.
==> 1 page written on `rangebinaryvalues4.svg_cropped.pdf'.
PDFCROP 1.38, 2012/11/02 - Copyright (c) 2002-2012 by Heiko Oberdiek.
==> 1 page written on `rangebinaryvalues5.svg_cropped.pdf'.
PDFCROP 1.38, 2012/11/02 - Copyright (c) 2002-2012 by Heiko Oberdiek.
==> 1 page written on `rangebinaryvalues6.svg_cropped.pdf'.
PDFCROP 1.38, 2012/11/02 - Copyright (c) 2002-2012 by Heiko Oberdiek.
==> 1 page written on `rangebinaryvalues7.svg_cropped.pdf'.
PDFCROP 1.38, 2012/11/02 - Copyright (c) 2002-2012 by Heiko Oberdiek.
==> 1 page written on `statetransitiontable1.svg_cropped.pdf'.
PDFCROP 1.38, 2012/11/02 - Copyright (c) 2002-2012 by Heiko Oberdiek.
==> 1 page written on `statetransitiontable2.svg_cropped.pdf'.
PDFCROP 1.38, 2012/11/02 - Copyright (c) 2002-2012 by Heiko Oberdiek.
==> 1 page written on `initialstatedelta1.svg_cropped.pdf'.
PDFCROP 1.38, 2012/11/02 - Copyright (c) 2002-2012 by Heiko Oberdiek.
==> 1 page written on `initialstatedelta2.svg_cropped.pdf'.
mmark "draft-ietf-cellar-ffv1-17.md" | sed 's|<date year="undated"></date>|<date>undated</date>|g' > "draft-ietf-cellar-ffv1-17.xml"
xmlstarlet edit --inplace --insert "/rfc" --type attr -name sortRefs -v "true" "draft-ietf-cellar-ffv1-17.xml"
bash svg2src "draft-ietf-cellar-ffv1-17.xml"
xml2rfc --html --v3 "draft-ietf-cellar-ffv1-17.xml" -o "draft-ietf-cellar-ffv1-17.html"
Created file draft-ietf-cellar-ffv1-17.html
xml2rfc --v3 "draft-ietf-cellar-ffv1-17.xml" -o "draft-ietf-cellar-ffv1-17.txt"
Created file draft-ietf-cellar-ffv1-17.txt
cat rfc_frontmatter.md "ffv1.md" rfc_backmatter.md | grep -v "^AART:" | grep -v "^SVGC" | grep -v "{V3}" | sed "s|^AART:||g;s|{V4}||g;s|SVGI:||g;s|@BUILD_DATE@|2020-09-30|" > draft-ietf-cellar-ffv1-v4-14.md
bash makesvg
mmark "draft-ietf-cellar-ffv1-v4-14.md" | sed 's|<date year="undated"></date>|<date>undated</date>|g' > "draft-ietf-cellar-ffv1-v4-14.xml"
xmlstarlet edit --inplace --insert "/rfc" --type attr -name sortRefs -v "true" "draft-ietf-cellar-ffv1-v4-14.xml"
bash svg2src "draft-ietf-cellar-ffv1-v4-14.xml"
xml2rfc --html --v3 "draft-ietf-cellar-ffv1-v4-14.xml" -o "draft-ietf-cellar-ffv1-v4-14.html"
Created file draft-ietf-cellar-ffv1-v4-14.html
xml2rfc --v3 "draft-ietf-cellar-ffv1-v4-14.xml" -o "draft-ietf-cellar-ffv1-v4-14.txt"
Created file draft-ietf-cellar-ffv1-v4-14.txt
from ffv1.
dericed
commented on September 22, 2024
Hi @michaelni, I certainly don't disagree and had attempted to address this in the buildcheck script, adapted from @robux's work at #222. I'm not blocking the idea from happening, but I don't know how to do it at the moment.
from ffv1.
michaelni
commented on September 22, 2024
@dericed, ok, i understand. so i tried adding a version check and ended up with #236
from ffv1.
michaelni
commented on September 22, 2024
closing in favor of #240 which is about the remaining issue
from ffv1.
Related Issues (20)
- 4.6.2. plane_pixel_height has incorrect information on chroma planes
- Quant tables: reference decoder relies too much on reference encoder HOT 3
- [v4] Consider adding prediction to inter mode HOT 5
- sign_extend is used but not defined HOT 1
- Spec allows >8bit depth in Golomb-Rice mode but nothing can make this HOT 3
- IEEE CRC-32 referenced in spec is not a standard IEEE CRC-32 HOT 8
- JPEG2000-RCT transform equations are incomplete / don't match reference HOT 1
- few instances of lines too long HOT 2
- [v4] Consider other RCTs HOT 5
- section 3.8.1.2 needs to define get_rac HOT 8
- section 3.8.1.1 should have pseudocode HOT 16
- [v4] slices HOT 5
- Nothing in the Makefile removes the genarated *.svg files HOT 1
- reading through section 3.8.1.1 HOT 8
- add list of ffv4 goals and promises
- Renaming of the repo to ffv1-specification HOT 4
- FFV1 CUDA accelerated version HOT 7
- Handling of odd dimensions, subsampling and more than 1 slice
- remove exceptions from FFV1 version 4? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ffv1.