Comments (8)
https://github.com/dwbuiten/go-ffv1/blob/master/ffv1/rangecoder/range.go
also change reference from 3.8.1.1 to cite figure 9.
from ffv1.
from ffv1.
Worth noting here that when I implemented go-ffv1, it was with an older revision of the spec, and it seems the figure numbers have since changed... I'll update the comments.
(Also worth noting that go-ffv1 is not an official reference decoder.)
from ffv1.
Hi @dwbuiten, you could contextualize your comments to the version of the draft such as "draft-ietf-cellar-ffv1-17", although as the document is in "IESG Evaluation" status the RFC number may be soon.
from ffv1.
Yes, I'll do that when I update them.
from ffv1.
@dwbuiten, @michaelni, are you able to assist with the get_rac piece of Barry's review. The quote from the review is
— Section 3.8.1.2 —
"get_rac" returns a boolean, computed from the bytestream as
described in Section 3.8.1.1.
I see nothing in Section 3.8.1.1 that describes get_rac.
I understand that get_rac refers to figure 9; however a narrative could help. For instance does rac
mean RAnge Coded binary value
? If figure 9 is read as the i-th range coded binary value equals
, then what is the R_i
of the formula mean?
from ffv1.
I understand that get_rac refers to figure 9; however a narrative could help. For instance does
rac
meanRAnge Coded binary value
?
IIRC get_rac() was named for consistancy with get_cabac(), it returns a single bit coded using the range coder. Not sure if the 3 letters can be matched to grammatically 100% fitting words
from ffv1.
It looks like this issue can be closed (#230 and #241 are merged).
from ffv1.
Related Issues (20)
- 4.6.2. plane_pixel_height has incorrect information on chroma planes
- Quant tables: reference decoder relies too much on reference encoder HOT 3
- [v4] Consider adding prediction to inter mode HOT 5
- sign_extend is used but not defined HOT 1
- Spec allows >8bit depth in Golomb-Rice mode but nothing can make this HOT 3
- IEEE CRC-32 referenced in spec is not a standard IEEE CRC-32 HOT 8
- JPEG2000-RCT transform equations are incomplete / don't match reference HOT 1
- few instances of lines too long HOT 2
- [v4] Consider other RCTs HOT 5
- section 3.8.1.1 should have pseudocode HOT 16
- [v4] slices HOT 5
- Build produces pages of warnings and errors HOT 8
- Nothing in the Makefile removes the genarated *.svg files HOT 1
- reading through section 3.8.1.1 HOT 8
- add list of ffv4 goals and promises
- Renaming of the repo to ffv1-specification HOT 4
- FFV1 CUDA accelerated version HOT 7
- Handling of odd dimensions, subsampling and more than 1 slice
- remove exceptions from FFV1 version 4? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ffv1.