ferrisx4 / chainreaction Goto Github PK

The check for uniqueness was not made in end cases where the last word in the chain already existed in the chain.

Ideally a solution to this would be to check if the Ending word provided in the user's argument exists in the chain at all before the chain is long enough. In this way, the algorithm would chuck out any candidate chains early before filling out the rest of the chain.

An easier solution to implement would be to simply check for uniqueness before checking for valid chain.

Should the word list be automatically alphabetized, including the children words of each parent?

Pros:

• Will aid in filtering manually through chains
• May ease search times if autocomplete functionality is offered in the future

Cons:

• Will remove provenance of when each word was added to the list, and each child added to its parent.

This seems like an obvious decision.

Several "actions" result in the same exact code being run, as follows:

array_pop($chain);
$depth -= 1;

These can be consolidated into a single action response to cut down on if statement processing.

The following actions all result in the above code firing, as well as any unhandled actions:

• reached_chain_length_target
• no_child
• chain_found for some reason. This should be its own issue.
• already_in_chain
• premature_chain

In a few of these, decrementing depth comes before popping the array, but this probably doesn't matter.