felixkmh / themeextras-for-playnite Goto Github PK

I'm working through a custom theme and wanted to add icons to links as provided by the ThemeExtras_Links content control.

As opposed to the vertical list presented, I made a horizontal stackpanel to hold the items. For the most part, this works fine, but whenever I do certain functions (usually related to other plugins) Theme Extras crashes Playnite with the Whoops message.

My Grid for ThemeExtras_Links looks like this:

<Grid Margin="0,10,0,5" Height="35" Background="{DynamicResource NormalBrushDark}">
	<ContentControl x:Name="ThemeExtras_Links"
					Visibility="{PluginStatus Plugin=felixkmh_Extras_Plugin, Status=Installed}">
		<ContentControl.Resources>
			<Style TargetType="ItemsControl">
				<Setter Property="ItemsPanel">
					<Setter.Value>
						<ItemsPanelTemplate>
							<StackPanel Orientation="Horizontal"/>
						</ItemsPanelTemplate>
					</Setter.Value>
				</Setter>
				<Setter Property="ItemTemplate">
					<Setter.Value>
						<DataTemplate>
							<DockPanel Margin="5">
								<Viewbox DockPanel.Dock="Left" Margin="0,0,5,0" Width="18" Height="18">
									<ContentControl>
										<ContentControl.Content>
											<Binding Path="Icon">
												<Binding.TargetNullValue>
													<TextBlock Text="&#xEF71;" 
															   Style="{DynamicResource BaseTextBlockStyle}" 
															   FontFamily="{StaticResource FontIcoFont}"/>
												</Binding.TargetNullValue>
											</Binding>
										</ContentControl.Content>
									</ContentControl>
								</Viewbox>
								<TextBlock DockPanel.Dock="Left" 
										   VerticalAlignment="Center" 
										   TextTrimming="CharacterEllipsis"
										   ToolTip="{Binding Url}" Margin="0,0,10,0">
									<Hyperlink Command="{Binding OpenLinkCommand}">
										<Run Text="{Binding Name}"/>
									</Hyperlink>    
								</TextBlock>
							</DockPanel>
						</DataTemplate>
					</Setter.Value>
				</Setter>
			</Style>
		</ContentControl.Resources>
	</ContentControl>
</Grid>

I have also attached two crash reports from Playnite, one crashed when using the "Copy Info to other Copies" function in DuplicateHider, the other when downloading SuccessStory Achievements for a game.

The crashes always occur after the other function is completed and control of the UI is going back to the user.
Theme_Extras_Crash_SS.zip
Theme_Extras_Crash_DH.zip

Details view: Switching with arrow keys doesn't update the banner in all cases.
Grid view: Some games display a banner which should only be displayed for games more than 1 spot away.

To reproduce the issue:

• At least 4 games are necessary:

• Game 1: Library A, Source A*, Platform PC

• Game 2: Library Playnite, Source B, Platform PC

• Game 3: Library Playnite, Source C, Platform PC

• Game 4: Library D, Source D, Platform PC

• Additionally other games to be able to scroll and one of these games uses Source E.

• No source banner override set for: A*, D

• Source banner overrides set for: B, C, E

• No other banner overrides than these 3 set.

• Grid view: 4 games are displayed in each row.

Note: A = A* with different capitalization (I guess it doesn't affect it but in my opinion it's better to state all details).

Confirmed this issue for two themes: DH_Dawn, Harmony
Confirmed this issue for Theme Extras versions: 1.4.1 and 1.4.2

Details view:
If I use arrow keys to switch between these four games the two games being part of Playnite library always display the same banner.
If I cycle from top to bottom game 2 and 3 display the banner of game 2.
If I cycle from bottom to top game 3 and 2 display the banner of game 3.
Game 1 and 4 display their library banner without issues.

Grid view:
If the games are in view when switching to grid view the banners are displayed properly.
If the games are not in view (either because of selecting a game far away or because of scrolling to a different game and scrolling back) the banner display is faulty in some cases. It doesn't matter if arrow keys or mouse scrolling is used. It also doesn't matter how fast I'm scrolling. One of the two Playnite library games in between the two other libraries will sometimes display a banner which doesn't belong to itself or any of it's direct neighbors. It's similar to the details view issue but the distance between the game with the faulty banner and the next game with said banner is bigger.

Hi, I've been using this plugin for awhile to display banners which corelate to the specific platforms/game stores that each game belongs to. However, recently, I changed the size of my game covers in Grid Mode, and this seems to have caused a problem where the banners seem to be misaligned, appearing slightly smaller than the actual games. Further, when the game is hovered over with the cursor, the banner can moving slightly, displaying a visible gap between the game and banner.

Banners are one of my favorite parts of Playnite, and I would love to see this issue fixed!

Would it be possible to add an option to base choice of banner on Source instead of Library or Platform?

It's not possible to change library for games that are imported manually, which means I'm not able to change the banner of manually imported games that are available from EA through Gamepass. (Those games can't be imported automatically.)

Currently the only banner these games get is the PC games banner, but I would like to change them to the Origin banner.

I noticed this happening fairly recently, if there is an add-on update and you restart Playnite from the popup after downloading the update the theme icon that is applied for the shortcut in the taskbar and system tray defaults back to the original Playnite icon

EA has officially killed off Origin and Playnite updated it as such. There's no word "Origin" appearing in Playnite anymore so I think you should update the banner accordingly.

Currently, in grid mode, any game with a title too big has the name cut off. Would it be possible to add a scrolling text feature when hovering over a game? Someone on the Playnite discord suggested I post my request here, if this would be at all possible I'd very much appreciate it.

Had to turn it off because after one restart it started consistently crashing at startup. I assume some data corruption occured? Or maybe some other plugin/theme upgrade caused this. Let me know if you need any sort of logs (and where they are).

EDIT: also occured with default theme.

Here's some log that Playnite asks to generate on crash:
log.zip

Would it be possible to add game age ratings/censor icons as an additional overlay feature?

I collected most of the PEGI, ESRB, Cero, BBFC, etc. icons here a few years ago: https://github.com/Darthagnon/PEGI

If theme banners and override banners have a conflict, theme banners seem to win. Based on the name, I would expect banner overrides to win such conflicts.