feds01 / durak-cards Goto Github PK

When a player exits a game, they should be able to view the cards of the other active players by simply clicking on their profile picture.

Appears on chrome, firefox and safari:

Crash report:

2021-01-16T17:58:39.105719+00:00 app[web.1]: /app/src/socket/handlers/playerMove.js:177
2021-01-16T17:58:39.105729+00:00 app[web.1]: console.log("Stale connection on ".concat(lobby.pin, ": socketId=").concat(socketId, ", player=").concat(p.name));
2021-01-16T17:58:39.105729+00:00 app[web.1]: ^
2021-01-16T17:58:39.105730+00:00 app[web.1]: 
2021-01-16T17:58:39.105731+00:00 app[web.1]: ReferenceError: p is not defined
2021-01-16T17:58:39.105731+00:00 app[web.1]: at forEach (/app/src/socket/handlers/playerMove.js:114:91)
2021-01-16T17:58:39.105732+00:00 app[web.1]: at Map.forEach (<anonymous>)
2021-01-16T17:58:39.105732+00:00 app[web.1]: at _callee$ (/app/src/socket/handlers/playerMove.js:103:18)
2021-01-16T17:58:39.105733+00:00 app[web.1]: at tryCatch (/app/node_modules/regenerator-runtime/runtime.js:63:40)
2021-01-16T17:58:39.105733+00:00 app[web.1]: at Generator.invoke [as _invoke] (/app/node_modules/regenerator-runtime/runtime.js:293:22)
2021-01-16T17:58:39.105734+00:00 app[web.1]: at Generator.next (/app/node_modules/regenerator-runtime/runtime.js:118:21)
2021-01-16T17:58:39.105734+00:00 app[web.1]: at asyncGeneratorStep (/app/src/socket/handlers/playerMove.js:22:103)
2021-01-16T17:58:39.105735+00:00 app[web.1]: at _next (/app/src/socket/handlers/playerMove.js:24:194)
2021-01-16T17:58:39.105735+00:00 app[web.1]: at processTicksAndRejections (node:internal/process/task_queues:94:5)

It should gracefully handle the case if the lobby is full or currently in play.

• Save game state when a modification occurs.
• Load game state when a modification needs to occur.

Players who didn't join in the lobby should be able to spectate the game despite not participating in the actual game.

• Finalise if 6 cards are on the table
• Finalise if defender can't cover any more cards.
• Finalise if the no other cards by any player can be placed (Not complex) - a simple case where 4 of the same numeric type is placed. Any more complicated round finalising could give away the player's cards to other players.

• Add the ability for players to add 'bots' of varying difficulty to the game.

The card used to transfer the 'defence' status is duplicated and not removed from the original player.

Page has both vertical and horizontal scroll bars. There is blank space when scrolling to the right.

• Display the player's deck.
• Display and allow the player to interact with the player deck.
• Display the game deck including the trump card.
• Display other users including information about who is defending, how many cards each player has, and who had skipped the turn.

• Add registration route for new users to use.
• Add small widget on the home page to direct users to 'register' or 'login' if they wish (bottom of the page'.
• Improve login page to reflect the style of the app and add a link to 'register account' page.

Stack trace:

TypeError: Cannot read property 'deck' of undefined
    at Wt (https://durachok.herokuapp.com/static/js/main.1c08808f.chunk.js:1:32482)
    at https://durachok.herokuapp.com/static/js/main.1c08808f.chunk.js:1:59346
    at Array.some (<anonymous>)
    at https://durachok.herokuapp.com/static/js/main.1c08808f.chunk.js:1:59321
    at Array.map (<anonymous>)
    at https://durachok.herokuapp.com/static/js/main.1c08808f.chunk.js:1:59264
    at https://durachok.herokuapp.com/static/js/main.1c08808f.chunk.js:1:59499
    at Ds (https://durachok.herokuapp.com/static/js/2.d093eaf0.chunk.js:2:592187)
    at t.unstable_runWithPriority (https://durachok.herokuapp.com/static/js/2.d093eaf0.chunk.js:2:610000)
    at Ho (https://durachok.herokuapp.com/static/js/2.d093eaf0.chunk.js:2:532358)```

• Users should be able to resize the chat window by dragging its left border to the left or right
• The chat should always stay scrolled with the newest message at the bottom (doesn't do this when messages are spammed)

Players should have the ability to resign from a game.

• When a player resigns, their cards should be placed at the bottom of the pile. ( We could possibly make this configurable behaviour)

• Players can be removed by the admin in the same way as the 'kick' option removes a player from the lobby.

If the owner of a lobby sends a 'DELETE /lobby/:pin' request whilst there are still active connections in the lobby, they should be terminated and sent back to the home page.

• User should only be able to attempt to skip the round if there is at least one card on the tabletop.

• If the defending user skips, the game must wait until everyone confirms that they have put down everything they want to on the tabletop.

When attempting to join a lobby from the same IP address (any device on your LAN with the same IP address, not necessarily the same device), the game gets stuck on the joining lobby screen rather than displaying a useful error.

If feature enabled, the game should recommend players what cards they can play by highlighting them green in the player deck.