federatedai / fedrec Goto Github PK

Inside the definition of class HeteroFMTransferVariable, there is the following line of code:

self.agg_vx_mul_fg = self._create_variable(name='agg_vx_mul_fg', src=['host'], dst=['guest'])

which means the transmit direction of agg_vx_mul_fg is from host to guest.

Then, inside file hetero_fm_gradient_and_loss.py, there is the following lines of code:

def remote_agg_vx_mul_fg(self, agg_vx_mul_fg, suffix=tuple()):
    self.agg_vx_mul_fg_transfer.remote(obj=agg_vx_mul_fg, role=consts.HOST, idx=-1, suffix=suffix)

which says the transmit direction of agg_vs_mul_fg is from guest to host.

So, there is a conflict between these two places of code.

After some try and test, I found that it is a typo in the definition of HeteroFMTransferVariable. The way it meant to be should be like the following:

self.agg_vx_mul_fg = self._create_variable(name='agg_vx_mul_fg', src=['guest'], dst=['host'])

in other worlds, the transmit direction of agg_vs_mul_fg should be from guest to host.

And after this modification, I can run the hetero_fm example successfully, which would fail otherwise.

PS: I would like to work on this, but may need some help, like some guides on how to setup environment, what test uint should be added before open a PR. Please let me know who should I contact?

您好，请问把这是把推荐模块分离后单独成立的项目么，如果是的话，请问有没有相关学习文档呢？

FedRec中的HeteroFM目前的实现有Arbiter角色，其作用是：生成公钥与私钥，还有是在Arbiter侧用私钥对密文进行解密。问题是：目前想把Arbiter的工作分配到host与guest侧。比如：

• 生成host侧的key_pair，把公钥发给guest，私钥维护在host侧；
• 生成guest侧的key_pair，把公钥发给host，私钥维护在guest侧。
  这样设计没问题吧？