Refactor current LOM PoC about fedbiomed HOT 4 OPEN

@srcansiz As we discussed in the daily, since now we will have just cryptography I would like to implement just the lom functionality, similar to common/sec_agg/_jls.py something like common/sec_agg/_lom.py. I think maybe both they will extend a super class (or maybe not) I can start to implement indepentely see if it works with cryptography and then move to more refined and generic implementation.

Let me know your opinion.

Thanks

Hi @rtaiello,

Extending a super class can be complicated since jls is used in other places and the constructor of jls and lom won't be same since they use different keying material. So creating super class will have impact on other methods and how keying material are passed to the class because all methods and attributes of JLS is very specific to JLS. Therefore, for now, I would suggest to have _lom.py implementation the same way _jls.py is coded but of course if there are some common utilities there is no need to duplicate those.

from fedbiomed.

@srcansiz As we discussed in the daily, since now we will have just cryptography I would like to implement just the lom functionality, similar to common/sec_agg/_jls.py something like common/sec_agg/_lom.py. I think maybe both they will extend a super class (or maybe not) I can start to implement indepentely see if it works with cryptography and then move to more refined and generic implementation.

Let me know your opinion.

Thanks

from fedbiomed.

Hey,

we discuseed with @ybouilla, he will finalize the refactor, in particular, separate the common utils between _lom.py and _jls.py .

First create a _utils.py containing:

• quantize, reverse_quatize, multiply and divide, and import in _secagg_crypter.py
  Modify VEParameters to SAParameters and detach KEY_SIZE (it's not shared or the same default value for LOM).

Second create a test just for the utils, to access weighted averaging over quantized values using these functions.

from fedbiomed.

Thanks Riccardo, I am going to work on a separated branch feature/1115-isolating-methods-for-lom-and-jls

from fedbiomed.