Solve broken Joye-Libert e2e tests about fedbiomed HOT 4 CLOSED

Hi Sergen, thanks for investigating.
I think the above code could gain robustness: we are doing infinte loops (while True:), but can we loop over the number of bit instead (before reaching 256 and leading to a Overflow error

        while gcd(r, self._n_modules) > 1:
            while counter < self.bits_size//8 and len(result)>=self.bits_size//8:
                h = hashlib.sha256()
                h.update(
                    int(t).to_bytes(self.bits_size // 2, "big") +
                    counter.to_bytes(1, "big")
                )
                result += h.digest()
                counter += 1
               

            r = mpz(int.from_bytes(result[-self.bits_size:], "big"))


        return r

from fedbiomed.

I tried to run only the first end-to-end test test_01_secagg_joye_libert_pytorch_experiment_basic

I got a different error:

        if len(validation) != 1 or not math.isclose(validation[0], self._secagg_random, abs_tol=0.03):
>           raise FedbiomedSecureAggregationError(
                f"{ErrorNumbers.FB417.value}: Aggregation has failed due to incorrect decryption."
            )
E           fedbiomed.common.exceptions.FedbiomedSecureAggregationError: FB417: secure aggregation error: Aggregation has failed due to incorrect decryption.

from fedbiomed.

The issue may be twofold:

1. a glitch in end2end tests (immediate cause of the problem)
2. [ ] maybe a bug in FDH.H (test if len(result) < (self.bits_size // 8): is weird) => moved to #1163

from fedbiomed.

I tried to run only the first end-to-end test test_01_secagg_joye_libert_pytorch_experiment_basic

I got a different error:

        if len(validation) != 1 or not math.isclose(validation[0], self._secagg_random, abs_tol=0.03):
>           raise FedbiomedSecureAggregationError(
                f"{ErrorNumbers.FB417.value}: Aggregation has failed due to incorrect decryption."
            )
E           fedbiomed.common.exceptions.FedbiomedSecureAggregationError: FB417: secure aggregation error: Aggregation has failed due to incorrect decryption.

Hi @ybouilla,
Thank you for testing the issue. I am going to run again this test and compare the result that I got before, something may be changed since the issue created.

from fedbiomed.