User object missing in logout callback args under certain conditions about socketio HOT 7 CLOSED

This indeed seems like a strange issue since nothing in that process should be doing anything OS specific. I'll see if I can reproduce it in my local Linux test environment.

from socketio.

Thanks for looking into it, it's very much appreciated! I have created a test case here:

https://github.com/kkkrist/feathersjs-logout-callback-test

Curiously enough it does always receive an almost empty meta.connection object, no matter if i run it in my dev or prod environment:

{ provider: 'socketio', payload: null, user: null, headers: {} }

I'm almost sure I did miss something… but what? Thanks again!

from socketio.

This is probably due to feathersjs-ecosystem/authentication#665.

from socketio.

Oooh, this actually might be an issue because logout will also be sent when the socket disconnects and reconnects and I don't think reconnecting sets that information again.

from socketio.

Confirmed, that's it.

The unstripped params can also be found in meta.socket._feathers, which I'm using now to get the user id. That's much better than my quirky initial workaround.

Is meta.socket._feathers supposed to be internal? If not, should the docs be updated? I guess being able to determine the user in a logout event might be something a lot of real-time apps need. And the fact that a disconnected socket (i.e. closed browser window/tab) triggers it is really neat.

P.S.: It's obvious now, but this was never an OS specific issue. It turned out I've .gitignored package-lock.json some time in the past, so @feathersjs/authentication most probably wasn't the same version in both dev and production.

from socketio.

I confirm this issue.

I am always using connection[Object.getOwnPropertySymbols(connection)[0]]._feathers instead the connection object that arrives in the logout event.
Sometimes it comes empty

from socketio.

This issue was moved to feathersjs/feathers#941

from socketio.