Git Product home page Git Product logo

feather's People

Contributors

blasty avatar duggavo avatar gstart9 avatar jermanuts avatar lalanza808 avatar midar avatar mrdevelopero avatar n-peugnet avatar nekun avatar piconero avatar plowsof avatar rbrunner7 avatar rex4539 avatar rottenwheel avatar sanderfoobar avatar stig-atle avatar tobtoht avatar wowario avatar xiphon avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

feather's Issues

Trezor Model T - Error: Unable to open libusb device

Repro Steps

  1. Connect Trezor Model T with computer and enter pin on device
  2. Start feather wallet > "Open wallet file" > Select wallet file related to the trezor device > "Open wallet"
  3. Enter password for wallet file
  4. image

Logs
libwallet.log
2022-12-03 14:24:52.644 13800 ERROR default contrib/epee/src/portable_storage.cpp:100 portable_storage: wrong binary format - signature mismatch
2022-12-03 14:24:52.645 13800 ERROR wallet.wallet2 src/wallet/wallet2.cpp:4599 !r. THROW EXCEPTION: error::invalid_password
2022-12-03 14:24:52.645 13800 ERROR WalletAPI src/wallet/api/wallet.cpp:723 Error opening wallet: invalid password
2022-12-03 14:24:55.561 18048 WARNING wallet.wallet2 src/wallet/wallet2.cpp:4601 Account on device. Initing device...
2022-12-03 14:24:57.644 18048 ERROR device.trezor.transport src/device_trezor/trezor/transport.cpp:1182 BridgeTransport enumeration failed:Bridge enumeration failed
2022-12-03 14:24:57.786 18048 ERROR WalletAPI src/wallet/api/wallet.cpp:727 Error opening wallet: Unable to open libusb device

These are the logs from the point at which I have selected the wallet and entered my password.

Logs are also saying I have entered an invalid password. This is not the case though, as it is possible to access the wallet with feather wallet when trezor suite has been started beforehand (workaround).

System info
OS Name: Microsoft Windows 11 Enterprise, Version 10.0.22000 Build 22000
Feather Wallet Version: 2.1.0

whose idea was it to add Home & Exchange tab ?

I would like to know, whose idea was it to add Home & Exchange tab to feather wallet ?

Some platforms have their own purpose, when they serve that purpose- users should leave that platform.
But i feel feather wallet is unncessesarily trying to hook its users into spending more time, inside the wallet. Although it allows you to hide those tabs, but still it is adding bloat to the program. It should be just limited to do one thing, and do that well.

However bounties tab are fine, and it would be better if you could exchange completely from within the wallet, Otherwise just remove that feature too. I'm sure no ones uses these feature that you've added to the wallet.

display total fiat balance in places other than the Home tab

I'd roughly divide the information displayed in Feather into three categories:

  1. information strictly related to the wallet's state
  2. information derived from the main exchange rate (balance in fiat and transaction amounts in fiat)
  3. non-essential information (explicit exchange rates, CCS, Bounties, etc.)

out of these, only 1. and 2. are required for using the wallet in everyday situations, 3. is superfluous. however, you can't get rid of 3. (via hiding the Home tab) without also losing a part of 2., namely, your total balance in fiat.

the logical place for it would be in the status bar, but this would make the bar cramped, or, when also displaying the unconfirmed balance, downright unusable. so I suggest displaying it in the tooltip of the balance field in the status bar, and also in the account balance window (accessible by clicking on the balance field).

output window visible after autolock

2.1.0

if you open the details of a coin (output window) and then let the wallet autolock, the contents of the output window remain visible (and the window can't be closed until the wallet is unlocked again). this exposes essential data about the wallet's content while it's locked.

the bug may apply to other secondary Feather windows too.

Upload PGP key (fingerprint) to distinct domains (out-of-band TOFU cross-reference)

This ticket is a request to:

  1. Upload the FeatherWallet Release-Signing PGP key onto multiple domains, and
  2. Document how a user can verify the FeatherWallet Release-Signing PGP key from multiple domains out-of-band when importing the key to their keyring for the first time (TOFU)

Why?

It's possible for a very powerful adversary to comprimise your release infrastructure (or the infrastructure between the server and the client) and get a new feather user to download a malicious version of the release, signature, and the release signing key -- but it's exponentially more difficult for them to comprimise multiple distinct domains.

Remember: monero's release infrastructure has already been comprimised once. And here's a great list of historically relevant cases where this happened:

Part One: Making key available out-of-band

SKS Keyservers

I found that I could obtain your key from Ubuntu's SKS Keyserver. This is great!

Nothing to do here.

https://keys.openpgp.org/

keys.openpgp.org is a newer keyserver that doesn't sync with the others, and it strips UIDs and signatures by default for privacy and to resist certificate spamming attacks

Unfortunately, I could not search for your key on this server by email address because it looks like you've never verified the email address.

Please verify your email address by clicking the link sent to the uid of the key ([email protected]) as described here:

Reddit

Please add your public keys' full fingerprint (8185E158A33330C7FD61BC0D1F76E155CEFBA71C) to the sidebar of your subreddit:

Other domains

I do recommend adding your key to as many other domains as possible, including:

  1. Your official twitter and/or mastodon account (just put the keys' full fingerprint (8185E158A33330C7FD61BC0D1F76E155CEFBA71C) at the top of your profile
  2. Your official keybase.io account
  3. Any domains you own (eg featherwallet.org -- unless that's hosted by GitHub as that would provide zero additional benefits to the public key already hosted in the Git Repo)
  4. Something else?

The more domains you upload it to, the better.

Part Two: Documenting it

After uploading your public key and/or full fingerprint to as many distinct domains as possible, please update the project's documentation to enumerate all of the domains where a user can find the PGP Key (or key fingerprint) and write a paragraph to describe how the user can mitigate the risk of compromised infrastructure by cross-checking the integrity of the key across multiple domains.

Flatpak app

It would be great to offer the app as a Flatpak package (along with current AppImage) and make it available on Flathub.

Thank you for maintaining such a wonderful wallet!

Monero feather wallet

Need help with my Monero Feather wallet please. I have just downloaded latest version 2.1.0 and have updated my ledger device, after syncing no balance is shown. I have also tried to restore from device, but no luck. Any assistance would be greatly appreciated and kindly rewarded. Thank you.

list primary address in Receive tab

there should be an easy way to access a wallet's primary address. the best place for that is in the Address list on the Receive tab. its handling would be the same as that of subaddresses.

[Feature request] Select multiple transactions and get sum of amount

It would be convenient if there was a feature where in the "History" tab, you could select multiple transactions and right click and get an option where it gives you the sum of the amounts. Could this be added? It would save a lot of time in comparison to adding them all up manually.

selected value visible on lock screen if coin control was active before auto-lock

this bug leaks information about the user's funds while the app is locked.

steps to reproduce:

  • activate coin control by selecting one or more outputs for spending on the Coins tab
  • leave the application to automatically lock down
  • the number of selected outputs and their total XMR value is displayed in the locked main window

screenshot:

Buggy multi-accounts

There are some bugs which display incorrect data when viewing/selecting other accounts.

Wallet says account 2 up top but in the list says 10.
image

List says account 79 has balance of .104 XMR, but wallet says balance 0 XMR.
image

List says account 9 has balance of 0 XMR, but wallet says .104 XMR.
image

Could not connect to a node (Tor)

It seems to be the case that it always fails with "Feather is in 'automatic node connection mode' but the websocket server returned no available nodes. Please go to Settings->Node and enter a node manually." when running it with Tor. I tried to synchronize without Tor and use Tor afterwards, but no luck. It always ends up telling me that the web socket server returned no available nodes.

It is odd though, since there actually are a couple of nodes (onion). I tried to connect to them to no avail. Any ideas? Is this a common issue? If so, what is the workaround, if any?

Edit: it appears to be the case that torsocks may just work.

display address index in address list on Receive tab

this is a feature request to display (sub)address indices in the address list on the Receive tab (#0, #1, etc.). the rationale is that it would enable the easy visual identification of created-but-yet-unused subaddresses, without having to label them, better preventing the accidental privacy leaks related to address sharing.

MacOS: cannot open on OS version 10.14.6

Hello,
The Info.plist file mentions version 10.10 as a minimum OS version, and your website mentions version 10.13. Im on version 10.14.6, and I get the "You can’t use this version of the application “feather-2.1.0.app” with this version of macOS." error. I tried downloading version 1.0.1 but get the same error. I don't want to upgrade to not cause breaks in my work (Im a developer), and I believe it should be possible to run it with my version of macOS, do you know how to bypass this requirement, or is there a fix for this ? If there's anything you need me to do to help let me know.
Thank you very much

can't sweep single output to integrated addresses

we previously discussed this in the chat, but let's have it documented here.

versions: Feather 2.0.0, monerod 18.0.0

trying to sweep a single output to an integrated address (106 characters long) fails with the following error:

Can't create transaction: Constructed transaction doesn't appear to send to (all) specified destination address(es). Try creating the transaction again.

an actual example of such an address is:
4GcfBn8eCbYfhMz32Y5PW3diQR6CXNo2dVEgP8cvqUvjVqLCGabtEidMGCo7BWATJ2KSrykxQ5RnGKqUFJKoTsht4gr7CAXrHJpAZC9EEz

P2Pool support?

According to p2pool developers (https://p2pool.io/#help) p2pool mining rewards won't be visible unless the wallet client supports it. Feather wallet isn't included in their list. Does feather support p2pool? If not, perhaps it should be supported.

Feather does not remember remote node’s user credentials after application restart

URI syntax diagram

It is possible to add a password protected Monero node with:

very_username:[email protected]:18081

This works, however, after restarting the application, the remote node is loaded without the user credentials, thereby failing the connection.

After restart, only the host and port is loaded:

example.com:18081

Final remarks:
I think this is a bug 🐛 however it could just as well be a privacy feature ¯⁠\⁠_⁠(⁠ツ⁠)⁠_⁠/⁠¯

Double entries in history list

Some (it seems all old) entries appear twice in history tab:

image

Each pair has the same date and TxID, and editing description of one entry affects other.

Feather version: 2.1.0
Wallet height: 2700196
Daemon height: 2700196
Target height: 2700196
Restore height: 2685729 (2022-08-09)
Synchronized: True
Remote node: xmr-node-usa-east.cakewallet.com:18081
Wallet status: Synchronized
Websocket status: Connected
Tor status: Running
Tor level: 0
Network type: MAINNET
Seed type: 16 word
Device type: Software
View only: False
Primary only: True
Operating system: Windows 10 Version 2009
Timestamp: 1661777737

Xmrig Donateless?

The xmrig donate level option is forcefully set to 1 (without manualy changing source code) and makes it so that the donateless options of xmrig are useless.
Just remove it or make it a 0

/src/utils/xmrig.cpp line 81
arguments << "--donate-level" << "1";

Seed Generation needs to be better for wallets. (1.0.1)

When generating a seed the second letter is always poem.

I don't know what this is? like a glitch or what but have had this happened twice Tails wallet version download on two different fresh tails installs. Should I be concerned?

Suggestion add the ability to add custom words to the seed just like "Electrum Bitcoin wallet"

I Did verify the wallet download.

gpg --import featherwallet.asc
gpg --verify hashes-1.0.1.txt

Good Signature

Then checked that 256checksum matched the signed hashes.txt
Then checked the .asc of the appimage
ggp --verify feather-1.0.1.AppImage.asc feather-1.0.1.AppImage

Good Signature

The .asc was signed with this PGP

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEgYXhWKMzMMf9YbwNH3bhVc77pxwFAmGBeooACgkQH3bhVc77
pxyxYA/6Ap14PmvXx/K5JawUTSxP7Sl5GR2Xu6yuTc+v67daMfWt+RcQr/gcIZnu
4eUV0Sbedl+RtvpsRouR6Y30wCMDCBf43lL5anUFjPUW6Uv+jxi59c2sTD4zEjdk
T5RxWz7wlgsl7TYkNW86AYJjscj+8YjolRcND6TNFfRX0MOD6oij2QgsUTH/+/qB
/R+/WrmnJWVdvHGix7/KLbXy0Ld3Wm+wVBpfAhwf1VO0zIlAbmaGawncBZs4Bm7A
vqZ3UoItaI8v1uqe8RAVBWobITOjM5WRfaWhMsg7C96jaKR5qSdmlwXQDzelN3Yb
gm+/DVWIC2iWz+iNzPnjz67yj1c+DI1YhrJ0gs7qCwYuWh+KJLHgHQeIGWTWC5SV
JS3+i6pqU/Qb820L1Ropn89e8mSiF7heudkYuIix75VJqV1wXhMkljNfLdyQ7BqJ
M4Tvh5kYIhDdHphzKOWr3hPxvwYR+4rtlDfNayR6KjfeDtuVOmgMXaGG6DUX+jRb
GBL0yfWk9FoI7Yqt5wE5orj97mz0846ytAR/Dkc2kBIUM4qNkOYW2xhrL0JPDIF1
YTkgyLNZ7dSRWcSVO9+A2hIkQFKkoIME7HnShaHNy/VrWVpqshf5ND9jAYIahiHy
d3bs+Piv8Xv+qG+3czY9XcfWjV8RbiDVFlWa2qyEdRZ8VzuN7u4=
=OLm+
-----END PGP SIGNATURE-----

Trezor T: Unable to sweep change outputs into multiple outputs

Sweeping 2 utxos into 3 or more output utxos using a trezor fails as it tries to create a transaction. The error displayed is:

Can't create transaction:  unexpected error: Trezor returned failure: code=3, message=Change address not found in outputs

2.1.0
ubuntu 22
Monero 'Fluorine Fermi' (v0.18.1.0-release)

I can send a single output or two outputs. I can add in any other information if needed.

build failed on archlinux

-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/c++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Initiating compile using CMake 3.22.3
found usable ccache: /usr/bin/ccache
-- Looking for sys/prctl.h
-- Looking for sys/prctl.h - found
-- Looking for prctl
-- Looking for prctl - found
-- Found Git: /usr/bin/git (found version "2.35.1")
CMake Error at CMakeLists.txt:63 (message):
[submodule] Monero HEAD was at deb87b22b80f12b9ec373607de1bb739dde91bdb but
should be at 241fe02f5cc5a13b075a052ba272781434433613

-- Configuring incomplete, errors occurred!
See also "/mnt/yay/feather/build/release/CMakeFiles/CMakeOutput.log".
make: *** [Makefile:12: release] Error 1
[arch@e517c54dfa83 feather]$ nano CMakeLists.txt
[arch@e517c54dfa83 feather]$ nano CMakeLists.txt
[arch@e517c54dfa83 feather]$ make release
mkdir -p build/release &&
cd build/release &&
cmake
-DARCH=x86-64
-D BUILD_TAG="linux-x64"
-D CMAKE_BUILD_TYPE=Release
-DTOR_DIR=Off -DTOR_VERSION=Off -DCHECK_UPDATES=Off -DWITH_SCANNER=Off -DREPRODUCIBLE=Off
../.. &&
make
-- Initiating compile using CMake 3.22.3
found usable ccache: /usr/bin/ccache
-- [submodule] Monero HEAD @ deb87b22b80f12b9ec373607de1bb739dde91bdb
-- Found PythonInterp: /usr/bin/python (found version "3.10.2")
-- CMake version 3.22.3
-- Found usable ccache: /usr/bin/ccache
-- The ASM compiler identification is GNU
-- Found assembler: /usr/bin/cc
-- Looking for -Wl,--no-undefined linker flag
-- Looking for -Wl,--no-undefined linker flag - found
-- Looking for -Wl,-undefined,error linker flag
-- Looking for -Wl,-undefined,error linker flag - found
-- Building build tag linux-x64
-- Checking submodules
-- Submodule 'external/unbound' is up-to-date
-- Submodule 'external/rapidjson' is up-to-date
-- Submodule 'external/trezor-common' is up-to-date
-- Submodule 'external/supercop' is up-to-date
-- Could not find DEVELOPER_LOCAL_TOOLS in env (not required)
-- BOOST_IGNORE_SYSTEM_PATHS defaults to OFF
-- Could not find DEVELOPER_LIBUNBOUND_OLD in env (not required)
CMake Warning (dev) at monero/CMakeLists.txt:352 (option):
Policy CMP0077 is not set: option() honors normal variables. Run "cmake
--help-policy CMP0077" for policy details. Use the cmake_policy command to
set the policy and suppress this warning.

For compatibility with older versions of CMake, option is clearing the
normal variable 'BUILD_64'.
This warning is for project developers. Use -Wno-dev to suppress it.

-- Building for a 64-bit system
-- Building internal libraries as static
-- Using LMDB as default DB type
-- Stack trace on exception enabled (using easylogging++)
-- Looking for pthread.h
-- Looking for pthread.h - found
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Success
-- Found Threads: TRUE
-- Performing Test _Werror__pthread_c
-- Performing Test _Werror__pthread_c - Success
-- Performing Test _Werror__pthread_cxx
-- Performing Test _Werror__pthread_cxx - Success
-- Found OpenSSL: /usr/lib/libcrypto.so (found version "1.1.1m")
-- Using OpenSSL include dir at /usr/include
-- Found HIDAPI: /usr/lib/libhidapi-libusb.so
-- Looking for memset_s in c
-- Looking for memset_s in c - not found
-- Looking for explicit_bzero in c
-- Looking for explicit_bzero in c - found
-- Looking for strptime
-- Looking for strptime - found
-- Looking for libunbound
CMake Deprecation Warning at monero/external/unbound/CMakeLists.txt:29 (cmake_minimum_required):
Compatibility with CMake < 2.8.12 will be removed from a future version of
CMake.

Update the VERSION argument value or use a ... suffix to tell
CMake that the project does not need compatibility with older versions.

-- Looking for arpa/inet.h
-- Looking for arpa/inet.h - found
-- Looking for endian.h
-- Looking for endian.h - found
-- Looking for dlfcn.h
-- Looking for dlfcn.h - found
-- Looking for event.h
-- Looking for event.h - found
-- Looking for getopt.h
-- Looking for getopt.h - found
-- Looking for glob.h
-- Looking for glob.h - found
-- Looking for grp.h
-- Looking for grp.h - found
-- Looking for inttypes.h
-- Looking for inttypes.h - found
-- Looking for iphlpapi.h
-- Looking for iphlpapi.h - not found
-- Looking for login_cap.h
-- Looking for login_cap.h - not found
-- Looking for memory.h
-- Looking for memory.h - found
-- Looking for netdb.h
-- Looking for netdb.h - found
-- Looking for netinet/in.h
-- Looking for netinet/in.h - found
-- Looking for pthread.h
-- Looking for pthread.h - found
-- Looking for pwd.h
-- Looking for pwd.h - found
-- Looking for stdarg.h
-- Looking for stdarg.h - found
-- Looking for stdbool.h
-- Looking for stdbool.h - found
-- Looking for stdint.h
-- Looking for stdint.h - found
-- Looking for stdlib.h
-- Looking for stdlib.h - found
-- Looking for strings.h
-- Looking for strings.h - found
-- Looking for string.h
-- Looking for string.h - found
-- Looking for sys/param.h
-- Looking for sys/param.h - found
-- Looking for sys/resource.h
-- Looking for sys/resource.h - found
-- Looking for sys/sha2.h
-- Looking for sys/sha2.h - not found
-- Looking for sys/socket.h
-- Looking for sys/socket.h - found
-- Looking for sys/stat.h
-- Looking for sys/stat.h - found
-- Looking for sys/sysctl.h
-- Looking for sys/sysctl.h - not found
-- Looking for sys/types.h
-- Looking for sys/types.h - found
-- Looking for sys/uio.h
-- Looking for sys/uio.h - found
-- Looking for sys/un.h
-- Looking for sys/un.h - found
-- Looking for sys/wait.h
-- Looking for sys/wait.h - found
-- Looking for syslog.h
-- Looking for syslog.h - found
-- Looking for time.h
-- Looking for time.h - found
-- Looking for unistd.h
-- Looking for unistd.h - found
-- Looking for vfork.h
-- Looking for vfork.h - not found
-- Looking for windows.h
-- Looking for windows.h - not found
-- Looking for winsock2.h
-- Looking for winsock2.h - not found
-- Looking for ws2tcpip.h
-- Looking for ws2tcpip.h - not found
-- Looking for _beginthreadex
-- Looking for _beginthreadex - not found
-- Looking for arc4random
-- Looking for arc4random - not found
-- Looking for arc4random_uniform
-- Looking for arc4random_uniform - not found
-- Looking for chown
-- Looking for chown - found
-- Looking for chroot
-- Looking for chroot - found
-- Looking for ctime_r
-- Looking for ctime_r - found
-- Looking for daemon
-- Looking for daemon - found
-- Looking for endprotoent
-- Looking for endprotoent - found
-- Looking for endservent
-- Looking for endservent - found
-- Looking for fork
-- Looking for fork - found
-- Looking for fseeko
-- Looking for fseeko - found
-- Looking for fsync
-- Looking for fsync - found
-- Looking for getauxval
-- Looking for getauxval - found
-- Looking for getentropy
-- Looking for getentropy - found
-- Looking for getpwnam
-- Looking for getpwnam - found
-- Looking for getrlimit
-- Looking for getrlimit - found
-- Looking for glob
-- Looking for glob - found
-- Looking for gmtime_r
-- Looking for gmtime_r - found
-- Looking for fcntl
-- Looking for fcntl - found
-- Looking for inet_aton
-- Looking for inet_aton - found
-- Looking for inet_ntop
-- Looking for inet_ntop - found
-- Looking for inet_pton
-- Looking for inet_pton - found
-- Looking for initgroups
-- Looking for initgroups - found
-- Looking for ioctlsocket
-- Looking for ioctlsocket - not found
-- Looking for isblank
-- Looking for isblank - found
-- Looking for kill
-- Looking for kill - found
-- Looking for localtime_r
-- Looking for localtime_r - found
-- Looking for malloc
-- Looking for malloc - found
-- Looking for memmove
-- Looking for memmove - found
-- Looking for random
-- Looking for random - found
-- Looking for reallocarray
-- Looking for reallocarray - found
-- Looking for recvmsg
-- Looking for recvmsg - found
-- Looking for sbrk
-- Looking for sbrk - found
-- Looking for sendmsg
-- Looking for sendmsg - found
-- Looking for setregid
-- Looking for setregid - found
-- Looking for setresgid
-- Looking for setresgid - found
-- Looking for setresuid
-- Looking for setresuid - found
-- Looking for setreuid
-- Looking for setreuid - found
-- Looking for setrlimit
-- Looking for setrlimit - found
-- Looking for setsid
-- Looking for setsid - found
-- Looking for setusercontent
-- Looking for setusercontent - not found
-- Looking for sigprocmask
-- Looking for sigprocmask - found
-- Looking for sleep
-- Looking for sleep - found
-- Looking for snprintf
-- Looking for snprintf - found
-- Looking for socketpair
-- Looking for socketpair - found
-- Looking for srandom
-- Looking for srandom - found
-- Looking for strsep
-- Looking for strsep - found
-- Looking for strftime
-- Looking for strftime - found
-- Looking for strlcat
-- Looking for strlcat - not found
-- Looking for strlcpy
-- Looking for strlcpy - not found
-- Looking for strptime
-- Looking for strptime - found
-- Looking for tzset
-- Looking for tzset - found
-- Looking for usleep
-- Looking for usleep - found
-- Looking for writev
-- Looking for writev - found
-- Looking for getaddrinfo
-- Looking for getaddrinfo - not found
-- Looking for stddef.h
-- Looking for stddef.h - found
-- Check size of time_t
-- Check size of time_t - done
-- Check size of gid_t
-- Check size of gid_t - done
-- Check size of in_addr_t
-- Check size of in_addr_t - done
-- Check size of in_port_t
-- Check size of in_port_t - done
-- Check size of int16_t
-- Check size of int16_t - done
-- Check size of int32_t
-- Check size of int32_t - done
-- Check size of int64_t
-- Check size of int64_t - done
-- Check size of int8_t
-- Check size of int8_t - done
-- Check size of pid_t
-- Check size of pid_t - done
-- Check size of rlim_t
-- Check size of rlim_t - done
-- Check size of ssize_t
-- Check size of ssize_t - done
-- Check size of uid_t
-- Check size of uid_t - done
-- Check size of uint16_t
-- Check size of uint16_t - done
-- Check size of uint32_t
-- Check size of uint32_t - done
-- Check size of uint64_t
-- Check size of uint64_t - done
-- Check size of uint8_t
-- Check size of uint8_t - done
-- Looking for PTHREAD_PRIO_INHERIT
-- Looking for PTHREAD_PRIO_INHERIT - not found
-- Looking for pthread_rwlock_t
-- Looking for pthread_rwlock_t - not found
-- Looking for pthread_spinlock_t
-- Looking for pthread_spinlock_t - not found
-- Looking for openssl/conf.h
-- Looking for openssl/conf.h - found
-- Looking for openssl/engine.h
-- Looking for openssl/engine.h - found
-- Looking for openssl/err.h
-- Looking for openssl/err.h - found
-- Looking for openssl/rand.h
-- Looking for openssl/rand.h - found
-- Looking for openssl/ssl.h
-- Looking for openssl/ssl.h - found
-- Looking for NID_secp384r1
-- Looking for NID_secp384r1 - found
-- Looking for NID_X9_62_prime256v1
-- Looking for NID_X9_62_prime256v1 - found
-- Looking for sk_SSL_COMP_pop_free
-- Looking for sk_SSL_COMP_pop_free - found
-- Looking for SSL_COMP_get_compression_methods
-- Looking for SSL_COMP_get_compression_methods - found
-- Looking for EVP_MD_CTX_new
-- Looking for EVP_MD_CTX_new - found
-- Looking for EVP_sha1
-- Looking for EVP_sha1 - found
-- Looking for EVP_sha256
-- Looking for EVP_sha256 - found
-- Looking for EVP_sha512
-- Looking for EVP_sha512 - found
-- Looking for FIPS_mode
-- Looking for FIPS_mode - found
-- Looking for HMAC_Update
-- Looking for HMAC_Update - found
-- Looking for OPENSSL_config
-- Looking for OPENSSL_config - found
-- Looking for SHA512_Update
-- Looking for SHA512_Update - found
-- Found PkgConfig: /usr/bin/pkg-config (found version "1.8.0")
-- Looking for LIBRESSL_VERSION_TEXT
-- Looking for LIBRESSL_VERSION_TEXT - not found
-- Using 64-bit LMDB from source tree
-- Looking for backtrace
-- Looking for backtrace - found
-- backtrace facility detected in default set of libraries
-- Backtrace_LIBRARY:
-- Found Backtrace: /usr/include
-- Performing Test _maes_cxx
-- Performing Test _maes_cxx - Success
-- Setting CXX flag -maes
-- Performing Test _maes_c
-- Performing Test _maes_c - Success
-- Setting C flag -maes
-- Performing Test HAVE_SSSE3
-- Performing Test HAVE_SSSE3 - Success
-- Performing Test HAVE_AVX2
-- Performing Test HAVE_AVX2 - Success
-- Performing Test HAVE_CXX_ATOMICS
-- Performing Test HAVE_CXX_ATOMICS - Success
-- Using HIDAPI include dir at /usr/include/hidapi
-- Found Protobuf: /usr/lib/libprotobuf.so (found version "3.19.4")
-- Protobuf lib: /usr/lib/libprotobuf.so, inc: /usr/include, protoc: /usr/bin/protoc
-- Trezor protobuf messages regenerated out: "."
-- Checking for module 'libusb-1.0'
-- Found libusb-1.0, version 1.0.25
-- Looking for libusb_get_device_list in /usr/lib/libusb-1.0.so
-- Looking for libusb_get_device_list in /usr/lib/libusb-1.0.so - found
-- Looking for libusb_get_port_numbers in /usr/lib/libusb-1.0.so
-- Looking for libusb_get_port_numbers in /usr/lib/libusb-1.0.so - found
-- LibUSB Compilation test: TRUE
-- Trezor compatible LibUSB found at: /usr/include/libusb-1.0
-- Building on x86_64 for x86-64
-- AES support enabled
-- Performing Test _Werror__Wformat_c
-- Performing Test _Werror__Wformat_c - Success
-- Performing Test _Werror__Wformat_cxx
-- Performing Test _Werror__Wformat_cxx - Success
-- Performing Test _Werror__Wformat_security_c
-- Performing Test _Werror__Wformat_security_c - Failed
-- Performing Test _Werror__Wformat_security_cxx
-- Performing Test _Werror__Wformat_security_cxx - Failed
-- Performing Test _Werror__fstack_protector_c
-- Performing Test _Werror__fstack_protector_c - Success
-- Performing Test _Werror__fstack_protector_cxx
-- Performing Test _Werror__fstack_protector_cxx - Success
-- Performing Test _Werror__fstack_protector_strong_c
-- Performing Test _Werror__fstack_protector_strong_c - Success
-- Performing Test _Werror__fstack_protector_strong_cxx
-- Performing Test _Werror__fstack_protector_strong_cxx - Success
-- Performing Test _Werror__fcf_protection=full_c
-- Performing Test _Werror__fcf_protection=full_c - Success
-- Performing Test _Werror__fcf_protection=full_cxx
-- Performing Test _Werror__fcf_protection=full_cxx - Success
-- Performing Test _Werror__fstack_clash_protection_c
-- Performing Test _Werror__fstack_clash_protection_c - Success
-- Performing Test _Werror__fstack_clash_protection_cxx
-- Performing Test _Werror__fstack_clash_protection_cxx - Success
-- Looking for -pie linker flag
-- Looking for -pie linker flag - found
-- Looking for -Wl,-z,relro linker flag
-- Looking for -Wl,-z,relro linker flag - found
-- Looking for -Wl,-z,now linker flag
-- Looking for -Wl,-z,now linker flag - found
-- Looking for -Wl,-z,noexecstack linker flag
-- Looking for -Wl,-z,noexecstack linker flag - found
-- Looking for -Wl,-z,noexecheap linker flag
-- Looking for -Wl,-z,noexecheap linker flag - not found
-- Using C security hardening flags: -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=1 -Wformat -fstack-protector -fstack-protector-strong -fcf-protection=full -fstack-clash-protection
-- Using C++ security hardening flags: -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=1 -Wformat -fstack-protector -fstack-protector-strong -fcf-protection=full -fstack-clash-protection
-- Using linker security hardening flags: -pie -Wl,-z,relro -Wl,-z,now -Wl,-z,noexecstack
-- Found Boost Version: 107800
-- Looking for rl_copy_text
-- Looking for rl_copy_text - found
-- Looking for rl_filename_completion_function
-- Looking for rl_filename_completion_function - found
-- Found readline library at: /usr
-- Looking for a ASM-ATT compiler
-- Looking for a ASM-ATT compiler - /usr/bin/as
Wallet crypto is using amd64-64-24k backend
-- Trezor support enabled
-- Not building tests
-- Not building debug utilities
Doxygen: graphviz not found - graphs disabled
-- Could NOT find Doxygen (missing: DOXYGEN_EXECUTABLE)
CMake Warning (dev) at monero/CMakeLists.txt:1098 (option):
Policy CMP0077 is not set: option() honors normal variables. Run "cmake
--help-policy CMP0077" for policy details. Use the cmake_policy command to
set the policy and suppress this warning.

For compatibility with older versions of CMake, option is clearing the
normal variable 'BUILD_GUI_DEPS'.
This warning is for project developers. Use -Wno-dev to suppress it.

-- You are currently on commit a674770
-- OpenSSL: Version 1.1.1m
-- OpenSSL: include dir at /usr/include
-- OpenSSL: libraries at /usr/lib/libssl.so;/usr/lib/libcrypto.so /usr/lib/libssl.so
-- libsodium: libraries at /usr/lib/libsodium.so
-- QRENCODE PATH /usr/include
-- QRENCODE LIBARY /usr/lib/libqrencode.so
-- Found QREncode: /usr/lib/libqrencode.so
-- Found ZBAR: /usr/lib/libzbar.so
-- Found zbar libraries /usr/lib/libzbar.so
-- libzbar: include dir at /usr/include
-- libzbar: libraries at /usr/lib/libzbar.so
-- Could NOT find zlib (missing: zlib_DIR)
-- Found Boost: /usr/lib64/cmake/Boost-1.78.0/BoostConfig.cmake (found suitable version "1.78.0", minimum required is "1.58") found components: system filesystem thread date_time chrono regex serialization program_options locale
-- Found X11: /usr/include
-- Looking for XOpenDisplay in /usr/lib/libX11.so;/usr/lib/libXext.so
-- Looking for XOpenDisplay in /usr/lib/libX11.so;/usr/lib/libXext.so - found
-- Looking for gethostbyname
-- Looking for gethostbyname - found
-- Looking for connect
-- Looking for connect - found
-- Looking for remove
-- Looking for remove - found
-- Looking for shmat
-- Looking for shmat - found
-- Looking for IceConnectionNumber in ICE
-- Looking for IceConnectionNumber in ICE - found
-- X11_FOUND = TRUE
-- X11_INCLUDE_DIR = /usr/include
-- X11_LIBRARIES = /usr/lib/libSM.so;/usr/lib/libICE.so;/usr/lib/libX11.so;/usr/lib/libXext.so
-- Skipping Tor inclusion because -DTOR_BIN=Off
-- Using Boost include dir at /usr/include
-- Using Boost libraries at Boost::system;Boost::filesystem;Boost::thread;Boost::date_time;Boost::chrono;Boost::regex;Boost::serialization;Boost::program_options;Boost::locale
-- Performing Test _Werror__fno_strict_aliasing_c
-- Performing Test _Werror__fno_strict_aliasing_c - Success
-- Performing Test _Werror__fno_strict_aliasing_cxx
-- Performing Test _Werror__fno_strict_aliasing_cxx - Success
-- Performing Test _Werror__fPIC_c
-- Performing Test _Werror__fPIC_c - Success
-- Performing Test _Werror__fPIC_cxx
-- Performing Test _Werror__fPIC_cxx - Success
-- Using C security hardening flags: -Wformat -fstack-protector -fstack-protector-strong -fcf-protection=full -fstack-clash-protection -fno-strict-aliasing -fPIC
-- Using C++ security hardening flags: -Wformat -fstack-protector -fstack-protector-strong -fcf-protection=full -fstack-clash-protection -fno-strict-aliasing -fPIC
-- Using linker security hardening flags: -pie -Wl,-z,relro -Wl,-z,now -Wl,-z,noexecstack
-- Found GCrypt: /usr/lib/libgcrypt.so
-- Configuring done
-- Generating done
-- Build files have been written to: /mnt/yay/feather/build/release
make[1]: Entering directory '/mnt/yay/feather/build/release'
make[2]: Entering directory '/mnt/yay/feather/build/release'
make[3]: Entering directory '/mnt/yay/feather/build/release'
make[3]: Leaving directory '/mnt/yay/feather/build/release'
make[3]: Entering directory '/mnt/yay/feather/build/release'
[ 0%] Creating directories for 'generate_translations_header'
[ 0%] No download step for 'generate_translations_header'
[ 1%] No update step for 'generate_translations_header'
[ 1%] No patch step for 'generate_translations_header'
[ 2%] Performing configure step for 'generate_translations_header'
-- The C compiler identification is GNU 11.2.0
-- The CXX compiler identification is GNU 11.2.0
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /usr/bin/cc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/c++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
CMake Warning at CMakeLists.txt:53 (message):
lrelease program not found, translation files not built

-- Configuring done
-- Generating done
-- Build files have been written to: /mnt/yay/feather/build/release/monero/translations
[ 2%] Performing build step for 'generate_translations_header'
make[4]: Entering directory '/mnt/yay/feather/build/release/monero/translations'
make[5]: Entering directory '/mnt/yay/feather/build/release/monero/translations'
make[6]: Entering directory '/mnt/yay/feather/build/release/monero/translations'
make[6]: Leaving directory '/mnt/yay/feather/build/release/monero/translations'
make[6]: Entering directory '/mnt/yay/feather/build/release/monero/translations'
[ 50%] Building C object CMakeFiles/generate_translations_header.dir/generate_translations_header.c.o
[100%] Linking C executable generate_translations_header
Generating embedded translations header
make[6]: Leaving directory '/mnt/yay/feather/build/release/monero/translations'
[100%] Built target generate_translations_header
make[5]: Leaving directory '/mnt/yay/feather/build/release/monero/translations'
make[4]: Leaving directory '/mnt/yay/feather/build/release/monero/translations'
[ 2%] Performing install step for 'generate_translations_header'

[ 2%] Completed 'generate_translations_header'
make[3]: Leaving directory '/mnt/yay/feather/build/release'
[ 2%] Built target generate_translations_header
make[3]: Entering directory '/mnt/yay/feather/build/release'
make[3]: Leaving directory '/mnt/yay/feather/build/release'
make[3]: Entering directory '/mnt/yay/feather/build/release'
[ 2%] Building C object monero/external/unbound/CMakeFiles/unbound.dir/services/authzone.c.o
In file included from /mnt/yay/feather/build/release/monero/external/unbound/config.h:1243,
from /mnt/yay/feather/monero/external/unbound/services/authzone.c:44:
/mnt/yay/feather/monero/external/unbound/compat/fake-rfc2553.h:53: warning: "_SS_PADSIZE" redefined
53 | # define _SS_PADSIZE (_SS_MAXSIZE - sizeof (struct sockaddr))
|
In file included from /usr/include/sys/socket.h:33,
from /mnt/yay/feather/build/release/monero/external/unbound/config.h:979,
from /mnt/yay/feather/monero/external/unbound/services/authzone.c:44:
/usr/include/bits/socket.h:190: note: this is the location of the previous definition
190 | #define _SS_PADSIZE
|
In file included from /mnt/yay/feather/build/release/monero/external/unbound/config.h:1243,
from /mnt/yay/feather/monero/external/unbound/services/authzone.c:44:
/mnt/yay/feather/monero/external/unbound/compat/fake-rfc2553.h:54:8: error: redefinition of ‘struct sockaddr_storage’
54 | struct sockaddr_storage {
| ^~~~~~~~~~~~~~~~
In file included from /usr/include/sys/socket.h:33,
from /mnt/yay/feather/build/release/monero/external/unbound/config.h:979,
from /mnt/yay/feather/monero/external/unbound/services/authzone.c:44:
/usr/include/bits/socket.h:193:8: note: originally defined here
193 | struct sockaddr_storage
| ^~~~~~~~~~~~~~~~
In file included from /mnt/yay/feather/build/release/monero/external/unbound/config.h:1243,
from /mnt/yay/feather/monero/external/unbound/services/authzone.c:44:
/mnt/yay/feather/monero/external/unbound/compat/fake-rfc2553.h:68:8: error: redefinition of ‘struct in6_addr’
68 | struct in6_addr {
| ^~~~~~~~
In file included from /mnt/yay/feather/build/release/monero/external/unbound/config.h:991,
from /mnt/yay/feather/monero/external/unbound/services/authzone.c:44:
/usr/include/netinet/in.h:219:8: note: originally defined here
219 | struct in6_addr
| ^~~~~~~~
/mnt/yay/feather/monero/external/unbound/compat/fake-rfc2553.h:69:17: error: expected ‘:’, ‘,’, ‘;’, ‘}’ or ‘attribute’ before ‘.’ token
69 | uint8_t s6_addr[16];
| ^~~~~~~
In file included from /mnt/yay/feather/build/release/monero/external/unbound/config.h:1243,
from /mnt/yay/feather/monero/external/unbound/services/authzone.c:44:
/mnt/yay/feather/monero/external/unbound/compat/fake-rfc2553.h:74:8: error: redefinition of ‘struct sockaddr_in6’
74 | struct sockaddr_in6 {
| ^~~~~~~~~~~~
In file included from /mnt/yay/feather/build/release/monero/external/unbound/config.h:991,
from /mnt/yay/feather/monero/external/unbound/services/authzone.c:44:
/usr/include/netinet/in.h:260:8: note: originally defined here
260 | struct sockaddr_in6
| ^~~~~~~~~~~~
In file included from /mnt/yay/feather/build/release/monero/external/unbound/config.h:1243,
from /mnt/yay/feather/monero/external/unbound/services/authzone.c:44:
/mnt/yay/feather/monero/external/unbound/compat/fake-rfc2553.h:136:8: error: redefinition of ‘struct addrinfo’
136 | struct addrinfo {
| ^~~~~~~~
In file included from /mnt/yay/feather/monero/external/unbound/compat/fake-rfc2553.h:45,
from /mnt/yay/feather/build/release/monero/external/unbound/config.h:1243,
from /mnt/yay/feather/monero/external/unbound/services/authzone.c:44:
/usr/include/netdb.h:565:8: note: originally defined here
565 | struct addrinfo
| ^~~~~~~~
make[3]: *** [monero/external/unbound/CMakeFiles/unbound.dir/build.make:76: monero/external/unbound/CMakeFiles/unbound.dir/services/authzone.c.o] Error 1
make[3]: Leaving directory '/mnt/yay/feather/build/release'
make[2]: *** [CMakeFiles/Makefile2:792: monero/external/unbound/CMakeFiles/unbound.dir/all] Error 2
make[2]: Leaving directory '/mnt/yay/feather/build/release'
make[1]: *** [Makefile:136: all] Error 2
make[1]: Leaving directory '/mnt/yay/feather/build/release'
make: *** [Makefile:12: release] Error 2

add websocket nodes as node option to Broadcast transaction

suggestion

add a third option, "Websocket", to the Node options in the Broadcast transaction window that lists the websocket Tor nodes and lets the user choose one of them for propagating the given transaction.

rationale

network-layer privacy matters too, and increasing the options for how you propagate a transaction improves that. this feature would make it very easy to select a Tor node for that.

Not working with old wallet and old transactions

Hello,

I use the feather wallet 2.1.0 for Windows and I tried to restore a wallet from a seed.
The wallet was created in December 2019 and it has only 1 transaction from December 2019. The transaction sent XMR to the wallet. The wallet uses a 25 words seed with a restore height value. Both are 100% correct. The feather wallet synchronized successfully and it did not detect the transaction. The balance is 0 XMR.

I did the same thing with the Monero GUI wallet and it detected everything successfully.

add option to not cache wallet file paths

Feather 2.1.0, AppImage

wallet file paths are retained by the application in the initial "Welcome to Feather Wallet" window at the "Open wallet file" stage, and further paths can be found if you click "Browse" and extend the path bar downwards. in some cases this is considered bad security practice. I suggest adding a check mark option to the "Welcome to Feather Wallet" window that disables caching wallet file paths and deletes the currently cached ones upon checking it.

Version 2.1.0 won't build without -DTOR_DIR due to config-feather.h not being generated

I was packaging feather for gentoo linux, and I'm generating config-feather.h in the build script: https://github.com/gentoo-monero/gentoo-monero/blob/6d409a872a5f530ab0c6003c92741f1564ccee4b/net-misc/feather/feather-2.1.0.ebuild, giving TOR_VERSION a dummy value like "NOT_EMBEDDED". However this is sort of a hack, and I thought you should know about it so it can be fixed in a future release. It just doesn't build without config-feather.h.

sweeping to primary address sweeps to that of the first account only

Feather 2.1.0, AppImage

steps to reproduce

  • open a wallet that has at least two accounts
  • have funds in the 2nd account
  • sweep a coin to the primary address (check "Send to self (churn)", the Address field should say "Primary address")
  • see the coin show up on the 1st account's primary address

this is dangerous because it mixes coins in an unintended way. please look into it.

add option to broadcast wallet transactions through Tor

those who have a local non-Tor Monero node need to compromise either on node sovereignty (connect to Tor remote nodes offered by Feather) or network-layer transaction privacy (broadcast their transactions through clearnet).

I suggest that when the node selection is Custom list and it includes a local node address (127.0.0.1:...), display a checkbox at the bottom of the advanced send window that lets the user broadcast the transaction only to Tor nodes (be those either addresses coded into Feather or added by the user to the Custom list, though the ones in the Custom list should be prioritized, since there's a chance these are nodes owned by the user).

signing offline / mainnet

using feather.appimage on tails

offline wallet has all private keys

online wallet is view only on another device

wallet has balance, found by view only wallet.

tried to sign a transaction offline, got an error, found docs explaining how to sync wallets before signing transaction offline.

have exported the outputs from view only wallet

ISSUE : when i try to import those outputs in offline wallet
ERROR message :

`Failed to import outputs.

`Failed` to connect to daemon`

More support for seed offsets

It would be nice to have more support for seed offsets, for example when creating an new seed or viewing a seed of an owned wallet

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.