Git Product home page Git Product logo

Comments (10)

tokoko avatar tokoko commented on July 20, 2024 1

Probably. I'm thinking of marking it as deprecated right from the get go and we can eventually make a breaking change.

from feast.

franciscojavierarceo avatar franciscojavierarceo commented on July 20, 2024 1

I can probably take this one if you're not in a rush for this.

from feast.

tokoko avatar tokoko commented on July 20, 2024 1

Sure, there are already workarounds for it, so we should get by in the meantime. I'll assign you, let us know if you won't be able to find time for it.

from feast.

tokoko avatar tokoko commented on July 20, 2024

cc @dmartinol

from feast.

dmartinol avatar dmartinol commented on July 20, 2024

can we keep backward compatibility by adding an optional includes_subclasses that default to False?

from feast.

franciscojavierarceo avatar franciscojavierarceo commented on July 20, 2024

Going to take care of this over the next couple of days.

Two steps:

  1. Create FeatureViewType in the BaseFeatureView
  2. Add it to the 3 as metadata and use that to return the list of feature views broken down by type

I'm working on (1) right now and will update when done (it should be quick).

from feast.

tokoko avatar tokoko commented on July 20, 2024

Didn't really get the need for the first one, can't you just check the type of an object?

from feast.

franciscojavierarceo avatar franciscojavierarceo commented on July 20, 2024

Yeah, definitely could but I'd rather have more explicit metadata surrounding it.

That said, I really don't see any other data types outside of On Demand, Batch, and Stream.

from feast.

franciscojavierarceo avatar franciscojavierarceo commented on July 20, 2024

after looking into this, it's a pretty big change actually. I think it's worth doing but just want to state it explicitly.

from feast.

franciscojavierarceo avatar franciscojavierarceo commented on July 20, 2024

So first unblock is list_feature_views which is a clunky wrapper but at least gives some small support. I'll change the return object next but I thought I'd at least return the quick one.

#4256

from feast.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.