'feast.ui_server' is not a package about feast HOT 11 CLOSED

Good, agreed. Will come back tomorrow for this. Thanks for the ping-pong 🏓

from feast.

This happened to me to. The problem is related to importlib_resources.

Problem: this does not work with importlib.resources
Solution: install importlib-resources

To validate this, you can run and it should work. I can PR:

from unittest import mock
import importlib_resources


with mock.patch("feast.ui_server.importlib_resources", new=importlib_resources):
        store = FeatureStore()
        store.serve_ui(
            host=host,
            port=port,
            get_registry_dump=registry_dump,
            registry_ttl_sec=registry_ttl_sec,
            root_path=root_path,
        )

from feast.

The importlib of Python involves many changes and deprecations in newer Python versions. I would prefer to modify the code and catch the latest changes in importlib.resources

from feast.

So you suggest fixing this using the built-in one, instead of installing importlib-resources?

from feast.

I think I broke this, sorry about that :). changing importlib_resources.files(__name__) with importlib_resources.files('feast') should be a fix if I'm not mistaken. I was for some reason still not able to start the ui server with the change applied, but it seemed to fix the is not a package error. If anyone can verify it, would be a great help...

from feast.

v0.38.0
v0.37.1

For what I see, the difference is using the builtin vs the library. Not the package name

from feast.

Yes, I made the change in #4109. The difference apparently is that files method in library expects anchor file path as a first parameter, while the same method in built-in expects a package name. I thought there were supposed to be drop-in replacements and missed that...

from feast.

Yes, should be TBH. I can PR this tomorrow if it helps.
Option A) we re-install the lib
Option B) we fix it using the built-in if possible

WDYT?

from feast.

yup, I'd prefer fixing it with built-in if possible. importlib libraries are pretty popular and have caused diamond dependency problems before... so if there's a way to not depend on them, that would be a plus. thanks a lot

from feast.

So you suggest fixing this using the built-in one, instead of installing importlib-resources?

yes, the Python built-in one is preferred as the discussion concluded.

from feast.

PR raised here:
#4248

from feast.