fdouetteau / bottle-mongodb-plugin Goto Github PK

I know that Python 2.5 isn't the most necessary thing to support anymore, but we're using mongo db and bottle at my work and, due to embedded versions of python in various desktop apps, we need to occasionally support 2.5. If you changed the:

from json import dumps as json_dumps

to:

try:
from json import dumps as json_dumps
except ImportError:
from simplejson import dumps as json_dumps

It would at least use the fallback that wasn't introduced until 2.6. I don't see any obvious other issues with your code and 2.6.

The error message "Found another redis plugin...." should be "Found another MongoDB plugin..."

I would like to respectively suggest that a notice be added to the README. You see, your plugin no longer works, and it's only two characters different from the official working plugin. It would be helpful to display that this plugin is not the official plugin. And it doesn't seem to be maintained. (No offense!)

pip install bottle-mongodb versus pip install bottle-mongo is very easy to confuse.

I accidentally installed this plugin (using pip) when I meant to install the other plugin. It took me a long time to realize why my project wasn't working.

See also: https://github.com/bottlepy/bottle-mongo