faykah / emails-en Goto Github PK

Hi there!

I noticed in the index.d.ts that the type of the exported emails was the following.

const emails: String[];

I think this is a mistake and it should rather be string.

const emails: string[];

Since string is the primitive type, whereas String is a wrapper object and it therefore is a total different type for the TypeScript compiler, which has incompatibility issues with several string methods.

What do you think?

Is your feature request related to a problem? Please describe.

The repository should have an issue template for feature requests.

Describe the solution you'd like

Use the template from here.

Describe alternatives you've considered

None.

Additional context

None.

Is your feature request related to a problem? Please describe.

There is no template for pull requests.

Describe the solution you'd like

There should be a template for pull requests like this one.

Describe alternatives you've considered

None.

Additional context

None.

Describe the bug

There is an issue with the browser property that is pointing to the wrong library file.

To Reproduce

Steps:

1. Go to https://github.com/faykah/emails-en/blob/v0.1.1/package.json
2. See that the file pointed by the browser property is wrong.

Expected behavior

It should point to lib/index.browser.min.js instead of lib/main.browser.min.js

Screenshots

None.

Environment (please complete the following information):

• Operating system & version: N/A.
• Node.js version: N/A.
• NPM version: N/A.
• @faykah/emails-en version: v0.1.1

Additional context

None.

Is your feature request related to a problem? Please describe.

Currently, there is no way of requesting the module from @faykah/emails-en using the module parameter when using Unpkg.

Describe the solution you'd like

A module property in the package.json that points to the lib/index.esm.js module. That way, it would be possible to enable requests to Unpkg using the following: https://unpkg.com/@faykah/emails-en?module instead of querying for the full url like https://unpkg.com/@faykah/emails-en/lib/index.esm.js.

Describe alternatives you've considered

None.

Additional context

None.

Is your feature request related to a problem? Please describe.

The repository has no license.

Describe the solution you'd like

The repository should be licensed under the GPLv3 terms.

Describe alternatives you've considered

None.

Additional context

None.

Is your feature request related to a problem? Please describe.

There is no issue template for bug reports.

Describe the solution you'd like

There should be a template for bug reports like this one.

Describe alternatives you've considered

None.

Additional context

None.

Is your feature request related to a problem? Please describe.

There is no contributing guidelines in the repository.

Describe the solution you'd like

There should be a contributing guideline file at the root of the repository named CONTRIBUTING.md that list all the requirements for working with that repository and contributing with pull requests.

Describe alternatives you've considered

None.

Additional context

None.