Git Product home page Git Product logo

Comments (8)

GibreelAbdullah avatar GibreelAbdullah commented on July 20, 2024 2

Found more such Ahadith, but this issue is a bit different. In Sunnah.com these two numbers have 2 hadiths associated with them.

https://cdn.jsdelivr.net/gh/fawazahmed0/hadith-api@1/editions/eng-tirmidhi/1424.min.json
https://cdn.jsdelivr.net/gh/fawazahmed0/hadith-api@1/editions/eng-tirmidhi/1425.min.json

https://sunnah.com/tirmidhi/17

from hadith-api.

GibreelAbdullah avatar GibreelAbdullah commented on July 20, 2024 1

InShaAllah, will work on it. Am traveling this weekend, by next weekend only I will be free.

from hadith-api.

GibreelAbdullah avatar GibreelAbdullah commented on July 20, 2024

Adding few more examples -

https://sunnah.com/muslim:637
https://cdn.jsdelivr.net/gh/fawazahmed0/hadith-api@1/editions/eng-muslim/637.min.json

https://sunnah.com/muslim:852
https://cdn.jsdelivr.net/gh/fawazahmed0/hadith-api@1/editions/eng-muslim/852.min.json

from hadith-api.

unkn4wn avatar unkn4wn commented on July 20, 2024

Adding few more examples -

https://sunnah.com/muslim:637 https://cdn.jsdelivr.net/gh/fawazahmed0/hadith-api@1/editions/eng-muslim/637.min.json

https://sunnah.com/muslim:852 https://cdn.jsdelivr.net/gh/fawazahmed0/hadith-api@1/editions/eng-muslim/852.min.json

Be careful. This isnt the same hadith. The hadithnumber in the Hadith api Sahih Muslim is completely different than the hadithnumber in sunnah.com
You need to look at "arabicnumber" in the api

from hadith-api.

unkn4wn avatar unkn4wn commented on July 20, 2024

For eg - Bukhari 4434 is missing in linebyline folder.

Also missing in API - https://cdn.jsdelivr.net/gh/fawazahmed0/hadith-api@1/editions/eng-bukhari/4434.min.json

But Sunnah.com has it - https://sunnah.com/bukhari:4434

There are multiple such issues

And this hadith isn't really missing. The Api shows this hadith as hadith number 4433 while sunnah.com shows this hadith as 4433,4434. Check these both links:
https://cdn.jsdelivr.net/gh/fawazahmed0/hadith-api@1/editions/eng-bukhari/4433.min.json
https://sunnah.com/bukhari:4434

Only 4433 is mentioned in this api because there's no way to mention two numbers as "hadithnumber" except we are converting "hadithnumber" to a string.
But idk if this would break sites/apps which are using this api right now.

from hadith-api.

GibreelAbdullah avatar GibreelAbdullah commented on July 20, 2024

Jazakallahu Khairan

Could have duplicate for both 4433 and 4434 instead of giving blank for one.

from hadith-api.

GibreelAbdullah avatar GibreelAbdullah commented on July 20, 2024

Are there any plans for it brother @fawazahmed0.

I am thinking of creating a script to copy the data of

https://cdn.jsdelivr.net/gh/fawazahmed0/hadith-api@1/editions/eng-bukhari/4433.min.json
to
https://cdn.jsdelivr.net/gh/fawazahmed0/hadith-api@1/editions/eng-bukhari/4434.min.json

and similarly for all such cases.

from hadith-api.

fawazahmed0 avatar fawazahmed0 commented on July 20, 2024

I am thinking of creating a script to copy the data

If you could submit a PR, that will be very helpful

from hadith-api.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.