fauxnik / dv-comms-radio-api Goto Github PK

So it took a bit for me to figure this one out and it's still entirely possible I'm doing something wrong.

When the comm radio gets put away and then pulled back out while on the mode registered through this api - the mode appears to reset it's internal state, but doesn't appear to update the screen.

I resolved this experimentally in my own local environment by changing the Enable function here:

to

public void Enable() { activeState = startingState; if (null != activeState) { ApplyState(); activeState.OnEnter(proxy, null); } }

Doing so caused the screen to update as expected. I'm not sure if this is the preferred way to solve this, but it does resolve the issue of the screen and state being out of sync until the next state is triggered (in my case by a raycast)

I'm not sure which instances this is, but it seems under certain circumstances the transform might get set incorrectly the first time a mode is loaded, and it doesn't get updated.

https://github.com/fauxnik/dv-comms-radio-api/blob/main/CommsRadioAPI/CommsRadioMode.cs#L91 only updates if the current signalSource is null, but doesn't account for if it's different

I can try to provide a pull request later, but for now this is preventing me from using this api as I had hoped.

Some utility functions that would be nice to have in this API rather than having to recreate them:

• Common raytrace identifiers (car, interior, switch, track, probably one or two I am not thinking of)
• Custom raytrace (provide just the layermask)
• Car highlighter
• Rail highlighter (have to provide length?)