fattureincloud / fattureincloud-js-sdk Goto Github PK

Describe the bug
The OAuth2AuthorizationCodeTokenResponse class returns undefined for all properties (tokenType, accessToken, redirectUri, expiresIn, refreshToken) when calling the refreshToken method of OAuth2AuthorizationCodeManager.

Env info

• Node version: v20.11.0
• JS SDK version: 2.0.17

To Reproduce
Utilize the refreshToken method within OAuth2AuthorizationCodeManager to refresh an access token. The method does not await the asynchronous call properly, leading to the issue.

var tokenObj = await oauth.refreshToken(json["refresh_token"]); console.log(tokenObj)
Produce this:
OAuth2AuthorizationCodeTokenResponse { tokenType: undefined, accessToken: undefined, redirectUri: undefined, expiresIn: undefined, refreshToken: undefined }

Expected behavior
refreshToken should return an instance of OAuth2AuthorizationCodeTokenResponse with all fields populated based on the API response.

Additional context
The issue seems to stem from not handling the promise returned by tokenRequest correctly in refreshToken. Proper promise resolution or async/await usage could fix this.
The portion of code that produce the error in the sdk:

refreshToken(refreshToken) {
  const tokenUri = `${this.baseUri}/oauth/token`;

  const data = {
    grant_type: 'refresh_token',
    client_id: this.clientId,
    client_secret: this.clientSecret,
    refresh_token: refreshToken
  };

  // Directly returning the promise without waiting for its resolution
  const res = this.tokenRequest(tokenUri, data);
  return new OAuth2AuthorizationCodeTokenResponse(res.token_type, res.access_token, res.refresh_token, res.expires_in);
}