404 Not Found on OPTIONS request about fastify-cors HOT 16 CLOSED

Apologies for the slow reply. What we think might be happening, is that in our application, we are registering a main app.js plugin, after index.js. https://github.com/58bits/fastify-20/blob/master/index.js - and that if instead the fastify-cors module is loaded in index.js (top level scope?) it works.

We still don't know 100% why, and have not had time to dig into find-my-way, or the problem in more detail.

For now - we've simply created our own plugin, using the '/*' catch-all route as follows (leaning heavily on the fastify-cors module as an example).

'use strict'

const fp = require('fastify-plugin')

async function setup (app) {
  // Wildcard OPTIONS handler for CORS preflight requests
  app.route({
    method: 'OPTIONS',
    url: '/*',
    handler: async (request, reply) => {

      var reqAllowedHeaders = request.headers['access-control-request-headers']
      if (reqAllowedHeaders !== undefined) {
        reply.header('Access-Control-Allow-Headers', reqAllowedHeaders)
      }
      reply.code(204)
        .header('Content-Length', '0')
        .header('Access-Control-Allow-Origin', 'http://localhost:8080')
        .header('Access-Control-Allow-Credentials', true)
        .header('Access-Control-Allow-Methods', 'GET,HEAD,PUT,PATCH,POST,DELETE')
        .send()
    }
  })

  // CORS reply - 'Access-Control-Allow-Origin', '*' for now..
  // See https://github.com/fastify/fastify-cors/issues/20
  app.addHook('onRequest', function (request, reply, next) {
    reply.header('Access-Control-Allow-Origin', 'http://localhost:8080')
    reply.header('Access-Control-Allow-Credentials', true)
    next()
  })
}

module.exports = fp(setup)

from fastify-cors.

Try this... https://github.com/58bits/fastify-20

from fastify-cors.

Sorry both @daveamayombo and I are on the road until later this week. Stay tuned...

from fastify-cors.

This is a different problem as OP says OPTIONS, but I struggled to fix curl -I http://127.0.0.1:3000 returns 404.

For others who miss the document, this helped me a lot.

const app = fastify({
    exposeHeadRoutes: true,       // <-- this option
})

Related

• fastify/fastify#2700
• fastify/fastify#2826

from fastify-cors.

I think I've found the problem. Implementing my own wildcard route for OPTIONS requests using /* instead of * works.
e.g.:

.route({
      method: 'OPTIONS',
      url: '/*',
      handler: async (request, reply) => {
        reply.code(204)
          .header('Content-Length', '0')
          .header('Access-Control-Allow-Origin', '*')
          .header('Access-Control-Allow-Methods', 'GET,HEAD,PUT,PATCH,POST,DELETE')
          .send()
      }
    })

Is this possibly related to fastify/fastify#81 ?

I'm using fastify v2.0.1 and fastify-cors v2.1.2 on node v10.15.3

from fastify-cors.

Can you please add a full repro for your problem? Something I can execute straight away.

It looks like it might be a bug somewhere cc @delvedor

from fastify-cors.

Sure - I'll setup a public repo in a little while.

from fastify-cors.

@delvedor can you take a look? This seems something that goes deep down in find-my-way.

from fastify-cors.

I have the same issue. How to solve this?

from fastify-cors.

I think I've found the problem. Implementing my own wildcard route for OPTIONS requests using /* instead of * works.
e.g.:

.route({
      method: 'OPTIONS',
      url: '/*',
      handler: async (request, reply) => {
        reply.code(204)
          .header('Content-Length', '0')
          .header('Access-Control-Allow-Origin', '*')
          .header('Access-Control-Allow-Methods', 'GET,HEAD,PUT,PATCH,POST,DELETE')
          .send()
      }
    })

Is this possibly related to fastify/fastify#81 ?

I'm using fastify v2.0.1 and fastify-cors v2.1.2 on node v10.15.3

I have tried your workaround. But not work for me

from fastify-cors.

Quick note with more to come - but it may be that the way we are registering app.js - without using fastify-plugin, is affecting the scope of fastify-cors.

from fastify-cors.

it seems you folks a have a better understanding of your issue than us. Would you like to send a PR?

from fastify-cors.

Not really understand what to do, what do you mean by "the way we are registering app.js"? @58bits

from fastify-cors.

@58bits thank you, your example works excellent.

from fastify-cors.

@58bits please upgrade to the latest version. I think it was fixed with delvedor/find-my-way#133

from fastify-cors.

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

from fastify-cors.