Support Private Network CORS about fastify-cors HOT 8 OPEN

Thanks for reporting! Would you like to send a Pull Request to address this issue? Remember to add unit tests.

from fastify-cors.

I would treats it the same as fastify/fastify-cookie#261

In order to get the PR accepted,

• Mark the feature as experimental (meaning it would change or remove in any time without major bump).
• Details on README.md to explain why it is marked as experimental.

from fastify-cors.

Hi @danjenkins

I was thinking of working on this. I'm wondering do we need to do this part as well, if I fix the CORS thing. Also that is the error without fixing the CORS thing.

I've attached an example of what I've added as a patch to @fastify/cors which will need some extra work if these > changes are accepted... like only setting the response if the Access-Control-Request-Private-Network: true header is in > the request.

from fastify-cors.

@Rai-Sahil do you mean what is the error? The error is that the request fails because the browser doesn't get given the right headers in the response.

To do it properly we need to check if the request has the header Access-Control-Request-Private-Network before setting Access-Control-Allow-Private-Network in the response.

If you'd like to take this on and make a PR feel free :) Don't forget about the unit tests though. If not I can do a PR with unit tests.

from fastify-cors.

@danjenkins Thanks, I'll start working on it. I'll comment here if I have any further questions

from fastify-cors.

@danjenkins @Rai-Sahil

I'm -1 on this for the time being until all major browsers support this, not just Chromium. Thanks for raising it though!

Firefox's support for this is in prototype stage, and WebKit's position on this is tentative.

from fastify-cors.

@Fdawgs yeah, I'm in two minds but it's causing problems with things running in chrome canary and I'm pretty certain it will be causing problems in other versions of chrome too... hence why I wrote the patch :)

I'm good waiting to see how it all pans out and to carry on using my patch file for now...

🤷‍♂️

from fastify-cors.